Re: Integration of nnmairix.el

[Katsumi Yamaoka <yamaoka@jpl.org>]

[-- Attachment #1: Type: text/plain, Size: 1861 bytes --]

>>>>> Reiner Steib wrote:

> Thanks.  I added the version 0.5 from the emacswiki now.  Sorry for
> the delay.

Sorry for finding fault with it.  But many warnings are issued
when compiling.  Most of them look harmless, however the ones
concerning `nnmairix-request-group-with-article-number-correction'
seem to be real problems.  A patch is attached below, though I'm
not sure of it.  I would appreciate reviewing it.

Regards,

In toplevel form:
nnmairix.el:340:7:Warning: assignment to free variable `nnmairix-group-regexp'
nnmairix.el:344:7:Warning: assignment to free variable
    `nnmairix-valid-backends'
nnmairix.el:347:7:Warning: assignment to free variable `nnmairix-last-server'
nnmairix.el:350:7:Warning: assignment to free variable
    `nnmairix-current-server'

In nnmairix-open-server:
nnmairix.el:360:9:Warning: assignment to free variable
    `nnmairix-current-server'

In nnmairix-request-list:
nnmairix.el:521:37:Warning: reference to free variable `nnmairix-group-regexp'

In nnmairix-purge-old-groups:
nnmairix.el:793:41:Warning: reference to free variable `nnmairix-group-regexp'

In nnmairix-request-group-with-article-number-correction:
nnmairix.el:977:53:Warning: reference to free variable `fast'
nnmairix.el:1009:68:Warning: reference to free variable `group'

In nnmairix-get-server:
nnmairix.el:1056:52:Warning: reference to free variable `nnmairix-last-server'
nnmairix.el:1058:11:Warning: assignment to free variable
    `nnmairix-last-server'

In nnmairix-get-valid-servers:
nnmairix.el:1107:40:Warning: reference to free variable
    `nnmairix-valid-backends'

In nnmairix-update-and-clear-marks:
nnmairix.el:1262:31:Warning: reference to free variable
    `nnmairix-group-regexp'

In end of data:
nnmairix.el:1549:1:Warning: the function `gnus-registry-fetch-group' is not
    known to be defined.
Wrote gnus/lisp/nnmairix.elc


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 2046 bytes --]

--- nnmairix.el~	2008-02-26 21:42:09 +0000
+++ nnmairix.el	2008-02-27 02:32:03 +0000
@@ -336,18 +336,19 @@
 
 ;;; === Internal variables
 
-;; Regexp for mairix groups on back end
-(setq nnmairix-group-regexp (format "%s-\\(.*\\)-[0-9]+" nnmairix-group-prefix))
+(defvar nnmairix-group-regexp
+  (format "%s-\\(.*\\)-[0-9]+" nnmairix-group-prefix)
+  "Regexp for mairix groups on back end.")
+
+(defvar nnmairix-valid-backends '(nnimap nnml nnmaildir)
+  "Back ends (hopefully...) supported by nnmairix.
+Other backends might or might not work.")
 
-;; Back ends (hopefully...) supported by nnmairix.
-;; Other backends might or might not work.
-(setq nnmairix-valid-backends '(nnimap nnml nnmaildir))
+(defvar nnmairix-last-server nil
+  "Last chosen server.")
 
-;; Last chosen server
-(setq nnmairix-last-server nil)
-
-;; Current server
-(setq nnmairix-current-server nil)
+(defvar nnmairix-current-server nil
+  "Current server.")
 
 ;;; === Gnus backend functions
   
@@ -843,6 +844,9 @@
 	  (set-process-sentinel (apply 'start-process args)
 				'nnmairix-sentinel-mairix-update-finished))))))
 
+(eval-and-compile
+  (autoload 'gnus-registry-fetch-group "gnus-registry"))
+
 (defun nnmairix-goto-original-article (&optional no-registry)
   "Jump to the original group and display article.
 The original group of the article is first determined with the
@@ -974,7 +978,7 @@
   "Request FOLDER on backend for nnmairix QUALGROUP and article number correction."
   (save-excursion
     (nnmairix-call-backend
-     "request-group" folder nnmairix-backend-server fast)
+     "request-group" folder nnmairix-backend-server)
     (set-buffer nnmairix-mairix-output-buffer)
     (goto-char (point-min))
     (re-search-forward "^Matched.*messages")
@@ -1006,7 +1010,7 @@
 		(gnus-group-set-parameter
 		 qualgroup 'numcorr (list nil 0 high))))
 	    (erase-buffer)
-	    (insert (format "%d %d %d %d %s" status total low high group))
+	    (insert (format "%d %d %d %d %s" status total low high qualgroup))
 	    t)
 	(progn
 	  (nnheader-report