From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/66359 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: Re: Integration of nnmairix.el Date: Wed, 27 Feb 2008 11:33:55 +0900 Organization: Emacsen advocacy group Message-ID: References: <87ve65usi5.fsf@arcor.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1204079765 13012 80.91.229.12 (27 Feb 2008 02:36:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Feb 2008 02:36:05 +0000 (UTC) Cc: ding@gnus.org To: David Original-X-From: ding-owner+M14850@lists.math.uh.edu Wed Feb 27 03:36:30 2008 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1JUC9m-0005Wz-0u for ding-account@gmane.org; Wed, 27 Feb 2008 03:36:30 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1JUC8M-0003kD-7r; Tue, 26 Feb 2008 20:35:02 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1JUC8J-0003jw-60 for ding@lists.math.uh.edu; Tue, 26 Feb 2008 20:34:59 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1JUC8C-00055D-Jy for ding@lists.math.uh.edu; Tue, 26 Feb 2008 20:34:59 -0600 Original-Received: from orlando.hostforweb.net ([216.246.45.90]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1JUC8H-0005si-00 for ; Wed, 27 Feb 2008 03:34:57 +0100 Original-Received: from [66.225.201.151] (port=41987 helo=mail.jpl.org) by orlando.hostforweb.net with esmtpa (Exim 4.68) (envelope-from ) id 1JUC7U-0004SB-6T; Tue, 26 Feb 2008 20:34:09 -0600 X-Hashcash: 1:20:080227:de_bb@arcor.de::OT+sQqq5ZnwN7hx1:0002IjS X-Hashcash: 1:20:080227:ding@gnus.org::24b0bTs8qyxiA44J:00002iQ1 X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:v7MqH5FjXLgQfS78h8hmjjk1w1s= X-Antivirus-Scanner: Clean mail though you should still use an Antivirus X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - orlando.hostforweb.net X-AntiAbuse: Original Domain - gnus.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -2.5 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:66359 Archived-At: --=-=-= >>>>> Reiner Steib wrote: > Thanks. I added the version 0.5 from the emacswiki now. Sorry for > the delay. Sorry for finding fault with it. But many warnings are issued when compiling. Most of them look harmless, however the ones concerning `nnmairix-request-group-with-article-number-correction' seem to be real problems. A patch is attached below, though I'm not sure of it. I would appreciate reviewing it. Regards, In toplevel form: nnmairix.el:340:7:Warning: assignment to free variable `nnmairix-group-regexp' nnmairix.el:344:7:Warning: assignment to free variable `nnmairix-valid-backends' nnmairix.el:347:7:Warning: assignment to free variable `nnmairix-last-server' nnmairix.el:350:7:Warning: assignment to free variable `nnmairix-current-server' In nnmairix-open-server: nnmairix.el:360:9:Warning: assignment to free variable `nnmairix-current-server' In nnmairix-request-list: nnmairix.el:521:37:Warning: reference to free variable `nnmairix-group-regexp' In nnmairix-purge-old-groups: nnmairix.el:793:41:Warning: reference to free variable `nnmairix-group-regexp' In nnmairix-request-group-with-article-number-correction: nnmairix.el:977:53:Warning: reference to free variable `fast' nnmairix.el:1009:68:Warning: reference to free variable `group' In nnmairix-get-server: nnmairix.el:1056:52:Warning: reference to free variable `nnmairix-last-server' nnmairix.el:1058:11:Warning: assignment to free variable `nnmairix-last-server' In nnmairix-get-valid-servers: nnmairix.el:1107:40:Warning: reference to free variable `nnmairix-valid-backends' In nnmairix-update-and-clear-marks: nnmairix.el:1262:31:Warning: reference to free variable `nnmairix-group-regexp' In end of data: nnmairix.el:1549:1:Warning: the function `gnus-registry-fetch-group' is not known to be defined. Wrote gnus/lisp/nnmairix.elc --=-=-= Content-Type: text/x-patch Content-Disposition: attachment --- nnmairix.el~ 2008-02-26 21:42:09 +0000 +++ nnmairix.el 2008-02-27 02:32:03 +0000 @@ -336,18 +336,19 @@ ;;; === Internal variables -;; Regexp for mairix groups on back end -(setq nnmairix-group-regexp (format "%s-\\(.*\\)-[0-9]+" nnmairix-group-prefix)) +(defvar nnmairix-group-regexp + (format "%s-\\(.*\\)-[0-9]+" nnmairix-group-prefix) + "Regexp for mairix groups on back end.") + +(defvar nnmairix-valid-backends '(nnimap nnml nnmaildir) + "Back ends (hopefully...) supported by nnmairix. +Other backends might or might not work.") -;; Back ends (hopefully...) supported by nnmairix. -;; Other backends might or might not work. -(setq nnmairix-valid-backends '(nnimap nnml nnmaildir)) +(defvar nnmairix-last-server nil + "Last chosen server.") -;; Last chosen server -(setq nnmairix-last-server nil) - -;; Current server -(setq nnmairix-current-server nil) +(defvar nnmairix-current-server nil + "Current server.") ;;; === Gnus backend functions @@ -843,6 +844,9 @@ (set-process-sentinel (apply 'start-process args) 'nnmairix-sentinel-mairix-update-finished)))))) +(eval-and-compile + (autoload 'gnus-registry-fetch-group "gnus-registry")) + (defun nnmairix-goto-original-article (&optional no-registry) "Jump to the original group and display article. The original group of the article is first determined with the @@ -974,7 +978,7 @@ "Request FOLDER on backend for nnmairix QUALGROUP and article number correction." (save-excursion (nnmairix-call-backend - "request-group" folder nnmairix-backend-server fast) + "request-group" folder nnmairix-backend-server) (set-buffer nnmairix-mairix-output-buffer) (goto-char (point-min)) (re-search-forward "^Matched.*messages") @@ -1006,7 +1010,7 @@ (gnus-group-set-parameter qualgroup 'numcorr (list nil 0 high)))) (erase-buffer) - (insert (format "%d %d %d %d %s" status total low high group)) + (insert (format "%d %d %d %d %s" status total low high qualgroup)) t) (progn (nnheader-report --=-=-=--