[PATCH] workaround non ascii chars in rfc2231

[PATCH] workaround non ascii chars in rfc2231

[Pixel]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

hi,

i've received a mail having: "Content-Disposition: attachment; filename=fêtesxxxxxx.pdf",
and so that part was considered text/plain.

with the following patch, it works. It's quite simple: since
forward-sexp stop at first 8-bit char, i simply retry.

a better (??) patch would be to modify the syntax table?

i attach a simple mail containing the pb

cu


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-workaround-non-ascii-chars-in-rfc2231.patch --]
[-- Type: text/x-patch, Size: 783 bytes --]

Index: lisp/rfc2231.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/rfc2231.el,v
retrieving revision 7.6
diff -u -r7.6 rfc2231.el
--- lisp/rfc2231.el	28 Jul 2005 02:05:21 -0000	7.6
+++ lisp/rfc2231.el	22 Nov 2005 11:41:09 -0000
@@ -127,7 +127,13 @@
 		       (> c ?\177)) ;; EXTENSION: Support non-ascii chars.
 		   (not (memq c stoken)))
 	      (setq value (buffer-substring
-			   (point) (progn (forward-sexp) (point)))))
+			   (point) 
+			   (progn (forward-sexp) 
+				  ;; EXTENSION: Support non-ascii chars.
+				  (while (and (not (eobp))
+					      (> (char-after) ?\177))
+				    (forward-char 1) (forward-sexp))
+				  (point)))))
 	     (t
 	      (error "Invalid header: %s" string)))
 	    (if number

[-- Attachment #3: zz --]
[-- Type: application/octet-stream, Size: 2688 bytes --]

Re: [PATCH] workaround non ascii chars in rfc2231

[Katsumi Yamaoka]

>>>>> In <lymzjw6bnr.fsf@leia.mandriva.com> Pixel wrote:

> i've received a mail having:
> "Content-Disposition: attachment; filename=fêtesxxxxxx.pdf",
> and so that part was considered text/plain.

> with the following patch, it works. It's quite simple: since
> forward-sexp stop at first 8-bit char, i simply retry.

Confirmed.  I've applied your patch to the trunk and the v5-10
branch.  Thanks.

> a better (??) patch would be to modify the syntax table?

I don't know, but I'm reluctant to support such broken mails
further.

Re: [PATCH] workaround non ascii chars in rfc2231

[Reiner Steib]

On Thu, Nov 24 2005, Katsumi Yamaoka wrote:

>>>>>> In <lymzjw6bnr.fsf@leia.mandriva.com> Pixel wrote:
>
>> i've received a mail having:
>> "Content-Disposition: attachment; filename=fêtesxxxxxx.pdf",
>> and so that part was considered text/plain.
>
>> with the following patch, it works. It's quite simple: since
>> forward-sexp stop at first 8-bit char, i simply retry.
>
> Confirmed.  I've applied your patch to the trunk and the v5-10
> branch.  Thanks.

We should have a real name instead of "Pixel" in the ChangeLog (even
if it a tiny patch):

,----
| +2005-11-24  Pixel  <pixel@mandriva.com>  (tiny change)
| +
| +	* rfc2231.el (rfc2231-parse-string): Support non-ascii chars.
| +
`----

> I don't know, but I'm reluctant to support such broken mails
> further.

If it is incorrect, we should probably add a more appropriate comment
instead of "EXTENSION: Support non-ascii chars.".

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: [PATCH] workaround non ascii chars in rfc2231

[Pascal (Pixel) Rigaux]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> We should have a real name instead of "Pixel" in the ChangeLog (even
> if it a tiny patch):
>
> ,----
> | +2005-11-24  Pixel  <pixel@mandriva.com>  (tiny change)
> | +
> | +	* rfc2231.el (rfc2231-parse-string): Support non-ascii chars.

a more "real" name could be Pascal Rigaux <pixel@mandriva.com> :)

cu

Re: [PATCH] workaround non ascii chars in rfc2231

[Katsumi Yamaoka]

>>>>> In <ly64qhkb3g.fsf@leia.mandriva.com> Pascal (Pixel) Rigaux wrote:

> a more "real" name could be Pascal Rigaux <pixel@mandriva.com> :)

Fixed.

>>>>> In <v9oe494xef.fsf@marauder.physik.uni-ulm.de> Reiner Steib wrote:

> If it is incorrect, we should probably add a more appropriate comment
> instead of "EXTENSION: Support non-ascii chars.".

Done.