From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/83980 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: gnus-uu bug? Date: Wed, 18 Dec 2013 16:46:39 +0900 Organization: Emacsen advocacy group Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1387352892 15943 80.91.229.3 (18 Dec 2013 07:48:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Dec 2013 07:48:12 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M32232@lists.math.uh.edu Wed Dec 18 08:48:18 2013 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VtBrd-0004OF-Gs for ding-account@gmane.org; Wed, 18 Dec 2013 08:48:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1VtBqS-0000lL-MP; Wed, 18 Dec 2013 01:47:04 -0600 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1VtBqH-0000kw-N0 for ding@lists.math.uh.edu; Wed, 18 Dec 2013 01:46:53 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtps (TLSv1:AES128-SHA:128) (Exim 4.76) (envelope-from ) id 1VtBqF-0004zO-Ll for ding@lists.math.uh.edu; Wed, 18 Dec 2013 01:46:52 -0600 Original-Received: from mail-hampton.hostforweb.net ([216.246.15.223] helo=hampton.hostforweb.net) by quimby.gnus.org with esmtp (Exim 4.80) (envelope-from ) id 1VtBqD-0000GY-K5 for ding@gnus.org; Wed, 18 Dec 2013 08:46:49 +0100 Original-Received: from localhost.localdomain ([127.0.0.1]:34502 helo=localhost) by hampton.hostforweb.net with smtp (Exim 4.80.1) (envelope-from ) id 1VtBq5-0008CH-Ku for ding@gnus.org; Wed, 18 Dec 2013 01:46:42 -0600 X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130008 (=?iso-2022-jp?B?GyRCPz8bKEI=?= Gnus v0.8) Emacs/24.3.50 (i686-pc-cygwin) Cancel-Lock: sha1:g0RvEscJ4kR7OPyeCVPW6mPQVTs= X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - gnus.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: acl_c_authenticated_local_user: yamaoka X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -1.9 (-) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:83980 Archived-At: --=-=-= Hi, I came across many forwardxxxxxxx files left in the TMP directory. Where xxxxxxx is a unique alphanumeric characters and TMP is a directory that the user option `gnus-uu-tmp-dir' specifies, and those files are all empty. They should have been deleted, shouldn't they? I looked into the code and realized that such a file was created when I forwarded two or more articles in a single message. Whereas other gnus-uu files are created in the `gnus-uu-work-dir' directory, and are deleted when exiting a group. In relation to this, `gnus-uu-decode-binhex' and `gnus-uu-decode-binhex-view' seem to try to run without initializing `gnus-uu-work-dir'. I have no binhex data, so I haven't fully tested them, though. May I commit this patch? 2013-12-18 Katsumi Yamaoka * gnus-uu.el (gnus-uu-decode-binhex, gnus-uu-decode-binhex-view): Make sure work directory exists. (gnus-uu-digest-mail-forward): Store temporary files in work directory rather than tmp directory. --=-=-= Content-Type: text/x-patch Content-Disposition: inline --- gnus-uu.el~ 2013-08-01 22:11:47.000000000 +0000 +++ gnus-uu.el 2013-12-18 07:43:09.961186100 +0000 @@ -406,6 +406,7 @@ (read-directory-name "Unbinhex and save in dir: " gnus-uu-default-dir gnus-uu-default-dir)))) + (gnus-uu-initialize) (setq gnus-uu-binhex-article-name (mm-make-temp-file (expand-file-name "binhex" gnus-uu-work-dir))) (gnus-uu-decode-with-method 'gnus-uu-binhex-article n dir)) @@ -471,6 +472,7 @@ (list current-prefix-arg (read-file-name "Unbinhex, view and save in dir: " gnus-uu-default-dir gnus-uu-default-dir))) + (gnus-uu-initialize) (setq gnus-uu-binhex-article-name (mm-make-temp-file (expand-file-name "binhex" gnus-uu-work-dir))) (let ((gnus-view-pseudos (or gnus-view-pseudos 'automatic))) @@ -482,8 +484,9 @@ (defun gnus-uu-digest-mail-forward (&optional n post) "Digests and forwards all articles in this series." (interactive "P") + (gnus-uu-initialize) (let ((gnus-uu-save-in-digest t) - (file (mm-make-temp-file (nnheader-concat gnus-uu-tmp-dir "forward"))) + (file (mm-make-temp-file (nnheader-concat gnus-uu-work-dir "forward"))) (message-forward-as-mime message-forward-as-mime) (mail-parse-charset gnus-newsgroup-charset) (mail-parse-ignored-charsets gnus-newsgroup-ignored-charsets) --=-=-=--