Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: phillip.lord@newcastle.ac.uk
Cc: ding@gnus.org, bugs@gnus.org
Subject: Re: bug in recent version of nnml.el
Date: Fri, 03 Oct 2008 10:52:52 +0900	[thread overview]
Message-ID: <b4mod22qwaz.fsf@jpl.org> (raw)
In-Reply-To: <b4mr66ysgjb.fsf@jpl.org>

>>>>> Katsumi Yamaoka wrote:
>>>>>> Katsumi Yamaoka wrote:
>> 2008-10-02  Katsumi Yamaoka  <yamaoka@jpl.org>

>>         * nnml.el (nnml-request-expire-articles): Expand nnmail-expiry-target
>>         to an actual expiry target first if it is a function.  Suggested by
>>         Phillip Lord <phillip.lord@newcastle.ac.uk>.

>>         * nnfolder.el (nnfolder-request-expire-articles): Ditto.

> I've reverted those changes.  Sorry.  I realized it causes another
> error if `nnmail-expiry-target' is the symbol `delete' that is
> the default.  It is not only a symbol but also a function symbol.
> I'll look for another solution...

Fixed in the Gnus CVS trunk.  The change I made in nnml.el is as
follows.  Note that the function set to `nnmail-expiry-target'
should be executed in a buffer in which there is an article to
be examined by the function (your function might not care article
contents, though).

--8<---------------cut here---------------start------------->8---
--- nnml.el~	2008-06-11 21:40:59 +0000
+++ nnml.el	2008-10-03 01:26:37 +0000
@@ -364,11 +364,11 @@
 		      nnml-article-file-alist)
 		  (when (functionp target)
 		    (setq target (funcall target group)))
-		  (if (and target
-			   (or (gnus-request-group target)
-			       (gnus-request-create-group target)))
-		      (nnmail-expiry-target-group target group)
-		    (setq target nil))))
+		  (when (and target (not (eq target 'delete)))
+		    (if (or (gnus-request-group target)
+			    (gnus-request-create-group target))
+			(nnmail-expiry-target-group target group)
+		      (setq target nil)))))
 	      ;; Maybe directory is changed during nnmail-expiry-target-group.
 	      (nnml-possibly-change-directory group server))
 	    (if target
--8<---------------cut here---------------end--------------->8---

Regards,



  reply	other threads:[~2008-10-03  1:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <EMEW-k91AyF906d078456474eb10da550f3b4fb26ec-87od23724d.fsf@dinley.ncl.ac.uk>
2008-10-02 23:35 ` Katsumi Yamaoka
2008-10-02 23:50   ` Katsumi Yamaoka
2008-10-03  1:52     ` Katsumi Yamaoka [this message]
     [not found] ` <EMEW-k920Zffc12dea83ee2ef6b314c1d218e22b9e9-b4m8wt6vadb.fsf@jpl.org>
2008-10-03  9:52   ` Phillip Lord
2008-10-03 10:21     ` Katsumi Yamaoka
2008-10-03 14:48       ` Reiner Steib
     [not found]       ` <EMEW-k92Fmm5706e6efbf06ac13a4733671cc4e7a7c-87y715enuf.fsf@marauder.physik.uni-ulm.de>
2008-10-03 15:54         ` Phillip Lord
     [not found]     ` <EMEW-k92BM1c131f9b8dc92f8fae9342efde519d3d5-b4mwsgqhtc0.fsf@jpl.org>
2008-10-03 15:53       ` Phillip Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4mod22qwaz.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=bugs@gnus.org \
    --cc=ding@gnus.org \
    --cc=phillip.lord@newcastle.ac.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).