From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/67515 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: Re: bug in recent version of nnml.el Date: Fri, 03 Oct 2008 10:52:52 +0900 Organization: Emacsen advocacy group Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1222998870 4781 80.91.229.12 (3 Oct 2008 01:54:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 3 Oct 2008 01:54:30 +0000 (UTC) Cc: ding@gnus.org, bugs@gnus.org To: phillip.lord@newcastle.ac.uk Original-X-From: ding-owner+M15966@lists.math.uh.edu Fri Oct 03 03:55:28 2008 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1KlZt9-0006BA-NJ for ding-account@gmane.org; Fri, 03 Oct 2008 03:55:28 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1KlZrV-0007qP-Hv; Thu, 02 Oct 2008 20:53:45 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1KlZrU-0007qB-7m for ding@lists.math.uh.edu; Thu, 02 Oct 2008 20:53:44 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.69) (envelope-from ) id 1KlZrR-0003Uc-1Z for ding@lists.math.uh.edu; Thu, 02 Oct 2008 20:53:44 -0500 Original-Received: from orlando.hostforweb.net ([216.246.45.90]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1KlZrW-0002fX-00; Fri, 03 Oct 2008 03:53:46 +0200 Original-Received: from localhost ([127.0.0.1]:41818) by orlando.hostforweb.net with esmtpa (Exim 4.69) (envelope-from ) id 1KlZqq-0003UV-Jd; Thu, 02 Oct 2008 20:53:05 -0500 X-Hashcash: 1:20:081003:phillip.lord@newcastle.ac.uk::tzuSjKfDdFbG/Ryy:0000000000000000000000000000000002i8R X-Hashcash: 1:20:081003:ding@gnus.org::r/AA8nbp/fQPIfvJ:00003vXo X-Hashcash: 1:20:081003:bugs@gnus.org::GS+zCxp6dhM2OAou:00003NbQ X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:2y3MOUr6IYQ8xwDjgIqNKPDAy4g= X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - orlando.hostforweb.net X-AntiAbuse: Original Domain - gnus.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:67515 Archived-At: >>>>> Katsumi Yamaoka wrote: >>>>>> Katsumi Yamaoka wrote: >> 2008-10-02 Katsumi Yamaoka >> * nnml.el (nnml-request-expire-articles): Expand nnmail-expiry-target >> to an actual expiry target first if it is a function. Suggested by >> Phillip Lord . >> * nnfolder.el (nnfolder-request-expire-articles): Ditto. > I've reverted those changes. Sorry. I realized it causes another > error if `nnmail-expiry-target' is the symbol `delete' that is > the default. It is not only a symbol but also a function symbol. > I'll look for another solution... Fixed in the Gnus CVS trunk. The change I made in nnml.el is as follows. Note that the function set to `nnmail-expiry-target' should be executed in a buffer in which there is an article to be examined by the function (your function might not care article contents, though). --8<---------------cut here---------------start------------->8--- --- nnml.el~ 2008-06-11 21:40:59 +0000 +++ nnml.el 2008-10-03 01:26:37 +0000 @@ -364,11 +364,11 @@ nnml-article-file-alist) (when (functionp target) (setq target (funcall target group))) - (if (and target - (or (gnus-request-group target) - (gnus-request-create-group target))) - (nnmail-expiry-target-group target group) - (setq target nil)))) + (when (and target (not (eq target 'delete))) + (if (or (gnus-request-group target) + (gnus-request-create-group target)) + (nnmail-expiry-target-group target group) + (setq target nil))))) ;; Maybe directory is changed during nnmail-expiry-target-group. (nnml-possibly-change-directory group server)) (if target --8<---------------cut here---------------end--------------->8--- Regards,