* browse-url-url-encode-chars,
[not found] <E1OyQQw-0000mC-00@quimby.gnus.org>
@ 2010-09-23 1:46 ` Katsumi Yamaoka
2010-09-23 8:19 ` browse-url-url-encode-chars, Robert Pluim
2010-09-23 15:58 ` browse-url-url-encode-chars, Lars Magne Ingebrigtsen
0 siblings, 2 replies; 9+ messages in thread
From: Katsumi Yamaoka @ 2010-09-23 1:46 UTC (permalink / raw)
To: ding
Julien Danjou <julien@danjou.info> wrote:
> commit aa7ce8bb58e3ab3881192ab7864bf430ca07c21d
> Author: Julien Danjou <julien@danjou.info>
> Date: Wed Sep 22 15:40:49 2010 +0200
[...]
> +(defun gnus-html-encode-url (url)
> + "Encode URL."
> + (browse-url-url-encode-chars url "[)$ ]"))
Julien Danjou <julien@danjou.info> wrote:
> commit 55ffb35736a85abc8c91df2498074e70461ef502
> Author: Julien Danjou <julien@danjou.info>
> Date: Wed Sep 22 18:22:19 2010 +0200
[...]
> - (edges (window-pixel-edges (get-buffer-window (current-buffer))))
> + (edges (window-inside-pixel-edges (get-buffer-window (current-buffer))))
`browse-url-url-encode-chars' is not available in Emacs 22 and
XEmacs. `window-inside-pixel-edges' is not available in XEmacs.
Maybe it's easy to implement `gnus-browse-url-url-encode-chars',
however the latter doesn't seem to be. Any idea?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: browse-url-url-encode-chars,
2010-09-23 1:46 ` browse-url-url-encode-chars, Katsumi Yamaoka
@ 2010-09-23 8:19 ` Robert Pluim
2010-09-23 15:58 ` browse-url-url-encode-chars, Lars Magne Ingebrigtsen
1 sibling, 0 replies; 9+ messages in thread
From: Robert Pluim @ 2010-09-23 8:19 UTC (permalink / raw)
To: ding
Katsumi Yamaoka <yamaoka@jpl.org> writes:
> Julien Danjou <julien@danjou.info> wrote:
>> commit aa7ce8bb58e3ab3881192ab7864bf430ca07c21d
>> Author: Julien Danjou <julien@danjou.info>
>> Date: Wed Sep 22 15:40:49 2010 +0200
> [...]
>> +(defun gnus-html-encode-url (url)
>> + "Encode URL."
>> + (browse-url-url-encode-chars url "[)$ ]"))
>
> Julien Danjou <julien@danjou.info> wrote:
>> commit 55ffb35736a85abc8c91df2498074e70461ef502
>> Author: Julien Danjou <julien@danjou.info>
>> Date: Wed Sep 22 18:22:19 2010 +0200
> [...]
>> - (edges (window-pixel-edges (get-buffer-window (current-buffer))))
>> + (edges (window-inside-pixel-edges (get-buffer-window (current-buffer))))
>
> `browse-url-url-encode-chars' is not available in Emacs 22 and
> XEmacs. `window-inside-pixel-edges' is not available in XEmacs.
>
> Maybe it's easy to implement `gnus-browse-url-url-encode-chars',
> however the latter doesn't seem to be. Any idea?
Hmm, there's
`window-text-area-pixel-edges' is a built-in function
-- loaded from "/build/xemacs-edge/src/window.c"
(window-text-area-pixel-edges &optional WINDOW)
Documentation:
Return a list of the pixel edge coordinates of the text area of WINDOW.
The returned list is of the form (LEFT TOP RIGHT BOTTOM),
all relative to 0, 0 at the top left corner of the total area allocated
to the window, which includes the scrollbars.
but I'm not 100% that does exactly what you want.
Robert
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: browse-url-url-encode-chars,
2010-09-23 1:46 ` browse-url-url-encode-chars, Katsumi Yamaoka
2010-09-23 8:19 ` browse-url-url-encode-chars, Robert Pluim
@ 2010-09-23 15:58 ` Lars Magne Ingebrigtsen
2010-09-23 17:40 ` browse-url-url-encode-chars, Julien Danjou
1 sibling, 1 reply; 9+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-09-23 15:58 UTC (permalink / raw)
To: ding
Katsumi Yamaoka <yamaoka@jpl.org> writes:
>> - (edges (window-pixel-edges (get-buffer-window (current-buffer))))
>> + (edges (window-inside-pixel-edges (get-buffer-window (current-buffer)
[...]
> Maybe it's easy to implement `gnus-browse-url-url-encode-chars',
> however the latter doesn't seem to be. Any idea?
While `window-inside-pixel-edges' gives a more accurate number for our
purposes, I think `window-pixel-edges' is sufficient. I mean, we only
need a rough ballpark number, don't we?
Julien, perhaps this should be changed back, unless there are any other
effects I'm not aware of?
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: browse-url-url-encode-chars,
2010-09-23 15:58 ` browse-url-url-encode-chars, Lars Magne Ingebrigtsen
@ 2010-09-23 17:40 ` Julien Danjou
2010-09-23 17:45 ` browse-url-url-encode-chars, Lars Magne Ingebrigtsen
0 siblings, 1 reply; 9+ messages in thread
From: Julien Danjou @ 2010-09-23 17:40 UTC (permalink / raw)
To: ding
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On Thu, Sep 23 2010, Lars Magne Ingebrigtsen wrote:
>> Maybe it's easy to implement `gnus-browse-url-url-encode-chars',
>> however the latter doesn't seem to be. Any idea?
>
> While `window-inside-pixel-edges' gives a more accurate number for our
> purposes, I think `window-pixel-edges' is sufficient. I mean, we only
> need a rough ballpark number, don't we?
>
> Julien, perhaps this should be changed back, unless there are any other
> effects I'm not aware of?
I'm neither aware of any other effect. This was just to be more precise,
as you point out.
--
Julien Danjou
// ᐰ <julien@danjou.info> http://julien.danjou.info
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: browse-url-url-encode-chars,
2010-09-23 17:40 ` browse-url-url-encode-chars, Julien Danjou
@ 2010-09-23 17:45 ` Lars Magne Ingebrigtsen
2010-09-23 18:01 ` browse-url-url-encode-chars, Julien Danjou
0 siblings, 1 reply; 9+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-09-23 17:45 UTC (permalink / raw)
To: ding
Julien Danjou <julien@danjou.info> writes:
> I'm neither aware of any other effect. This was just to be more precise,
> as you point out.
Ok, can you change it back so this could work on XEmacs again?
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: browse-url-url-encode-chars,
2010-09-23 17:45 ` browse-url-url-encode-chars, Lars Magne Ingebrigtsen
@ 2010-09-23 18:01 ` Julien Danjou
2010-09-23 23:18 ` browse-url-url-encode-chars, Katsumi Yamaoka
0 siblings, 1 reply; 9+ messages in thread
From: Julien Danjou @ 2010-09-23 18:01 UTC (permalink / raw)
To: ding
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
On Thu, Sep 23 2010, Lars Magne Ingebrigtsen wrote:
> Ok, can you change it back so this could work on XEmacs again?
I've reverted the commit.
--
Julien Danjou
// ᐰ <julien@danjou.info> http://julien.danjou.info
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: browse-url-url-encode-chars,
2010-09-23 18:01 ` browse-url-url-encode-chars, Julien Danjou
@ 2010-09-23 23:18 ` Katsumi Yamaoka
2010-09-24 7:20 ` browse-url-url-encode-chars, Julien Danjou
0 siblings, 1 reply; 9+ messages in thread
From: Katsumi Yamaoka @ 2010-09-23 23:18 UTC (permalink / raw)
To: ding
Julien Danjou wrote:
> On Thu, Sep 23 2010, Lars Magne Ingebrigtsen wrote:
>> Ok, can you change it back so this could work on XEmacs again?
> I've reverted the commit.
Thanks. I'm going to implement gnus-browse-url-url-encode-chars
(or gnus-url-url-encode-chars?).
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: browse-url-url-encode-chars,
2010-09-23 23:18 ` browse-url-url-encode-chars, Katsumi Yamaoka
@ 2010-09-24 7:20 ` Julien Danjou
2010-09-24 7:27 ` browse-url-url-encode-chars, Katsumi Yamaoka
0 siblings, 1 reply; 9+ messages in thread
From: Julien Danjou @ 2010-09-24 7:20 UTC (permalink / raw)
To: Katsumi Yamaoka; +Cc: ding
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
On Fri, Sep 24 2010, Katsumi Yamaoka wrote:
> Thanks. I'm going to implement gnus-browse-url-url-encode-chars
> (or gnus-url-url-encode-chars?).
Just saw your commit. Would it be ok to use the same kind of trick to
use window-inside-pixel-edges rather than window-pixel-edges?
--
Julien Danjou
// ᐰ <julien@danjou.info> http://julien.danjou.info
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: browse-url-url-encode-chars,
2010-09-24 7:20 ` browse-url-url-encode-chars, Julien Danjou
@ 2010-09-24 7:27 ` Katsumi Yamaoka
0 siblings, 0 replies; 9+ messages in thread
From: Katsumi Yamaoka @ 2010-09-24 7:27 UTC (permalink / raw)
To: ding
Julien Danjou wrote:
> On Fri, Sep 24 2010, Katsumi Yamaoka wrote:
>> Thanks. I'm going to implement gnus-browse-url-url-encode-chars
>> (or gnus-url-url-encode-chars?).
> Just saw your commit. Would it be ok to use the same kind of trick to
> use window-inside-pixel-edges rather than window-pixel-edges?
Oh, I think that's ok. Please go ahead.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2010-09-24 7:27 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1OyQQw-0000mC-00@quimby.gnus.org>
2010-09-23 1:46 ` browse-url-url-encode-chars, Katsumi Yamaoka
2010-09-23 8:19 ` browse-url-url-encode-chars, Robert Pluim
2010-09-23 15:58 ` browse-url-url-encode-chars, Lars Magne Ingebrigtsen
2010-09-23 17:40 ` browse-url-url-encode-chars, Julien Danjou
2010-09-23 17:45 ` browse-url-url-encode-chars, Lars Magne Ingebrigtsen
2010-09-23 18:01 ` browse-url-url-encode-chars, Julien Danjou
2010-09-23 23:18 ` browse-url-url-encode-chars, Katsumi Yamaoka
2010-09-24 7:20 ` browse-url-url-encode-chars, Julien Danjou
2010-09-24 7:27 ` browse-url-url-encode-chars, Katsumi Yamaoka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).