From: Katsumi Yamaoka <yamaoka@jpl.org>
To: Glenn Morris <rgm@gnu.org>
Cc: ding@gnus.org, emacs-devel@gnu.org
Subject: Recent change in gnus-sum.el is bad for XEmacs
Date: Fri, 09 Jan 2009 19:38:14 +0900 [thread overview]
Message-ID: <b4mpriwhii1.fsf_-_@jpl.org> (raw)
In-Reply-To: <E1LL8wp-0008K2-4d@cvs.savannah.gnu.org>
>>>>> In <E1LL8wp-0008K2-4d@cvs.savannah.gnu.org> Glenn Morris wrote:
> CVSROOT: /sources/emacs
> Module name: emacs
> Changes by: Glenn Morris <gm> 09/01/09 04:26:14
> Modified files:
> lisp/gnus : ChangeLog gnus-sum.el
[...]
> +2009-01-09 Glenn Morris <rgm@gnu.org>
> +
> + * gnus-sum.el (gnus-summary-next-article): Replace last-command-char
> + with last-command-event.
> +
[...]
> --- gnus-sum.el 9 Jan 2009 03:01:52 -0000 1.137
> +++ gnus-sum.el 9 Jan 2009 04:26:14 -0000 1.138
> @@ -7625,7 +7625,7 @@
> (t
> (unless (gnus-ephemeral-group-p gnus-newsgroup-name)
> (gnus-summary-jump-to-group gnus-newsgroup-name))
> - (let ((cmd last-command-char)
> + (let ((cmd last-command-event)
> (point
> (with-current-buffer gnus-group-buffer
> (point)))
This change will be merged to the Gnus trunk sooner or later and
then XEmacs will get not to work (I verified). When typing the
SPC key, `last-command-event' will be `10' in Emacs, whereas it
will be the Lisp object `#<keypress-event space>' in XEmacs.
Because of this the form `(equal key cmd)' used in the function
`gnus-summary-walk-group-buffer' will never return t. I have a
solution as follows:
--8<---------------cut here---------------start------------->8---
--- gnus-sum.el~ 2009-01-06 21:59:24 +0000
+++ gnus-sum.el 2009-01-09 10:35:57 +0000
@@ -7696,7 +7696,9 @@
(setq group (gnus-group-group-name))
(switch-to-buffer obuf))
(setq ended nil))
- ((equal key cmd)
+ ((equal key (if (featurep 'xemacs)
+ (event-to-character cmd)
+ cmd))
(if (or (not group)
(gnus-ephemeral-group-p gnus-newsgroup-name))
(gnus-summary-exit)
--8<---------------cut here---------------end--------------->8---
However, I'm not sure it's ok in all cases. Couldn't the change
revert?
Regards,
next parent reply other threads:[~2009-01-09 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1LL8wp-0008K2-4d@cvs.savannah.gnu.org>
2009-01-09 10:38 ` Katsumi Yamaoka [this message]
2009-01-09 11:13 ` Katsumi Yamaoka
2009-01-09 17:03 ` Glenn Morris
2009-01-10 0:31 ` Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4mpriwhii1.fsf_-_@jpl.org \
--to=yamaoka@jpl.org \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).