From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/68110 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Recent change in gnus-sum.el is bad for XEmacs Date: Fri, 09 Jan 2009 19:38:14 +0900 Organization: Emacsen advocacy group Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1231497609 15868 80.91.229.12 (9 Jan 2009 10:40:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 9 Jan 2009 10:40:09 +0000 (UTC) Cc: ding@gnus.org, emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 09 11:41:20 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LLEnj-0000BX-L4 for ged-emacs-devel@m.gmane.org; Fri, 09 Jan 2009 11:41:15 +0100 Original-Received: from localhost ([127.0.0.1]:44634 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LLEmT-0003aA-Ng for ged-emacs-devel@m.gmane.org; Fri, 09 Jan 2009 05:39:57 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LLElA-00037u-VD for emacs-devel@gnu.org; Fri, 09 Jan 2009 05:38:37 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LLEl9-00037G-12 for emacs-devel@gnu.org; Fri, 09 Jan 2009 05:38:36 -0500 Original-Received: from [199.232.76.173] (port=51471 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LLEl8-000377-Li for emacs-devel@gnu.org; Fri, 09 Jan 2009 05:38:34 -0500 Original-Received: from orlando.hostforweb.net ([216.246.45.90]:34895) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LLEl4-0003He-Gg; Fri, 09 Jan 2009 05:38:30 -0500 Original-Received: from localhost ([127.0.0.1]:43423) by orlando.hostforweb.net with esmtpa (Exim 4.69) (envelope-from ) id 1LLEku-0001Ay-LH; Fri, 09 Jan 2009 04:38:21 -0600 X-Hashcash: 1:20:090109:rgm@gnu.org::jfL4ni8rcknZF43m:000000700N X-Hashcash: 1:20:090109:emacs-devel@gnu.org::Op4N5rJviFRwnl7D:0000000000000000000000000000000000000000005dxh X-Hashcash: 1:20:090109:ding@gnus.org::ZzSgd0p6PHl1klwE:00003PRb X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:/xuEXlHz+pdttqBEhVrtvA0Evcc= X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - orlando.hostforweb.net X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:107720 gmane.emacs.gnus.general:68110 Archived-At: >>>>> In Glenn Morris wrote: > CVSROOT: /sources/emacs > Module name: emacs > Changes by: Glenn Morris 09/01/09 04:26:14 > Modified files: > lisp/gnus : ChangeLog gnus-sum.el [...] > +2009-01-09 Glenn Morris > + > + * gnus-sum.el (gnus-summary-next-article): Replace last-command-char > + with last-command-event. > + [...] > --- gnus-sum.el 9 Jan 2009 03:01:52 -0000 1.137 > +++ gnus-sum.el 9 Jan 2009 04:26:14 -0000 1.138 > @@ -7625,7 +7625,7 @@ > (t > (unless (gnus-ephemeral-group-p gnus-newsgroup-name) > (gnus-summary-jump-to-group gnus-newsgroup-name)) > - (let ((cmd last-command-char) > + (let ((cmd last-command-event) > (point > (with-current-buffer gnus-group-buffer > (point))) This change will be merged to the Gnus trunk sooner or later and then XEmacs will get not to work (I verified). When typing the SPC key, `last-command-event' will be `10' in Emacs, whereas it will be the Lisp object `#' in XEmacs. Because of this the form `(equal key cmd)' used in the function `gnus-summary-walk-group-buffer' will never return t. I have a solution as follows: --8<---------------cut here---------------start------------->8--- --- gnus-sum.el~ 2009-01-06 21:59:24 +0000 +++ gnus-sum.el 2009-01-09 10:35:57 +0000 @@ -7696,7 +7696,9 @@ (setq group (gnus-group-group-name)) (switch-to-buffer obuf)) (setq ended nil)) - ((equal key cmd) + ((equal key (if (featurep 'xemacs) + (event-to-character cmd) + cmd)) (if (or (not group) (gnus-ephemeral-group-p gnus-newsgroup-name)) (gnus-summary-exit) --8<---------------cut here---------------end--------------->8--- However, I'm not sure it's ok in all cases. Couldn't the change revert? Regards,