From: Katsumi Yamaoka <yamaoka@jpl.org>
To: ding@gnus.org
Subject: gnus-agent-expire-group-1 bug?
Date: Mon, 22 Oct 2007 18:57:16 +0900 [thread overview]
Message-ID: <b4mprz7eakj.fsf@jpl.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 354 bytes --]
Hi,
The following section (prefixed with `-') in the function
`gnus-agent-expire-group-1' seems to do nothing, though I'm not
sure what it is for. There's no `catch' for `sort-results', and
the `when' always gets nil.
(I found this while trying replacing `mapcar' with `mapc' or
`dolist'.
cf. http://article.gmane.org/gmane.emacs.gnus.general/65429)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 942 bytes --]
--- gnus-agent.el~ 2007-10-04 21:53:35 +0000
+++ gnus-agent.el 2007-10-22 09:55:41 +0000
@@ -3329,27 +3329,6 @@
(setcdr dlist (cddr dlist)))
(setq dlist (cdr dlist)))))
-
- ;; Check the order of the entry positions. They should be in
- ;; ascending order. If they aren't, the positions must be
- ;; converted to markers.
- (when (let ((dlist dlist)
- (prev-pos -1)
- pos)
- (while dlist
- (if (setq pos (nth 3 (pop dlist)))
- (if (< pos prev-pos)
- (throw 'sort-results 'unsorted)
- (setq prev-pos pos)))))
- (gnus-message 7 "gnus-agent-expire: Unsorted overview; inserting markers to compensate.")
- (mapcar (lambda (entry)
- (let ((pos (nth 3 entry)))
- (if pos
- (setf (nth 3 entry)
- (set-marker (make-marker)
- pos)))))
- dlist))
-
(gnus-message 7 "gnus-agent-expire: Merging entries... Done")
(let* ((len (float (length dlist)))
next reply other threads:[~2007-10-22 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 9:57 Katsumi Yamaoka [this message]
2007-10-22 18:54 ` Reiner Steib
2007-10-23 5:02 ` Kevin Greiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4mprz7eakj.fsf@jpl.org \
--to=yamaoka@jpl.org \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).