Re: Sticky article buffers

[Katsumi Yamaoka <yamaoka@jpl.org>]

[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]

Hi,

Thank you for contributing a good feature.  I tried it today and
realized it is really useful.  Though I have no plan for the moment,
people might want a browser function for many sticky articles. :)

Please let me write about a few problems in `gnus-sticky-article'.

1. (gnus-configure-windows 'article) makes an empty article
   buffer and leads creating of an empty sticky article if there
   is no article buffer initially, but is not necessary because
   `gnus-summary-select-article' runs it by way of
   `gnus-summary-display-article' and `gnus-article-prepare'
   after preparing an article.

2. It seems to be useless that this command always makes a new
   sticky article buffer.  I mean, performing of the `A S'
   command repeatedly on an article creates "*Sticky Article*",
   "*Sticky Article*<2>", "*Sticky Article*<3>"...

3. The value of the `gnus-article-buffer' variable in the summary
   buffer is not updated when I select another (normal) article.
   Because of this, a non-ASCII article or a QP-encoded article
   is not decoded when I type `P' or `N' in the summary buffer.

4. I wish you to leave the value of the `indent-tabs-mode'
   variable the default if there is no good reason.  Now some
   lines are indented with tabs but others aren't.

I tried improving these problems.  Here are a replacement of the
`gnus-sticky-article' function and a patch for gnus-sum.el:


[-- Attachment #2: gnus-sticky-article --]
[-- Type: application/emacs-lisp, Size: 1468 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: patch for gnus-sum.el --]
[-- Type: text/x-patch, Size: 1067 bytes --]

--- gnus-sum.el~	2007-08-12 22:04:34 +0000
+++ gnus-sum.el	2007-08-14 05:13:43 +0000
@@ -7413,15 +7413,15 @@
 
 (defun gnus-summary-display-article (article &optional all-header)
   "Display ARTICLE in article buffer."
-  (when (gnus-buffer-live-p gnus-article-buffer)
-    (with-current-buffer gnus-article-buffer
-      (mm-enable-multibyte)))
+  (unless (and (gnus-buffer-live-p gnus-article-buffer)
+	       (with-current-buffer gnus-article-buffer
+		 (eq major-mode 'gnus-article-mode)))
+    (gnus-article-setup-buffer))
   (gnus-set-global-variables)
-  (when (gnus-buffer-live-p gnus-article-buffer)
-    (with-current-buffer gnus-article-buffer
-      (setq gnus-article-charset gnus-newsgroup-charset)
-      (setq gnus-article-ignored-charsets gnus-newsgroup-ignored-charsets)
-      (mm-enable-multibyte)))
+  (with-current-buffer gnus-article-buffer
+    (setq gnus-article-charset gnus-newsgroup-charset)
+    (setq gnus-article-ignored-charsets gnus-newsgroup-ignored-charsets)
+    (mm-enable-multibyte))
   (if (null article)
       nil
     (prog1