Gnus picks up mail addresses in body when answering

Gnus picks up mail addresses in body when answering

[Ralf Angeli]

If I answer to the message
<URL:http://mid.gmane.org/f2vqoo$tpn$1%40sea.gmane.org> via mail,
e.g. by typing `S W' when in the newsgroup, Gnus picks up the "To:
bug-auctex@gnu.org" further down in the body of the message and puts it
into the list of recipients.  Is that intentional?  From a user's point
of view I find that undesirable.  This happens with CVS Emacs and CVS
Gnus from about a week ago.

-- 
Ralf

Re: Gnus picks up mail addresses in body when answering

[Katsumi Yamaoka]

>>>>> In <f30lan$in9$1@sea.gmane.org> Ralf Angeli wrote:

> If I answer to the message
> <URL:http://mid.gmane.org/f2vqoo$tpn$1%40sea.gmane.org> via mail,
> e.g. by typing `S W' when in the newsgroup, Gnus picks up the "To:
> bug-auctex@gnu.org" further down in the body of the message and puts it
> into the list of recipients.  Is that intentional?  From a user's point
> of view I find that undesirable.  This happens with CVS Emacs and CVS
> Gnus from about a week ago.

This must be a bug.  Try `S W' with this message.

To: foo@example.com.invalid
Cc: bar@example.com.invalid
--text follows this line--

I've fixed it in both the trunk and the v5-10 branch.  Miles,
could you merge it to the Emacs CVS?

Regards,

Re: Gnus picks up mail addresses in body when answering

[Andreas Seltenreich]

Katsumi Yamaoka writes:

>>>>>> In <f30lan$in9$1@sea.gmane.org> Ralf Angeli wrote:
>
>> If I answer to the message
>> <URL:http://mid.gmane.org/f2vqoo$tpn$1%40sea.gmane.org> via mail,
>> e.g. by typing `S W' when in the newsgroup, Gnus picks up the "To:
>> bug-auctex@gnu.org" further down in the body of the message and puts it
>> into the list of recipients.  Is that intentional?  From a user's point
>> of view I find that undesirable.  This happens with CVS Emacs and CVS
>> Gnus from about a week ago.
>
> This must be a bug.  Try `S W' with this message.

Ack, ISTM message really wants to call message-narrow-to-head here
instead of message-narrow-to-headers-or-head:

--- message.el	9 Apr 2007 23:57:52 -0000	6.392.2.74
+++ message.el	24 May 2007 01:10:08 -0000
@@ -5867,7 +5867,7 @@
   (let (follow-to mct never-mct to cc author mft recipients)
     ;; Find all relevant headers we need.
     (save-restriction
-      (message-narrow-to-headers-or-head)
+      (message-narrow-to-head)
       ;; Gmane renames "To".  Look at "Original-To", too, if it is present in
       ;; message-header-synonyms.
       (setq to (or (message-fetch-field "to")

Should we try to sneak this into Emacs 22?

regards,
andreas

Re: Gnus picks up mail addresses in body when answering

[Andreas Seltenreich]

Katsumi Yamaoka writes:

> To: foo@example.com.invalid
> Cc: bar@example.com.invalid
> --text follows this line--
>
> I've fixed it in both the trunk and the v5-10 branch.  Miles,
> could you merge it to the Emacs CVS?

Oops, somehow my brain stopped parsing your mail after the header of the
sample message, so I wrote the first followup in the impression it
wasn't already fixed.  Sorry for that.

Nevertheless, maybe the alternative fix I came up with is worth
considering instead?  It is more local to the problem and the change
doesn't affect so many callers, so it might be less likely to cause a
regression as a last-minute fix for Emacs 22.

regards,
andreas

Re: Gnus picks up mail addresses in body when answering

[Katsumi Yamaoka]

>>>>> In <87r6p7vx8k.fsf@gate450.dyndns.org>
>>>>>	Andreas Seltenreich wrote:

> Ack, ISTM message really wants to call message-narrow-to-head here
> instead of message-narrow-to-headers-or-head:

> --- message.el	9 Apr 2007 23:57:52 -0000	6.392.2.74
> +++ message.el	24 May 2007 01:10:08 -0000
> @@ -5867,7 +5867,7 @@
>    (let (follow-to mct never-mct to cc author mft recipients)
>      ;; Find all relevant headers we need.
>      (save-restriction
> -      (message-narrow-to-headers-or-head)
> +      (message-narrow-to-head)
>        ;; Gmane renames "To".  Look at "Original-To", too, if it is present in
>        ;; message-header-synonyms.
>        (setq to (or (message-fetch-field "to")

> Should we try to sneak this into Emacs 22?

`message-get-reply-headers' might be used by ones other than Gnus
and it might leave the header separator in the narrowed area but
is harmless since only `message-fetch-field' is performed there.
I can agree supposing no one binds `mail-header-separator' to
the one looking like a header. ;-)

Regards,

Re: Gnus picks up mail addresses in body when answering

[Ralf Angeli]

* Katsumi Yamaoka (2007-05-24) writes:

> I've fixed it in both the trunk and the v5-10 branch.

Great, thanks very much!

-- 
Ralf

Re: Gnus picks up mail addresses in body when answering

[Katsumi Yamaoka]

>>>>> In <f339h3$ubp$1@sea.gmane.org> Ralf Angeli wrote:

> * Katsumi Yamaoka (2007-05-24) writes:

>> I've fixed it in both the trunk and the v5-10 branch.

> Great, thanks very much!

I've modified it again to make it simple.  Sorry.

Re: Gnus picks up mail addresses in body when answering

[Reiner Steib]

On Thu, May 24 2007, Katsumi Yamaoka wrote:

> I've fixed it in both the trunk and the v5-10 branch.  Miles,
> could you merge it to the Emacs CVS?

It is now in the trunk but not in EMACS_22_BASE (release branch).  Is
it safe enough to install it in EMACS_22_BASE as well?

(I'd like to have exactly the same code in the next 5.10.* and in
Emacs 22.1.)

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Gnus picks up mail addresses in body when answering

[Katsumi Yamaoka]

>>>>> In <v9veegj8k9.fsf@marauder.physik.uni-ulm.de>
>>>>>	Reiner Steib wrote:

> On Thu, May 24 2007, Katsumi Yamaoka wrote:

>> I've fixed it in both the trunk and the v5-10 branch.  Miles,
>> could you merge it to the Emacs CVS?

> It is now in the trunk but not in EMACS_22_BASE (release branch).  Is
> it safe enough to install it in EMACS_22_BASE as well?

> (I'd like to have exactly the same code in the next 5.10.* and in
> Emacs 22.1.)

I believe it is safe enough.  Thanks.