mml-insert-tag: insert closing tag

mml-insert-tag: insert closing tag

[Christopher Schmidt]

[-- Attachment #1: Type: text/plain, Size: 115 bytes --]

2013-01-29  Christopher Schmidt  <christopher@ch.ristopher.com>

	* mml.el (mml-insert-part): Insert closing tag.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-diff, Size: 487 bytes --]

--- a/lisp/mml.el
+++ b/lisp/mml.el
@@ -1440,7 +1440,9 @@ TYPE is the MIME type to use."
   ;; when you send the message.
   (or (eq mail-user-agent 'message-user-agent)
       (setq mail-encode-mml t))
-  (mml-insert-tag 'part 'type type 'disposition "inline"))
+  (mml-insert-tag 'part 'type type 'disposition "inline")
+  (save-excursion
+    (mml-insert-tag '/part)))
 
 (declare-function message-subscribed-p "message" ())
 (declare-function message-make-mail-followup-to "message"

[-- Attachment #3: Type: text/plain, Size: 21 bytes --]


        Christopher

Re: mml-insert-tag: insert closing tag

[Katsumi Yamaoka]

Christopher Schmidt wrote:
> 2013-01-29  Christopher Schmidt  <christopher@ch.ristopher.com>
> 	* mml.el (mml-insert-part): Insert closing tag.

I can imagine some users try to start writing under the closing tag.

Re: mml-insert-tag: insert closing tag

[Christopher Schmidt]

Katsumi Yamaoka <yamaoka@jpl.org> writes:
> I can imagine some users try to start writing under the closing tag.

Why?  save-excursion makes sure that point is placed in-between the
tags.

        Christopher

Re: mml-insert-tag: insert closing tag

[Katsumi Yamaoka]

Christopher Schmidt wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>> I can imagine some users try to start writing under the closing tag.

> Why?  save-excursion makes sure that point is placed in-between the
> tags.

Because at least I get used to start writing at the end of a
message buffer whatever exists above, so I'll simply move the
point to the end indiscreetly.  Anyway, Gnus does well in
encoding an unterminated part.  What is necessary in the end of
a part is the buffer's end, or an open tag of the next part, I
believe.

Re: mml-insert-tag: insert closing tag

[Christopher Schmidt]

Katsumi Yamaoka <yamaoka@jpl.org> writes:
> Because at least I get used to start writing at the end of a message
> buffer whatever exists above, so I'll simply move the point to the end
> indiscreetly.  Anyway, Gnus does well in encoding an unterminated
> part.  What is necessary in the end of a part is the buffer's end, or
> an open tag of the next part, I believe.

This will not help if the users wants to put the part inline.  At the
same time, it is not only about Gnus recognising the bounds of the
individual parts - the end tag is an important visual marker for the
user.

I presume we can find a common ground here by adding a new option which
conditions the addition of the end tag.

        Christopher

Re: mml-insert-tag: insert closing tag

[Katsumi Yamaoka]

Christopher Schmidt wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>> Because at least I get used to start writing at the end of a message
>> buffer whatever exists above, so I'll simply move the point to the end
>> indiscreetly.  Anyway, Gnus does well in encoding an unterminated
>> part.  What is necessary in the end of a part is the buffer's end, or
>> an open tag of the next part, I believe.

> This will not help if the users wants to put the part inline.  At the
> same time, it is not only about Gnus recognising the bounds of the
> individual parts - the end tag is an important visual marker for the
> user.

I see.  So, how about putting a closing tag only when it is in
the middle of a message buffer?

> I presume we can find a common ground here by adding a new option which
> conditions the addition of the end tag.

Re: mml-insert-tag: insert closing tag

[Christopher Schmidt]

Katsumi Yamaoka <yamaoka@jpl.org> writes:
> Christopher Schmidt wrote:
>> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>>> Because at least I get used to start writing at the end of a message
>>> buffer whatever exists above, so I'll simply move the point to the
>>> end indiscreetly.  Anyway, Gnus does well in encoding an
>>> unterminated part.  What is necessary in the end of a part is the
>>> buffer's end, or an open tag of the next part, I believe.
>
>> This will not help if the users wants to put the part inline.  At the
>> same time, it is not only about Gnus recognising the bounds of the
>> individual parts - the end tag is an important visual marker for the
>> user.
>
> I see.  So, how about putting a closing tag only when it is in
> the middle of a message buffer?

I don't know.  I guess this is a reasonable default behaviour.  I
(personally) always want an end tag, though.

        Christopher

Re: mml-insert-tag: insert closing tag

[Katsumi Yamaoka]

Christopher Schmidt wrote:
>> I see.  So, how about putting a closing tag only when it is in
>> the middle of a message buffer?

> I don't know.  I guess this is a reasonable default behaviour.  I
> (personally) always want an end tag, though.

Ok, it's a sound argument anyway.  I'm going to install your patch.
Er, if there is a single empty line between the open and the end
tags, doesn't it make a user recall one should start writing there?

Re: mml-insert-tag: insert closing tag

[Christopher Schmidt]

Katsumi Yamaoka <yamaoka@jpl.org> writes:
> Christopher Schmidt wrote:
>>> I see.  So, how about putting a closing tag only when it is in
>>> the middle of a message buffer?
>
>> I don't know.  I guess this is a reasonable default behaviour.  I
>> (personally) always want an end tag, though.
>
> Ok, it's a sound argument anyway.  I'm going to install your patch.
> Er, if there is a single empty line between the open and the end
> tags, doesn't it make a user recall one should start writing there?

This is up to personal preference.  I never write something in between
the tags.  I yank or use C-u M-! - right after C-c RET C-p.  To me, an
empty line in between the tags is unnecessary.

        Christopher

Re: mml-insert-tag: insert closing tag

[Katsumi Yamaoka]

Christopher Schmidt wrote:
>> Ok, it's a sound argument anyway.  I'm going to install your patch.
>> Er, if there is a single empty line between the open and the end
>> tags, doesn't it make a user recall one should start writing there?

> This is up to personal preference.  I never write something in between
> the tags.  I yank or use C-u M-! - right after C-c RET C-p.  To me, an
> empty line in between the tags is unnecessary.

Though I don't know what functions those keys are bound to, I can
agree with such a neat spec.  Yes, that there is a place to write
as if it is opened by C-o is indeed my personal preference.
(Also I may want to tell my wife, a Gnus user over ten years, that
 she had better do C-o in front of a closing tag. ;-)
Anyway I've installed your patch as is.  Thanks.

Re: mml-insert-tag: insert closing tag

[Christopher Schmidt]

Katsumi Yamaoka <yamaoka@jpl.org> writes:
> Though I don't know what functions those keys are bound to, I can
> agree with such a neat spec.  Yes, that there is a place to write as
> if it is opened by C-o is indeed my personal preference.  (Also I may
> want to tell my wife, a Gnus user over ten years, that she had better
> do C-o in front of a closing tag. ;-) Anyway I've installed your patch
> as is.  Thanks.

Thank you so much.  :)

Greetings,

        Christopher