Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: ding@gnus.org
Subject: Gravatar and XEmacs
Date: Tue, 28 Sep 2010 14:59:43 +0900	[thread overview]
Message-ID: <b4mr5gepfw0.fsf@jpl.org> (raw)

Hi,

Currently gravatar.el is unable to compile with XEmacs because
image.el is not available:

Compiling gnus/lisp/gravatar.el...
While compiling toplevel forms in file gnus/lisp/gravatar.el:
  !! File error (("Cannot open load file" "image"))

Is there a plan to make it work?  It seems only the create-image
function is the reason image.el is required.  If so:

--8<---------------cut here---------------start------------->8---
--- gravatar.el~	2010-09-26 22:53:00 +0000
+++ gravatar.el	2010-09-28 05:58:08 +0000
@@ -24,7 +24,6 @@
 
 ;;; Code:
 
-(require 'image)
 (require 'url)
 (require 'url-cache)
 
@@ -84,12 +83,22 @@
     (when (search-forward "\n\n" nil t)
       (buffer-substring (point) (point-max)))))
 
+(eval-and-compile
+  (cond ((featurep 'xemacs)
+	 (require 'gnus-xmas)
+	 (defalias 'gravatar-create-image 'gnus-xmas-create-image))
+	((featurep 'gnus-ems)
+	 (defalias 'gravatar-create-image 'gnus-create-image))
+	(t
+	 (require 'image)
+	 (defalias 'gravatar-create-image 'create-image))))
+
 (defun gravatar-data->image ()
   "Get data of current buffer and return an image.
 If no image available, return 'error."
   (let ((data (gravatar-get-data)))
     (if data
-        (create-image data  nil t)
+        (gravatar-create-image data nil t)
       'error)))
 
 ;;;###autoload
--8<---------------cut here---------------end--------------->8---

Though it may be no more than a starting point to make it work
since I haven't tried Gravatar yet, though. ;-)



             reply	other threads:[~2010-09-28  5:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-28  5:59 Katsumi Yamaoka [this message]
2010-09-28  7:45 ` Julien Danjou
2010-09-28 11:52   ` Katsumi Yamaoka
2010-09-29 15:04     ` Lars Magne Ingebrigtsen
2010-10-01  5:46       ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4mr5gepfw0.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).