Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: Eythan Weg <eythanweg@gmail.com>
Cc: ding@gnus.org, emacs-devel@gnu.org
Subject: Re: attaching a file in dired mode
Date: Mon, 23 Feb 2009 16:12:33 +0900	[thread overview]
Message-ID: <b4mskm5eie6.fsf@jpl.org> (raw)
In-Reply-To: <87tz6p1c85.fsf@gmail.com>

>>>>> Eythan Weg wrote:
> Hi,

> When I use  gnus-dired-attach while the cursor is on a
> file in dired buffer it results in

>        Invalid function:   gnus-setup-message

> Attaching a file works  correctly when a mail
> buffer  exists.

> What should be expected?

> I use gnus in a recent cvs emacs

> Thanks, Eythan

This happens with Gnus bundled with Emacs.  `gnus-setup-message'
is a macro that should be provided when compiling gnus-dired.el,
however I realized it is not loaded when compiling gnus-dired.el
along with Emacs (no problem when performing `make' on No Gnus).
I've fixed it in the Emacs trunk as follows:

--8<---------------cut here---------------start------------->8---
*** gnus-dired.el~	Mon Jan  5 03:21:57 2009
--- gnus-dired.el	Mon Feb 23 06:58:34 2009
***************
*** 53,61 ****
  ;; Autoloads to avoid byte-compiler warnings.  These are used only if the user
  ;; customizes `gnus-dired-mail-mode' to use Message and/or Gnus.
  (autoload 'message-buffers "message")
- (autoload 'gnus-setup-message "gnus-msg")
  (autoload 'gnus-print-buffer "gnus-sum")
  
  (defvar gnus-dired-mode nil
    "Minor mode for intersections of MIME mail composition and dired.")
  
--- 53,63 ----
  ;; Autoloads to avoid byte-compiler warnings.  These are used only if the user
  ;; customizes `gnus-dired-mail-mode' to use Message and/or Gnus.
  (autoload 'message-buffers "message")
  (autoload 'gnus-print-buffer "gnus-sum")
  
+ ;; Load the `gnus-setup-message' macro that `gnus-dired-attach' uses.
+ (require 'gnus-msg)
+ 
  (defvar gnus-dired-mode nil
    "Minor mode for intersections of MIME mail composition and dired.")
  
--8<---------------cut here---------------end--------------->8---

Note: using `eval-when-compile' generates useless warnings.

Regards,




  reply	other threads:[~2009-02-23  7:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-20 13:15 Eythan Weg
2009-02-23  7:12 ` Katsumi Yamaoka [this message]
2009-02-23 19:17   ` Glenn Morris
2009-02-23 23:41     ` Katsumi Yamaoka
2009-02-24 18:23       ` Glenn Morris
2009-02-25  2:26         ` Katsumi Yamaoka
2009-02-25  3:59           ` Glenn Morris
2009-02-24 14:48   ` Eythan Weg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4mskm5eie6.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=ding@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=eythanweg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).