Re: Make ietf-drums-remove-comments() robust against broken header

[Katsumi Yamaoka <yamaoka@jpl.org>]

>>>>> Ted Zlatanov wrote:
> Because this was breaking my split methods and thus my entire Gnus
> startup (because I use gnus-registry-split-fancy-with-parent), I took
> the liberty of installing the change.  In addition, I put in an extra
> condition-case to prevent any other such problems, assuming that at
> worst we'd have bad references due to parsing bugs.

> If this is not OK, please put in whatever changes you think are
> appropriate, as long as they don't bring the bug back :)

If the purpose of the extra `condition-case' you added is for
another `forward-sexp', isn't it better to be the following for
making the code easy to see?

--8<---------------cut here---------------start------------->8---
(defun ietf-drums-remove-comments (string)
  "Remove comments from STRING."
  (with-temp-buffer
    (let (c)
      (ietf-drums-init string)
      (while (not (eobp))
	(setq c (char-after))
	(cond
	 ((eq c ?\")
	  (condition-case nil
	      (forward-sexp 1)
	    (goto-char (point-max))))
	 ((eq c ?\()
	  (delete-region
	   (point)
	   (condition-case nil
	       (with-syntax-table (copy-syntax-table ietf-drums-syntax-table)
		 (modify-syntax-entry ?\" "w")
		 (forward-sexp 1)
		 (point))
	     (error (point-max)))))
	 (t
	  (forward-char 1))))
      (buffer-string))))
--8<---------------cut here---------------end--------------->8---

BTW, I tried the benchmark and verified that TSUCHIYA-san's change
does not slow Gnus.

Regards,