'configure' doesn't preserve spaces in directory path.

'configure' doesn't preserve spaces in directory path.

[Malcolm Purvis]

Back in 2006, Chris Shenton reported a bug in configure when the
installation path contains a space:

http://article.gmane.org/gmane.emacs.gnus.general/62483

In response Katsumi Yamaoka posted an improved patch:

http://article.gmane.org/gmane.emacs.gnus.general/62487

For some reason this patch hasn't been applied, but the bug is still
present, and bit me recently.  Would it be possible to have this patch
applied?

Katsumi Yamaoka's patch is:

--- aclocal.m4~	2005-10-04 08:37:27 +0000
+++ aclocal.m4	2006-04-03 23:35:24 +0000
@@ -91,7 +91,8 @@
     fi
     for thedir in share lib; do
 	potential=
-	if test -d ${theprefix}/${thedir}/${EMACS_FLAVOR}/site-lisp; then
+	dnl The directory name should be quoted because it might contain spaces.
+	if test -d "${theprefix}/${thedir}/${EMACS_FLAVOR}/site-lisp"; then
            if test "$EMACS_FLAVOR" = "xemacs"; then
 	       lispdir="\$(prefix)/${thedir}/${EMACS_FLAVOR}/site-packages/lisp/gnus"
            else
@@ -322,6 +323,28 @@
 AC_SUBST(USE_FONTS)
 ])

+# Redefine AC_SITE_LOAD which is originally defined in general.m4.
+# ----------------------------------------------------------------
+# Look for site or system specific initialization scripts.
+m4_define([AC_SITE_LOAD],
+[# Prefer explicitly selected file to automatically selected ones.
+if test -z "$CONFIG_SITE"; then
+  if test "x$prefix" != xNONE; then
+    CONFIG_SITE="$prefix/share/config.site $prefix/etc/config.site"
+  else
+    CONFIG_SITE="$ac_default_prefix/share/config.site $ac_default_prefix/etc/config.site"
+  fi
+fi
+dnl $CONFIG_SITE should be quoted because the value might contain spaces.
+for ac_site_file in "$CONFIG_SITE"; do
+  if test -r "$ac_site_file"; then
+    AC_MSG_NOTICE([loading site script $ac_site_file])
+    sed 's/^/| /' "$ac_site_file" >&AS_MESSAGE_LOG_FD
+    . "$ac_site_file"
+  fi
+done
+])
+
 ifelse(dnl	Do not change this comment
    arch-tag: 5c987641-c3ef-4f12-b067-028302282c66
 )dnl

Thanks,

Malcolm

-- 
		     Malcolm Purvis <malcolmp@xemacs.org>

Re: 'configure' doesn't preserve spaces in directory path.

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]

>>>>> Malcolm Purvis wrote:

> Back in 2006, Chris Shenton reported a bug in configure when the
> installation path contains a space:

> http://article.gmane.org/gmane.emacs.gnus.general/62483

> In response Katsumi Yamaoka posted an improved patch:

> http://article.gmane.org/gmane.emacs.gnus.general/62487

> For some reason this patch hasn't been applied, but the bug is still
> present, and bit me recently.  Would it be possible to have this patch
> applied?

> Katsumi Yamaoka's patch is:

I realized that that was totally insufficient to solve the problem.
Could you try the attached patch and the configure script?

Please never run the older version of autoconf, e.g. v2.59.  You'd
better copy the attached configure script, and perform `chmod +x'
and `touch' on it (so as to make it newer than aclocal.m4 and
configure.in).


[-- Attachment #2: PATCH.gz --]
[-- Type: application/x-gzip, Size: 3343 bytes --]

[-- Attachment #3: configure.gz --]
[-- Type: application/x-gzip, Size: 26204 bytes --]

Re: 'configure' doesn't preserve spaces in directory path.

[Katsumi Yamaoka]

>>>>> Katsumi Yamaoka wrote:
>>>>>> Malcolm Purvis wrote:

>> Back in 2006, Chris Shenton reported a bug in configure when the
>> installation path contains a space:

>> http://article.gmane.org/gmane.emacs.gnus.general/62483

>> In response Katsumi Yamaoka posted an improved patch:

>> http://article.gmane.org/gmane.emacs.gnus.general/62487

>> For some reason this patch hasn't been applied, but the bug is still
>> present, and bit me recently.  Would it be possible to have this patch
>> applied?

>> Katsumi Yamaoka's patch is:

> I realized that that was totally insufficient to solve the problem.
> Could you try the attached patch and the configure script?

I arranged the patch neatly and installed in the Gnus CVS trunk.

Note that the configure script there has been regenerated by
autoconf v2.61[1], and the file timestamp should be newer than
configure.in and aclocal.m4 (actually, I installed the other
files first, and then installed the configure script after a
while).  However, if it doesn't go well when you check it out,
it will be regenerated using the version of autoconf available
in your system, or it might not work if you don't have autoconf
installed.  If you meet such a trouble, please let me know.

[1] Autoconf v2.60 and the greater ones support the installation
    directory name containing spaces and/or tabs.

Re: 'configure' doesn't preserve spaces in directory path.

[Malcolm Purvis]

>>>>> "Katsumi" == Katsumi Yamaoka <yamaoka@jpl.org> writes:

Katsumi> I arranged the patch neatly and installed in the Gnus CVS
Katsumi> trunk.

Thanks, that works much better!

Malcolm

-- 
		     Malcolm Purvis <malcolmp@xemacs.org>