From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/65434 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: Re: Warning: `mapcar' called for effect; use `mapc' or `dolist' Date: Mon, 22 Oct 2007 21:13:39 +0900 Organization: Emacsen advocacy group Message-ID: References: <200710200643.l9K6h9gk021348@oogie-boogie.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1193055301 1477 80.91.229.12 (22 Oct 2007 12:15:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 22 Oct 2007 12:15:01 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M13935@lists.math.uh.edu Mon Oct 22 14:15:01 2007 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1IjwBP-0006HH-LI for ding-account@gmane.org; Mon, 22 Oct 2007 14:15:01 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1IjwAT-0001Ba-0o; Mon, 22 Oct 2007 07:14:01 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1IjwAR-0001BR-HY for ding@lists.math.uh.edu; Mon, 22 Oct 2007 07:13:59 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1IjwAL-000642-Cm for ding@lists.math.uh.edu; Mon, 22 Oct 2007 07:13:59 -0500 Original-Received: from orlando.hostforweb.net ([216.246.45.90]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1IjwAE-0006OQ-00 for ; Mon, 22 Oct 2007 14:13:46 +0200 Original-Received: from [66.225.201.151] (port=48071 helo=mail.jpl.org) by orlando.hostforweb.net with esmtpa (Exim 4.68) (envelope-from ) id 1IjwAx-0005EQ-9o for ding@gnus.org; Mon, 22 Oct 2007 07:14:32 -0500 X-Hashcash: 1:20:071022:ding@gnus.org::utzveS0Br2V3jpSc:000027Kb X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:98oEqzBI7fOhUQu16vHzn00V+MA= X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - orlando.hostforweb.net X-AntiAbuse: Original Domain - gnus.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -2.4 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:65434 Archived-At: >>>>> Dan Nicolaescu wrote: > The subject is about a new warning produced by the byte > compiler. There's a lot of those for gnus. > Assuming that all emacs versions that gnus wants to support have > either mapc or dolist, can somebody please take care of these > warnings? > Thanks With No Gnus v0.7 I did `cd lisp; make warn' and tried replacing of `mapcar' with `mapc', `dolist', or `while' loops for a while, and realized it's not easy and not safe. Ones who do it will need to study what things using `mapcar' do in all cases. For instance, `mapcar' used in `gnus-group-highlight-line' cannot be replaced with `mapc' even if the compiler warns it. In addition, we'd better use `while' loops (or `dolist') rather than `mapc' because it is faster, though it needs more work. I think it's worth working anyway but it will take time. Regards,