% in group name is not displayed

% in group name is not displayed

[Katsuhiro Hermit Endo]

Hi,

'%' in group name is not displayed on mode-line in summary buffer.
ex.
nnimap:INBOX.aa-100% => nnimap:INBOX.aa-100
nnmaildir:aa-100%    => nnmaildir:aa-100

'%' must be escaped for mode-line-buffer-identification ?
Or '%' does not have to be used in group name ?

-- 
Katsuhiro Hermit Endo

Re: % in group name is not displayed

[Katsumi Yamaoka]

>>>>> In <7zslhbvjyv.fsf@emmie.koka-in.org> 
>>>>>	Katsuhiro Hermit Endo <hermit@koka-in.org> wrote:

> '%' in group name is not displayed on mode-line in summary buffer.
> ex.
> nnimap:INBOX.aa-100% => nnimap:INBOX.aa-100
> nnmaildir:aa-100%    => nnmaildir:aa-100

> '%' must be escaped for mode-line-buffer-identification ?

Yes, it should be.  I believe the following patch fixes this,
however I have no time to verify its rightfulness thoroughly
(because my main computer is in bad condition :-<).  I would
very much appreciate someone looking into it.

Best regards,

--- gnus-sum.el~	2006-10-25 07:24:37 +0000
+++ gnus-sum.el	2006-10-27 11:21:04 +0000
@@ -5832,8 +5832,9 @@
 	(let* ((mformat (symbol-value
 			 (intern
 			  (format "gnus-%s-mode-line-format-spec" where))))
-	       (gnus-tmp-group-name (gnus-group-decoded-name
-				     gnus-newsgroup-name))
+	       (gnus-tmp-group-name (gnus-mode-string-quote
+				     (gnus-group-decoded-name
+				      gnus-newsgroup-name)))
 	       (gnus-tmp-article-number (or gnus-current-article 0))
 	       (gnus-tmp-unread gnus-newsgroup-unreads)
 	       (gnus-tmp-unread-and-unticked (length gnus-newsgroup-unreads))

Re: % in group name is not displayed

[hermit]

>> '%' must be escaped for mode-line-buffer-identification ?
>
> Yes, it should be.  I believe the following patch fixes this,

Thanks, your patch works good.
I try using it for a while.

-- 
Katsuhiro Hermit Endo

Re: % in group name is not displayed

[Katsumi Yamaoka]

>>>>> In <7zu01prv5a.fsf@emmie.koka-in.org>
>>>>>	hermit@koka-in.org wrote:

>>> '%' must be escaped for mode-line-buffer-identification ?

>> Yes, it should be.  I believe the following patch fixes this,

> Thanks, your patch works good.
> I try using it for a while.

I verified that fix is effective to every gnus-.*-format
containing %g, and there seems to be no other format items that
also should be fixed.  So, I installed the change in the trunk
and the v5-10 branch.