Re: gnus-agent-read-local

[Katsumi Yamaoka <yamaoka@jpl.org>]

Hi,

YAGI Tatsuya reported that there is a bug in the
`gnus-agent-read-local' function.  When it reads a
"~/News/agent/BACKEND/SERVER/agent.lib/local" file, many group
names listed in that file will be bound as global symbols.  For
instance, if the file contains the following entry,

gnu\.emacs\.gnus 1234 5678

the variable `gnu\.emacs\.gnus' will be bound globally and set
to the value `(1234 . 5678)'.  As long as I understand, all such
symbols should be in the private obarray.  Actually, the code
will do so if the first element of each entry is a string.
However, it doesn't, since all they are now just symbols.
Here's an extract of the `gnus-agent-read-local' function:

--8<---------------cut here---------------start------------->8---
              (setq group (read cur)
                    min (read cur)
                    max (read cur))

              (when (stringp group)
                (setq group (intern group my-obarray)))

              ;; NOTE: The '+ 0' ensure that min and max are both numerics.
              (set group (cons (+ 0 min) (+ 0 max)))
--8<---------------cut here---------------end--------------->8---

I think the middle part should be replaced with

--8<---------------cut here---------------start------------->8---
	      (if (stringp group)
		  (setq group (intern group my-obarray))
		(setq group (intern (symbol-name group) my-obarray)))
--8<---------------cut here---------------end--------------->8---

or simply with

--8<---------------cut here---------------start------------->8---
	      (setq group (intern (symbol-name group) my-obarray))
--8<---------------cut here---------------end--------------->8---

However, I'm not sure the other functions work correctly
assuming those variables are the ones in the private obarray,
not global variables.  Could anyone fix this properly?

Regards,