* The new registry errors when spam.el is moving messages
@ 2011-04-20 10:04 Tassilo Horn
2011-04-20 10:56 ` Tassilo Horn
0 siblings, 1 reply; 9+ messages in thread
From: Tassilo Horn @ 2011-04-20 10:04 UTC (permalink / raw)
To: ding
Hi Ted,
I have this spam.el setup:
--8<---------------cut here---------------start------------->8---
(spam-initialize)
(setq gnus-spam-newsgroup-contents
'(("\\(spam\\|Junk\\)" gnus-group-spam-classification-spam))
;; Move SPAM in normal groups to traning.spam.
gnus-spam-process-destinations
'(("nnimap\\+Fastmail:"
"nnimap+Fastmail:INBOX.training.spam")
("nnimap\\+Uni:"
"nnimap+Uni:Junk"))
;; Move ham in spam groups to inbox and training.ham.
gnus-ham-process-destinations
'(("nnimap\\+Fastmail:INBOX\\.Junk Mail"
"nnimap+Fastmail:INBOX"
"nnimap+Fastmail:INBOX.training.ham")))
--8<---------------cut here---------------end--------------->8---
Now I had some spam messages in some group, marked them with $ and hit q
to leave the summary. Usually, that would have moved the spam messages
to my nnimap+Fastmail:INBOX.training.spam group. It tried to do so, but
I got this error.
--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (wrong-type-argument listp [96 "Hello Software User !!!The Hottest Products, FlashCS5 and more at Photoshop Plugins" "Photoshop Plugins <adobeupdate@cheapsneer.com>" #("Wed, 20 Apr 2011 06:34:00 +0000" 0 1 (gnus-time (19886 32344))) "<201104200634.p3K6YXxW029107@linnode.donarmstrong.com>" nil 34463 34 nil ((To . "=?UTF-8?Q?Software=20User?= <emacsbugs@lists.donarmstrong.com>"))])
gnus-registry-action(move [96 "Hello Software User !!!The Hottest Products, FlashCS5 and more at Photoshop Plugins" "Photoshop Plugins <adobeupdate@cheapsneer.com>" #("Wed, 20 Apr 2011 06:34:00 +0000" 0 1 (gnus-time (19886 32344))) "<201104200634.p3K6YXxW029107@linnode.donarmstrong.com>" nil 34463 34 nil ((To . "=?UTF-8?Q?Software=20User?= <emacsbugs@lists.donarmstrong.com>"))] "nnimap+Fastmail:INBOX.mailinglists.misc" "nnimap+Fastmail:INBOX.training.spam" nil)
run-hook-with-args(gnus-registry-action move [96 "Hello Software User !!!The Hottest Products, FlashCS5 and more at Photoshop Plugins" "Photoshop Plugins <adobeupdate@cheapsneer.com>" #("Wed, 20 Apr 2011 06:34:00 +0000" 0 1 (gnus-time (19886 32344))) "<201104200634.p3K6YXxW029107@linnode.donarmstrong.com>" nil 34463 34 nil ((To . "=?UTF-8?Q?Software=20User?= <emacsbugs@lists.donarmstrong.com>"))] "nnimap+Fastmail:INBOX.mailinglists.misc" "nnimap+Fastmail:INBOX.training.spam" nil)
gnus-summary-move-article(nil "nnimap+Fastmail:INBOX.training.spam")
spam-copy-or-move-routine(nil ("nnimap+Fastmail:INBOX.training.spam") (96 95) spam)
spam-move-spam-routine((96 95))
spam-register-routine(spam spam-use-move (96 95))
spam-resolve-registrations-routine()
spam-summary-prepare-exit()
run-hooks(gnus-summary-prepare-exit-hook)
apply(run-hooks gnus-summary-prepare-exit-hook)
gnus-run-hooks(gnus-summary-prepare-exit-hook)
gnus-summary-exit()
call-interactively(gnus-summary-exit nil nil)
--8<---------------cut here---------------end--------------->8---
Does the registry now use vectors instead of lists? If so, then spam.el
has to be updated.
Bye,
Tassilo
--
Sent from my Emacs
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: The new registry errors when spam.el is moving messages
2011-04-20 10:04 The new registry errors when spam.el is moving messages Tassilo Horn
@ 2011-04-20 10:56 ` Tassilo Horn
2011-04-20 13:01 ` Katsumi Yamaoka
2011-04-20 20:55 ` Ted Zlatanov
0 siblings, 2 replies; 9+ messages in thread
From: Tassilo Horn @ 2011-04-20 10:56 UTC (permalink / raw)
To: ding
Hi again,
it seems the problem is not the movement made my spam.el but the
deletion of the message (which movement implies). When I delete some
message using B DEL and quit the summary, I get a similar error.
--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (wrong-type-argument listp [8381 "Einladung zum iCal-Ereignis: BA Becker" "\"Dr. Volker Riediger\" <riediger@uni-koblenz.de>" #("Wed, 13 Apr 2011 15:05:56 +0200" 0 1 (gnus-time (19877 40884))) "<A1C65A0F-D87A-43F1-A0D0-0E06BAFA17EE@uni-koblenz.de>" nil 8181 3 nil ((To . "Horn Tassilo <horn@uni-koblenz.de>"))])
gnus-registry-action(delete [8381 "Einladung zum iCal-Ereignis: BA Becker" "\"Dr. Volker Riediger\" <riediger@uni-koblenz.de>" #("Wed, 13 Apr 2011 15:05:56 +0200" 0 1 (gnus-time (19877 40884))) "<A1C65A0F-D87A-43F1-A0D0-0E06BAFA17EE@uni-koblenz.de>" nil 8181 3 nil ((To . "Horn Tassilo <horn@uni-koblenz.de>"))] "nnimap+Uni:INBOX" nil nil)
run-hook-with-args(gnus-registry-action delete [8381 "Einladung zum iCal-Ereignis: BA Becker" "\"Dr. Volker Riediger\" <riediger@uni-koblenz.de>" #("Wed, 13 Apr 2011 15:05:56 +0200" 0 1 (gnus-time (19877 40884))) "<A1C65A0F-D87A-43F1-A0D0-0E06BAFA17EE@uni-koblenz.de>" nil 8181 3 nil ((To . "Horn Tassilo <horn@uni-koblenz.de>"))] "nnimap+Uni:INBOX" nil nil)
gnus-summary-delete-article(nil)
call-interactively(gnus-summary-delete-article nil nil)
--8<---------------cut here---------------end--------------->8---
Bye,
Tassilo
--
Sent from my Emacs
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: The new registry errors when spam.el is moving messages
2011-04-20 10:56 ` Tassilo Horn
@ 2011-04-20 13:01 ` Katsumi Yamaoka
2011-04-20 18:34 ` Ted Zlatanov
2011-04-20 20:55 ` Ted Zlatanov
1 sibling, 1 reply; 9+ messages in thread
From: Katsumi Yamaoka @ 2011-04-20 13:01 UTC (permalink / raw)
To: ding
Tassilo Horn <tassilo@member.fsf.org> wrote:
> Debugger entered--Lisp error: (wrong-type-argument listp [...])
> gnus-registry-action(...
The immediate cause of this seems to be due to the last change
of mine. I knew it's far to the solution, but I have no idea
making it better. Only I'm sure is that the new gnus-registry
is far to completion.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: The new registry errors when spam.el is moving messages
2011-04-20 13:01 ` Katsumi Yamaoka
@ 2011-04-20 18:34 ` Ted Zlatanov
2011-04-21 0:05 ` Katsumi Yamaoka
0 siblings, 1 reply; 9+ messages in thread
From: Ted Zlatanov @ 2011-04-20 18:34 UTC (permalink / raw)
To: ding
On Wed, 20 Apr 2011 22:01:10 +0900 Katsumi Yamaoka <yamaoka@jpl.org> wrote:
KY> Tassilo Horn <tassilo@member.fsf.org> wrote:
>> Debugger entered--Lisp error: (wrong-type-argument listp [...])
>> gnus-registry-action(...
KY> The immediate cause of this seems to be due to the last change
KY> of mine. I knew it's far to the solution, but I have no idea
KY> making it better.
You mean the mail-header or the CL changes?
KY> Only I'm sure is that the new gnus-registry is far to completion.
It was working fine for me before the changes. Other than the bug Andre
Cohen reported with followed-groups, I think it's actually very stable
and reliable. What is missing or broken?
Ted
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: The new registry errors when spam.el is moving messages
2011-04-20 18:34 ` Ted Zlatanov
@ 2011-04-21 0:05 ` Katsumi Yamaoka
2011-04-21 20:26 ` Ted Zlatanov
0 siblings, 1 reply; 9+ messages in thread
From: Katsumi Yamaoka @ 2011-04-21 0:05 UTC (permalink / raw)
To: ding
Ted Zlatanov <tzz@lifelogs.com> wrote:
> On Wed, 20 Apr 2011 22:01:10 +0900 Katsumi Yamaoka <yamaoka@jpl.org> wrote:
KY> Tassilo Horn <tassilo@member.fsf.org> wrote:
>>> Debugger entered--Lisp error: (wrong-type-argument listp [...])
>>> gnus-registry-action(...
KY> The immediate cause of this seems to be due to the last change
KY> of mine. I knew it's far to the solution, but I have no idea
KY> making it better.
> You mean the mail-header or the CL changes?
I meant `mail-header', that never works unless the variable named
`headers' is bound. Try: (mail-header "Cc" nil)
So I replaced it with things similar to the original. And I noticed,
it never works, either. In `gnus-registry-action':
(cdr (assq "Cc" data-header))
`data-header' never contains a string that is identical to the
Lisp object "Cc" (i.e., only it is `eq' to itself). Moreover,
`data-header' is a vector, not an alist, isn't it? And then I
looked for functions, like `mail-header-from', for Cc and To in
nnheader.el. However, there's no room for those headers in Gnus'
header object (i.e., a vector of the length 10).
KY> Only I'm sure is that the new gnus-registry is far to completion.
> It was working fine for me before the changes.
Because some mis-designed functions are hidden by `ignore-errors',
I thought.
> Other than the bug Andre Cohen reported with followed-groups,
> I think it's actually very stable and reliable. What is missing
> or broken?
Although I've never used it, I can imagine it doesn't work for To
and Cc headers. That's why I feel it incomplete. To achieve it,
maybe other Gnus resources need to be changed.
Regards,
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: The new registry errors when spam.el is moving messages
2011-04-21 0:05 ` Katsumi Yamaoka
@ 2011-04-21 20:26 ` Ted Zlatanov
2011-04-21 23:09 ` Katsumi Yamaoka
0 siblings, 1 reply; 9+ messages in thread
From: Ted Zlatanov @ 2011-04-21 20:26 UTC (permalink / raw)
To: ding
On Thu, 21 Apr 2011 09:05:05 +0900 Katsumi Yamaoka <yamaoka@jpl.org> wrote:
KY> Ted Zlatanov <tzz@lifelogs.com> wrote:
>> You mean the mail-header or the CL changes?
KY> I meant `mail-header', that never works unless the variable named
KY> `headers' is bound. Try: (mail-header "Cc" nil)
KY> So I replaced it with things similar to the original. And I noticed,
KY> it never works, either. In `gnus-registry-action':
...
I fixed this: we need to use the extra header slot (`mail-header-extra')
and that's an alist of headers. But the user needs to add To and Cc to
`gnus-extra-headers', so I explained that in the package commentary.
I actually think To and Cc should be in `gnus-extra-headers' by default.
Is there any reason not to add them? The extra memory usage is
negligible.
>> It was working fine for me before the changes.
KY> Because some mis-designed functions are hidden by `ignore-errors',
KY> I thought.
Yes. Oh, but it was nicely quiet, wasn't it? ;)
>> Other than the bug Andre Cohen reported with followed-groups,
KY> Although I've never used it, I can imagine it doesn't work for To
KY> and Cc headers. That's why I feel it incomplete. To achieve it,
KY> maybe other Gnus resources need to be changed.
Fortunately I think we're OK now.
Thanks for working on this.
Ted
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: The new registry errors when spam.el is moving messages
2011-04-21 20:26 ` Ted Zlatanov
@ 2011-04-21 23:09 ` Katsumi Yamaoka
2011-04-21 23:26 ` Ted Zlatanov
0 siblings, 1 reply; 9+ messages in thread
From: Katsumi Yamaoka @ 2011-04-21 23:09 UTC (permalink / raw)
To: ding
Ted Zlatanov <tzz@lifelogs.com> wrote:
[...]
> I fixed this: we need to use the extra header slot (`mail-header-extra')
> and that's an alist of headers. But the user needs to add To and Cc to
> `gnus-extra-headers', so I explained that in the package commentary.
Oh, I realized gnus-registry.el is not incomplete. Sorry for my
having been rudeness.
> I actually think To and Cc should be in `gnus-extra-headers' by default.
> Is there any reason not to add them? The extra memory usage is
> negligible.
That's reasonable. Please do it.
[...]
> Fortunately I think we're OK now.
I believe it. Thanks for your work.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: The new registry errors when spam.el is moving messages
2011-04-21 23:09 ` Katsumi Yamaoka
@ 2011-04-21 23:26 ` Ted Zlatanov
0 siblings, 0 replies; 9+ messages in thread
From: Ted Zlatanov @ 2011-04-21 23:26 UTC (permalink / raw)
To: ding
On Fri, 22 Apr 2011 08:09:39 +0900 Katsumi Yamaoka <yamaoka@jpl.org> wrote:
KY> Ted Zlatanov <tzz@lifelogs.com> wrote:
KY> [...]
>> I fixed this: we need to use the extra header slot (`mail-header-extra')
>> and that's an alist of headers. But the user needs to add To and Cc to
>> `gnus-extra-headers', so I explained that in the package commentary.
KY> Oh, I realized gnus-registry.el is not incomplete. Sorry for my
KY> having been rudeness.
You were right to complain. `ignore-errors' definitely was a sign I was
doing something idiotic :)
>> I actually think To and Cc should be in `gnus-extra-headers' by default.
>> Is there any reason not to add them? The extra memory usage is
>> negligible.
KY> That's reasonable. Please do it.
Done. Let's see what else I broke!
Ted
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: The new registry errors when spam.el is moving messages
2011-04-20 10:56 ` Tassilo Horn
2011-04-20 13:01 ` Katsumi Yamaoka
@ 2011-04-20 20:55 ` Ted Zlatanov
1 sibling, 0 replies; 9+ messages in thread
From: Ted Zlatanov @ 2011-04-20 20:55 UTC (permalink / raw)
To: ding
On Wed, 20 Apr 2011 12:56:50 +0200 Tassilo Horn <tassilo@member.fsf.org> wrote:
TH> it seems the problem is not the movement made my spam.el but the
TH> deletion of the message (which movement implies). When I delete some
TH> message using B DEL and quit the summary, I get a similar error.
TH> Debugger entered--Lisp error: (wrong-type-argument listp [8381 "Einladung zum iCal-Ereignis: BA Becker" "\"Dr. Volker Riediger\" <riediger@uni-koblenz.de>" #("Wed, 13 Apr 2011 15:05:56 +0200" 0 1 (gnus-time (19877 40884))) "<A1C65A0F-D87A-43F1-A0D0-0E06BAFA17EE@uni-koblenz.de>" nil 8181 3 nil ((To . "Horn Tassilo <horn@uni-koblenz.de>"))])
TH> gnus-registry-action(delete [8381 "Einladung zum iCal-Ereignis: BA Becker" "\"Dr. Volker Riediger\" <riediger@uni-koblenz.de>" #("Wed, 13 Apr 2011 15:05:56 +0200" 0 1 (gnus-time (19877 40884))) "<A1C65A0F-D87A-43F1-A0D0-0E06BAFA17EE@uni-koblenz.de>" nil 8181 3 nil ((To . "Horn Tassilo <horn@uni-koblenz.de>"))] "nnimap+Uni:INBOX" nil nil)
TH> run-hook-with-args(gnus-registry-action delete [8381 "Einladung zum iCal-Ereignis: BA Becker" "\"Dr. Volker Riediger\" <riediger@uni-koblenz.de>" #("Wed, 13 Apr 2011 15:05:56 +0200" 0 1 (gnus-time (19877 40884))) "<A1C65A0F-D87A-43F1-A0D0-0E06BAFA17EE@uni-koblenz.de>" nil 8181 3 nil ((To . "Horn Tassilo <horn@uni-koblenz.de>"))] "nnimap+Uni:INBOX" nil nil)
TH> gnus-summary-delete-article(nil)
TH> call-interactively(gnus-summary-delete-article nil nil)
Gnus is calling `gnus-registry-action' with a good data header, but the
change Yamaoka-san made to remove the dependency on mailheader.el in
2c311f43f25dbb0a0353712573d06496bd93ace2 seem to have broken it. I'll
wait for him to decide how to resolve this.
I also used `ignore-errors' around this call, which may have been hiding
the error anyhow, but that's because in many cases the header is not
included by default. I don't know much about the data header so if
anyone has better suggestions, let me and Yamaoka-san know.
Thanks
Ted
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-04-21 23:26 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-20 10:04 The new registry errors when spam.el is moving messages Tassilo Horn
2011-04-20 10:56 ` Tassilo Horn
2011-04-20 13:01 ` Katsumi Yamaoka
2011-04-20 18:34 ` Ted Zlatanov
2011-04-21 0:05 ` Katsumi Yamaoka
2011-04-21 20:26 ` Ted Zlatanov
2011-04-21 23:09 ` Katsumi Yamaoka
2011-04-21 23:26 ` Ted Zlatanov
2011-04-20 20:55 ` Ted Zlatanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).