Re: Annoying windowp nil error

[Katsumi Yamaoka <yamaoka@jpl.org>]

>>>>> Adam Sjøgren wrote:
>   Hi.

> For quite as while I have sometimes gotten an annoying "Wrong type
> argument: windowp, nil" when finished reading an article.

> It didn't happen often enough that I bothered to investigate until
> today; I thought I might just have configured something weirdly.

> I have found out that it happens when I page through the last article of
> a group by pressing SPC, when reaching the end of the article, but only
> if I have a second window opened with gnuclient!

> It looks like something has changed, making the weird work-around that
> the patch included below removes not necessary - and now actually
> detrimental?

> At least on my machine:

>   XEmacs 21.4 (patch 22) "Instant Classic" [Lucid] (x86_64-linux-gnu,
>     Mule) of Tue Mar 3 2009 on nautilus
>   No Gnus v0.11

> Any ideas as to what the correct solution might be?

I've never gotten such an error, though it will be because I do
not use (gnu|emacs)client.  I don't know how the trouble Ueno-san
mentioned in the comment happens.

> -      ;; For some reason, the group window gets selected.  We change
> -      ;; it back.
> -      (select-window (get-buffer-window (current-buffer)))

But this workaround potentially causes an error on a user who uses
a customized window configuration so that Gnus places some Gnus
windows in separate Emacs frames.  I mean `get-buffer-window'
returns nil if the buffer does not have a window in the current
frame.

> Maybe the real solution is just to guard against calling select-window
> with nil?

This will help only users who use the default window configuration
or similar.

      (let ((window (get-buffer-window (current-buffer))))
	(when window
	  (select-window window)))

How about the next one instead?

      (gnus-configure-windows 'summary)

I have no means to make sure it is a good solution, though.

> Or maybe it is to go through select-window and find out what windowp is
> being called on and add something there. Hm.

> Well, now it has been reported! :-)

>   Best regards,

>     Adam

> Index: gnus-sum.el
> ===================================================================
> RCS file: /usr/local/cvsroot/gnus/lisp/gnus-sum.el,v
> retrieving revision 7.238
> diff -u -r7.238 gnus-sum.el
> --- gnus-sum.el	5 Feb 2009 09:04:09 -0000	7.238
> +++ gnus-sum.el	21 Mar 2009 19:44:47 -0000
> @@ -7635,9 +7635,6 @@
>  	   (if (eq gnus-keep-same-level 'best)
>  	       (gnus-summary-best-group gnus-newsgroup-name)
>  	     (gnus-summary-search-group backward gnus-keep-same-level))))
> -      ;; For some reason, the group window gets selected.  We change
> -      ;; it back.
> -      (select-window (get-buffer-window (current-buffer)))
>        ;; Select next unread newsgroup automagically.
>        (cond
>         ((or (not gnus-auto-select-next)

> --
>  "We get our thursdays from a banana."                        Adam Sjøgren
>                                                          asjo@koldfront.dk