gnus-summary-end-of-article displays beginning of article

gnus-summary-end-of-article displays beginning of article

[Sven Joachim]

With current No Gnus CVS I'm noticing the unwanted behavior that
gnus-summary-end-of-article goes to the beginning of the article, rather
than to the end.  Anyone else seeing this?

I've tried to single-step that function, but failed to find anything
obviously wrong.  And it had not been changed for ages.

Sven

Re: gnus-summary-end-of-article displays beginning of article

[Reiner Steib]

On Mon, Mar 03 2008, Sven Joachim wrote:

> With current No Gnus CVS I'm noticing the unwanted behavior that
> gnus-summary-end-of-article goes to the beginning of the article, rather
> than to the end.  Anyone else seeing this?
>
> I've tried to single-step that function, but failed to find anything
> obviously wrong.  And it had not been changed for ages.

`gnus-summary-end-of-article' has been modified in 5.10.3:

,----
| 2003-10-21  Katsumi Yamaoka  <yamaoka@jpl.org>
| 
| 	* gnus-art.el (gnus-narrow-to-page): Clear as well as set the
| 	value for gnus-page-broken.
| 
| 	* gnus-sum.el (gnus-summary-beginning-of-article): Use
| 	gnus-break-pages instead of gnus-page-broken.
| 	(gnus-summary-end-of-article): Use gnus-break-pages instead of
| 	gnus-page-broken; narrow to the end of a page beforehand.
| 	(gnus-summary-toggle-header): Use gnus-break-pages instead of
| 	gnus-page-broken; remove delimiter buttons unless gnus-break-pages
| 	is non-nil.
`----

After reverting the following hunk, it works as expected for me.

,----
| --- gnus-sum.el	19 Oct 2003 01:09:52 -0000	6.369
| +++ gnus-sum.el	21 Oct 2003 14:28:32 -0000	6.370
| [...]
| @@ -8518,7 +8518,9 @@
|      (widen)
|      (goto-char (point-max))
|      (recenter -3)
| -    (when gnus-page-broken
| +    (when gnus-break-pages
| +      (when (re-search-backward page-delimiter nil t)
| +	(narrow-to-region (match-end 0) (point-max)))
|        (gnus-narrow-to-page))))
|  
|  (defun gnus-summary-print-truncate-and-quote (string &optional len)
`----

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: gnus-summary-end-of-article displays beginning of article

[Sven Joachim]

On 2008-03-04 23:31 +0100, Reiner Steib wrote:

> On Mon, Mar 03 2008, Sven Joachim wrote:
>
>> With current No Gnus CVS I'm noticing the unwanted behavior that
>> gnus-summary-end-of-article goes to the beginning of the article, rather
>> than to the end.  Anyone else seeing this?
>>
>> I've tried to single-step that function, but failed to find anything
>> obviously wrong.  And it had not been changed for ages.
>
> `gnus-summary-end-of-article' has been modified in 5.10.3:

That's what I meant with "ages".  And it still works fine in current
Gnus 5.11 from EMACS_22_BASE.

> After reverting the following hunk, it works as expected for me.
>
> ,----
> | --- gnus-sum.el	19 Oct 2003 01:09:52 -0000	6.369
> | +++ gnus-sum.el	21 Oct 2003 14:28:32 -0000	6.370
> | [...]
> | @@ -8518,7 +8518,9 @@
> |      (widen)
> |      (goto-char (point-max))
> |      (recenter -3)
> | -    (when gnus-page-broken
> | +    (when gnus-break-pages
> | +      (when (re-search-backward page-delimiter nil t)
> | +	(narrow-to-region (match-end 0) (point-max)))
> |        (gnus-narrow-to-page))))
> |  
> |  (defun gnus-summary-print-truncate-and-quote (string &optional len)
> `----

Okay, for the moment I have set gnus-break-pages to nil, which works
around the problem.

Still puzzled,
Sven

Re: gnus-summary-end-of-article displays beginning of article

[Katsumi Yamaoka]

>>>>> Reiner Steib wrote:
> `gnus-summary-end-of-article' has been modified in 5.10.3:

>| 2003-10-21  Katsumi Yamaoka  <yamaoka@jpl.org>

> After reverting the following hunk, it works as expected for me.

[...]

>>>>> Sven Joachim wrote:
> Okay, for the moment I have set gnus-break-pages to nil, which works
> around the problem.

Sorry for inconvenience.  Please let me have time to fix it.

Re: gnus-summary-end-of-article displays beginning of article

[Katsumi Yamaoka]

>>>>> Katsumi Yamaoka wrote:
>>>>>> Sven Joachim wrote:
>> Okay, for the moment I have set gnus-break-pages to nil, which works
>> around the problem.

> Sorry for inconvenience.  Please let me have time to fix it.

Fixed in the Gnus trunk and the v5-10 branch.  Although I didn't
see why `gnus-summary-end-of-article' worked in Emacs 21 and
XEmacs, I also realized some other related functions were not
going well.  Thanks for pointing it out anyway.

Regards,