Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: David Engster <dengste@eml.cc>
Cc: ding@gnus.org
Subject: [BUG] recent change in gnus-inews-do-gcc
Date: Wed, 07 Jan 2009 10:33:32 +0900	[thread overview]
Message-ID: <b4mwsd7c32r.fsf_-_@jpl.org> (raw)
In-Reply-To: <E1LKDnx-0002ty-00@quimby.gnus.org>

>>>>> In <E1LKDnx-0002ty-00@quimby.gnus.org> David Engster wrote:

> Modified: ChangeLog gnus-msg.el

> gnus-msg.el (gnus-inews-do-gcc): Reduce to short group name when on
> primary select method (for gnus-group-mark-article-as-read).

This change causes an error when sending messages containing
the "Gcc: nnml:inbox" header as follows:

Debugger entered--Lisp error: (wrong-type-argument listp "nnml:")
  gnus-native-method-p("nnml:")
  (if (gnus-native-method-p method) (progn (setq group ...)))
[...]
  gnus-inews-do-gcc()
  gnus-agent-possibly-do-gcc()
  run-hooks(message-sent-hook)
  message-send(nil)
  message-send-and-exit(nil)
  call-interactively(message-send-and-exit nil nil)

> --- gnus-msg.el:7.69	Fri Aug  8 13:10:55 2008
> +++ gnus-msg.el	Tue Jan  6 16:25:17 2009
> @@ -1677,6 +1677,8 @@
>  				    group method t t))))
>  		(gnus-message 1 "Couldn't store article in group %s: %s"
>  			      group (gnus-status-message method)))
> +	      (when (gnus-native-method-p method)
> +		(setq group (gnus-group-short-name group)))
>  	      (when (and group-art
>  			 ;; FIXME: Should gcc-mark-as-read work when
>  			 ;; Gnus is not running?

I guess you use the mail method as `gnus-select-method'.  Whereas
I have nntp in it and the others in `gnus-secondary-select-methods'.
So, the method for Gcc groups will never be native in my case.
Is this patch satisfy you and friends?  If so, please install.

--8<---------------cut here---------------start------------->8---
--- gnus-msg.el~	2009-01-06 21:43:06 +0000
+++ gnus-msg.el	2009-01-07 01:32:50 +0000
@@ -1677,7 +1677,8 @@
 				    group method t t))))
 		(gnus-message 1 "Couldn't store article in group %s: %s"
 			      group (gnus-status-message method)))
-	      (when (gnus-native-method-p method)
+	      (when (and (not (stringp method))
+			 (gnus-native-method-p method))
 		(setq group (gnus-group-short-name group)))
 	      (when (and group-art
 			 ;; FIXME: Should gcc-mark-as-read work when
--8<---------------cut here---------------end--------------->8---

BTW, isn't adding of new features frozen now?



       reply	other threads:[~2009-01-07  1:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1LKDnx-0002ty-00@quimby.gnus.org>
2009-01-07  1:33 ` Katsumi Yamaoka [this message]
2009-01-07 10:53   ` David Engster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4mwsd7c32r.fsf_-_@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=dengste@eml.cc \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).