gnus-summary-edit-article adds extra X-From-Line each run

gnus-summary-edit-article adds extra X-From-Line each run

[jidanni]

In(gnus-version)"Gnus v5.11"
gnus-summary-edit-article puts an extra
X-From-Line: nobody Wed Sep  5 06:28:04 2007
at the top of the article each time you use it.
Edit 5 times, get 5 extra X-From-Lines, all the same timestamp too.

Re: gnus-summary-edit-article adds extra X-From-Line each run

[Katsumi Yamaoka]

>>>>> jidanni@jidanni.org wrote:

> In(gnus-version)"Gnus v5.11"
> gnus-summary-edit-article puts an extra
> X-From-Line: nobody Wed Sep  5 06:28:04 2007
> at the top of the article each time you use it.
> Edit 5 times, get 5 extra X-From-Lines, all the same timestamp too.

I didn't find the one which is likely to cause such a problem,
in gnus-article-edit-done, any *-request-replace-article, and
hooks and functions that are called then.  If it is possible,
you'd better perform Edebug (info "(gnus)Troubleshooting") on
`gnus-article-edit-done' and related functions.

Re: gnus-summary-edit-article adds extra X-From-Line each run

[Katsumi Yamaoka]

>>>>> Katsumi Yamaoka wrote:

> you'd better perform Edebug (info "(gnus)Troubleshooting") on
> `gnus-article-edit-done' and related functions.

`gnus-summary-edit-article-done' is what I wanted to say.  Sorry.

Re: gnus-summary-edit-article adds extra X-From-Line each run

[jidanni]

Thanks Katsumi but I can't deal with Edebug.
It's all too complex. I'll CC bugs@gnus.org. They'll fix it:
All I know is gnus-summary-edit-article adds extra X-From-Line each
run. Edit an article five times, get five identical X-From-Lines at
top. They must have only tested it editing an article once.

Re: gnus-summary-edit-article adds extra X-From-Line each run

[Katsumi Yamaoka]

>>>>> jidanni@jidanni.org wrote:

> Thanks Katsumi but I can't deal with Edebug.
> It's all too complex. I'll CC bugs@gnus.org. They'll fix it:
> All I know is gnus-summary-edit-article adds extra X-From-Line each
> run. Edit an article five times, get five identical X-From-Lines at
> top. They must have only tested it editing an article once.

I think you need to say what back end you use when editing
articles, because the functions that replace an article in a
group with the edited one differ according to backends.  For
instance, `nnfolder-request-replace-article' does

(insert "From nobody " (current-time-string) "\n")

as the case may be, but `nnml-request-replace-article' never
does.  I couldn't reproduce such a problem with nnfolder and
nnml, and didn't find any possibility that it arises in any
*-request-replace-article function, though.

Re: gnus-summary-edit-article adds extra X-From-Line each run

[Katsumi Yamaoka]

>>>>> Katsumi Yamaoka wrote:

> For instance, `nnfolder-request-replace-article' does

> (insert "From nobody " (current-time-string) "\n")

> as the case may be,

The `From ...' line will be converted into `X-From-Line: ...'
when a nnfolder article is displayed in the article buffer.

Re: gnus-summary-edit-article adds extra X-From-Line each run

[jidanni]

> which format does the problem occur in?
OK, the format is Article nnmbox:mail.misc.

After editing e.g., four times, the article looks like this:

X-From-Line: nobody Wed Sep  5 06:28:04 2007
X-From-Line: nobody Wed Sep  5 06:28:04 2007
X-From-Line: nobody Wed Sep  5 06:28:04 2007
X-From-Line: nobody Wed Sep  5 06:28:04 2007
Return-path: <jidanni@jidanni.org>
Envelope-to: jidanni@jidanni2
Delivery-date: Wed, 05 Sep 2007 06:26:40 +0800...

Re: gnus-summary-edit-article adds extra X-From-Line each run

[jidanni]

By the way, after each edit, also another layer of CTRL-A's are added.
Here is the head, middle, and tail of *Article nnmbox:mail.misc*

!X-From-Line: nobody Wed Sep  5 06:28:04 2007
!X-From-Line: nobody Wed Sep  5 06:28:04 2007
!X-From-Line: nobody Wed Sep  5 06:28:04 2007
!X-From-Line: nobody Wed Sep  5 06:28:04 2007
!X-From-Line: nobody Wed Sep  5 06:28:04 2007
...
!Xref: jidanni2.jidanni.org mail.misc:1454
!X-Gnus-Newsgroup: mail.misc:1454   Wed Sep  5 06:28:04 2007
...
!^A^A^A^A
!^A^A^A^A
!^A^A^A^A
!^A^A^A^A

Re: gnus-summary-edit-article adds extra X-From-Line each run

[Katsumi Yamaoka]

>>>>> jidanni@jidanni.org wrote:

> By the way, after each edit, also another layer of CTRL-A's are added.
> Here is the head, middle, and tail of *Article nnmbox:mail.misc*

> !X-From-Line: nobody Wed Sep  5 06:28:04 2007
> !X-From-Line: nobody Wed Sep  5 06:28:04 2007
> !X-From-Line: nobody Wed Sep  5 06:28:04 2007
> !X-From-Line: nobody Wed Sep  5 06:28:04 2007
> !X-From-Line: nobody Wed Sep  5 06:28:04 2007
> ...
> !Xref: jidanni2.jidanni.org mail.misc:1454
> !X-Gnus-Newsgroup: mail.misc:1454   Wed Sep  5 06:28:04 2007
> ...
> !^A^A^A^A
> !^A^A^A^A
> !^A^A^A^A
> !^A^A^A^A

I'll fix them.  I could reproduce those evil effects with nnmbox.

Re: gnus-summary-edit-article adds extra X-From-Line each run

[Katsumi Yamaoka]

>>>>> Katsumi Yamaoka wrote:

> I could reproduce those evil effects with nnmbox.

I've fixed those bugs and others (trunk + v5-10 branch).