Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: ding@gnus.org
Subject: Re: customizing mm-charset-synonym-alist
Date: Fri, 27 Apr 2007 07:42:48 +0900	[thread overview]
Message-ID: <b4mwszydafr.fsf@jpl.org> (raw)
In-Reply-To: <v98xce2a54.fsf_-_@marauder.physik.uni-ulm.de>

>>>>> In <v98xce2a54.fsf_-_@marauder.physik.uni-ulm.de>
>>>>>	Reiner Steib wrote:

> On Thu, Apr 26 2007, Katsumi Yamaoka wrote:

>> I've also made it use defcustom, so you can now customize the alist
>> easily.

> I think this is not a good idea.

> 1. `mm-charset-synonym-alist' is modified by mm-setup-codepage-*, so a
>    user will see "CHANGED outside Customize; operating on it here may be
>    unreliable."

Oops.  I fully agree to not making it a user option.

> ,----
>| ;; Initialize:
>| (mm-setup-codepage-iso-8859)
>| (mm-setup-codepage-ibm)
> `----

> 2. The initial value depends on the availability of charsets (lots of
>    `mm-coding-system-p's).  So it will change when using different
>    Emacs versions and flavors.  But if the user has customized it,
>    this conditionals are eliminated.

> IMHO, if we want a customizable variable, we should create a new
> variable (default: nil) and construct `mm-charset-synonym-alist' from
> the new one, `mm-codepage-iso-8859-list' and `mm-codepage-ibm-list'
> (using mm-setup-codepage-*).  A new setup function should check if the
> cdr of each element is a valid charset and add it to
> `mm-charset-synonym-alist'.

I see.  Otherwise, it might not be necessary that a variable has
ones like `(iso8859-1 . iso-8859-1)' since such ones are able to
be corrected easily by a hard-wired program.

> BTW, if former defvars are changed to defcustoms, the :version is the
> one when it's made customizable, not when the defvar was introduced.
> So ":version "21.1" is not correct.

I must keep it in mind.  Thank you.  Anyway, I've made
`mm-charset-synonym-alist' revert to using `defvar'.

Regards,



  reply	other threads:[~2007-04-26 22:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-25 15:44 nail uses iso8859-1 instead of iso-8859-1 NAKAJI Hiroyuki
2007-04-25 23:06 ` Katsumi Yamaoka
2007-04-26 19:44   ` customizing mm-charset-synonym-alist (was: nail uses iso8859-1 instead of iso-8859-1) Reiner Steib
2007-04-26 22:42     ` Katsumi Yamaoka [this message]
2007-05-01 16:01 ` nail uses iso8859-1 instead of iso-8859-1 Reiner Steib

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4mwszydafr.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).