change in open-tls-stream, jabber does not work any longer

change in open-tls-stream, jabber does not work any longer

[Uwe Brauer]

Hello

While jabber (emacs-jabber-0.7.1) worked fine for me in ngnus 0.6, 
it stopped working with ngnus.0.10, the reason seems to be a change in
the function 
  open-tls-stream

I attach the error message and ask what could I do?


Debugger entered--Lisp error: (error "Selecting deleted or non-existent buffer")
  open-tls-stream("jabber" " *-jabber-process-*" "talk.google.com" 5223)
  jabber-ssl-connect()
  jabber-connect()
  (lambda nil (interactive) (jabber-connect) (switch-to-buffer "*-jabber-*"))()
  call-interactively(jabber)
  recursive-edit()
  byte-code("..." [buffer-read-only noninteractive debugger-buffer middlestart debugger-args debugger-batch-max-lines pop-to-buffer debugger-mode debugger-setup-buffer count-lines 2 "...\n" message buffer-string kill-emacs debug backtrace-debug 3 t debugger-reenable "" nil recursive-edit standard-output] 3)
  debug(error (error "No recursive edit is in progress"))
  signal(error ("No recursive edit is in progress"))
  cerror("No recursive edit is in progress")
  apply(cerror "No recursive edit is in progress" nil)
  error("No recursive edit is in progress")
  #<compiled-function nil "...(15)" [recursion-depth 0 throw exit nil error "No recursive edit is in progress"] 3 679460 nil>()
  call-interactively(exit-recursive-edit)

Re: change in open-tls-stream, jabber does not work any longer

[Katsumi Yamaoka]

>>>>> Uwe Brauer wrote:

> While jabber (emacs-jabber-0.7.1) worked fine for me in ngnus 0.6,
> it stopped working with ngnus.0.10, the reason seems to be a change in
> the function
>   open-tls-stream

> I attach the error message and ask what could I do?

> Debugger entered--Lisp error: (error "Selecting deleted or non-existent buffer")
>   open-tls-stream("jabber" " *-jabber-process-*" "talk.google.com" 5223)
>   jabber-ssl-connect()
>   jabber-connect()
>   (lambda nil (interactive) (jabber-connect) (switch-to-buffer "*-jabber-*"))()
>   call-interactively(jabber)

Performing jabber again after loading tls.el (not tls.elc) will
make the cause of the problem more clearer.  (I'm ignorant of
jabber though.)

Re: change in open-tls-stream, jabber does not work any longer

[Uwe Brauer]

   >> Debugger entered--Lisp error: (error "Selecting deleted or non-existent buffer")
   >> open-tls-stream("jabber" " *-jabber-process-*" "talk.google.com" 5223)
   >> jabber-ssl-connect()
   >> jabber-connect()
   >> (lambda nil (interactive) (jabber-connect) (switch-to-buffer "*-jabber-*"))()
   >> call-interactively(jabber)

   > Performing jabber again after loading tls.el (not tls.elc) will
   > make the cause of the problem more clearer.  (I'm ignorant of
   > jabber though.)

I am not so sure, after loading the file and debug-on-error t


I obtain
--8<------------------------schnipp------------------------->8---

Debugger entered--Lisp error: (error "Selecting deleted or non-existent buffer")
  set-buffer(" *-jabber-process-*")
  (save-current-buffer (set-buffer buffer) (message "Opening TLS connection to `%s'..." host) (while (and ... ...) (message "Opening TLS connection with `%s'..." cmd) (let ... ... ... ... ...)) (when (and done ...) (setq done nil) (delete-process process)))
  (with-current-buffer buffer (message "Opening TLS connection to `%s'..." host) (while (and ... ...) (message "Opening TLS connection with `%s'..." cmd) (let ... ... ... ... ...)) (when (and done ...) (setq done nil) (delete-process process)))
  (let ((cmds tls-program) (use-temp-buffer ...) process cmd done) (if use-temp-buffer (setq buffer ...)) (with-current-buffer buffer (message "Opening TLS connection to `%s'..." host) (while ... ... ...) (when ... ... ...)) (message "Opening TLS connection to `%s'...%s" host (if done "done" "failed")) (when use-temp-buffer (if done ...) (kill-buffer buffer)) done)
  open-tls-stream("jabber" " *-jabber-process-*" "talk.google.com" 5223)
  jabber-ssl-connect()
  jabber-connect()
  (lambda nil (interactive) (jabber-connect) (switch-to-buffer "*-jabber-*"))()
  call-interactively(jabber)
--8<------------------------schnapp------------------------->8---


After loading the old tls jabber works again.

Uwe Brauer 

Re: change in open-tls-stream, jabber does not work any longer

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 738 bytes --]

>>>>> Uwe Brauer wrote:

>> Performing jabber again after loading tls.el (not tls.elc) will
>> make the cause of the problem more clearer.  (I'm ignorant of
>> jabber though.)

> I am not so sure, after loading the file and debug-on-error t

> I obtain
> --8<------------------------schnipp------------------------->8---

> Debugger entered--Lisp error: (error "Selecting deleted or non-existent buffer")
>   set-buffer(" *-jabber-process-*")
>   (save-current-buffer (set-buffer buffer) (message "Opening TLS connectio...
>   (with-current-buffer buffer (message "Opening TLS connection to `%s'..."...
[...]
>   open-tls-stream("jabber" " *-jabber-process-*" "talk.google.com" 5223)
>   jabber-ssl-connect()

I see.  The workaround is:


[-- Attachment #2: Type: application/emacs-lisp, Size: 311 bytes --]

[-- Attachment #3: Type: text/plain, Size: 515 bytes --]


emacs-jabber-0.7.1 passes the buffer name (that is only a string,
has not been created yet) as the second argument to `open-tls-stream'.
The reason the former `open-tls-stream' worked is that it directly
passed the buffer name to `start-process', that creates the buffer
even if it is only a string.  I believe the present one should be
fixed because it is mentioned in the doc-string:

BUFFER is the buffer (or buffer name) to associate with the process.
                     ^^^^^^^^^^^^^^^^
I'll do it later...

Re: change in open-tls-stream, jabber does not work any longer

[Uwe Brauer]

   > emacs-jabber-0.7.1 passes the buffer name (that is only a string,
   > has not been created yet) as the second argument to `open-tls-stream'.
   > The reason the former `open-tls-stream' worked is that it directly
   > passed the buffer name to `start-process', that creates the buffer
   > even if it is only a string.  I believe the present one should be
   > fixed because it is mentioned in the doc-string:

   > BUFFER is the buffer (or buffer name) to associate with the process.
   >                      ^^^^^^^^^^^^^^^^
   > I'll do it later...


It this now fixed in the recent ngnus version?


Uwe Brauer 

Re: change in open-tls-stream, jabber does not work any longer

[Katsumi Yamaoka]

>>>>> Uwe Brauer wrote:

>> emacs-jabber-0.7.1 passes the buffer name (that is only a string,
>> has not been created yet) as the second argument to `open-tls-stream'.
>> The reason the former `open-tls-stream' worked is that it directly
>> passed the buffer name to `start-process', that creates the buffer
>> even if it is only a string.  I believe the present one should be
>> fixed because it is mentioned in the doc-string:

>> BUFFER is the buffer (or buffer name) to associate with the process.
>>                      ^^^^^^^^^^^^^^^^
>> I'll do it later...

> It this now fixed in the recent ngnus version?

I've fixed it in the Emacs CVS trunk in July 18, and now it has
been merged to the Gnus CVS trunk (i.e. No Gnus) already.