From: Katsumi Yamaoka <yamaoka@jpl.org>
Subject: Re: message-cite-original and message-cite-original-without-signature
Date: Tue, 09 Aug 2005 15:49:33 +0900 [thread overview]
Message-ID: <b4my87bfvuq.fsf@jpl.org> (raw)
In-Reply-To: <873bpjej4e.fsf@pacem.orebokech.com>
>>>>> In <873bpjej4e.fsf@pacem.orebokech.com> Romain Francoise wrote:
> The `message-cite-original' and `message-cite-original-without-signature'
> functions are almost identical and have been since 1998. For some
> reason, they have never been merged. Is there a good reason for this?
> I'd like to merge the two in a worker function and make the original
> functions just call the new function with an arg to strip the signature
> or not, which would eradicate the code duplication. I can see two
> consequences:
> - it would break any advice people could have on them (do we support
> this?)
> - it would make m-c-o-w-s (heh) honor `mail-citation-hook' as well.
> Shall I go ahead?
While I don't seem to have a right to say anything since I'm not
using message-cite-* function, I think it would be nice to merge
them. (Your recent changes are very good. I came to want to
incorporate those ideas into the function I'm using. :)
next prev parent reply other threads:[~2005-08-09 6:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-09 6:09 Romain Francoise
2005-08-09 6:49 ` Katsumi Yamaoka [this message]
2005-08-13 15:07 ` Romain Francoise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4my87bfvuq.fsf@jpl.org \
--to=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).