From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/60734 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: Re: message-cite-original and message-cite-original-without-signature Date: Tue, 09 Aug 2005 15:49:33 +0900 Organization: Emacsen advocacy group Message-ID: References: <873bpjej4e.fsf@pacem.orebokech.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1123570266 31863 80.91.229.2 (9 Aug 2005 06:51:06 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 9 Aug 2005 06:51:06 +0000 (UTC) Original-X-From: ding-owner+M9265=ding+2Daccount=gmane.org@lists.math.uh.edu Tue Aug 09 08:51:03 2005 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1E2Nw0-0005e8-GN for ding-account@gmane.org; Tue, 09 Aug 2005 08:50:00 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1E2Nvz-00035Z-01 for ding-account@gmane.org; Tue, 09 Aug 2005 01:49:59 -0500 Original-Received: from util2.math.uh.edu ([129.7.128.23]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1E2Nvu-00035Q-00 for ding@lists.math.uh.edu; Tue, 09 Aug 2005 01:49:54 -0500 Original-Received: from quimby.gnus.org ([80.91.224.244]) by util2.math.uh.edu with esmtp (Exim 4.30) id 1E2Nvq-0006eT-HB for ding@lists.math.uh.edu; Tue, 09 Aug 2005 01:49:50 -0500 Original-Received: from washington.hostforweb.net ([66.225.201.13]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1E2Mzl-00057G-00 for ; Tue, 09 Aug 2005 07:49:49 +0200 Original-Received: from localhost.servershost.net ([127.0.0.1] helo=localhost) by washington.hostforweb.net with esmtpa (Exim 4.50) id 1E2Nvy-0002EA-21 for ding@gnus.org; Tue, 09 Aug 2005 01:49:58 -0500 Original-To: ding@gnus.org X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) Cancel-Lock: sha1:YkiLox0/D1jXVPu2yke/byKqKfY= X-Hashcash: 1:20:050809:ding@gnus.org::6KeX0mMMe9bE+iME:0000Dhl9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - washington.hostforweb.net X-AntiAbuse: Original Domain - gnus.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -3.5 (---) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:60734 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:60734 >>>>> In <873bpjej4e.fsf@pacem.orebokech.com> Romain Francoise wrote: > The `message-cite-original' and `message-cite-original-without-signature' > functions are almost identical and have been since 1998. For some > reason, they have never been merged. Is there a good reason for this? > I'd like to merge the two in a worker function and make the original > functions just call the new function with an arg to strip the signature > or not, which would eradicate the code duplication. I can see two > consequences: > - it would break any advice people could have on them (do we support > this?) > - it would make m-c-o-w-s (heh) honor `mail-citation-hook' as well. > Shall I go ahead? While I don't seem to have a right to say anything since I'm not using message-cite-* function, I think it would be nice to merge them. (Your recent changes are very good. I came to want to incorporate those ideas into the function I'm using. :)