Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: Andrew Cohen <cohen@andy.bu.edu>
Cc: ding@gnus.org
Subject: Re: nnir and move
Date: Mon, 15 Nov 2010 11:40:49 +0900	[thread overview]
Message-ID: <b4mzktbpavi.fsf@jpl.org> (raw)
In-Reply-To: <87fwv9t2pr.fsf@andy.bu.edu>

Hi,

2010-11-11  Andrew Cohen  <cohen@andy.bu.edu>
[...]
 * gnus-sum.el (gnus-summary-move-article): Use original group and
 subject for virtual articles such as those in an nnir summary buffer.

This change broke the function of copying or moving two or more
articles.  When typing `B c' for marked articles in a group, I got:

Debugger entered--Lisp error: (error "Selecting deleted buffer")
  gnus-summary-move-article(nil nil nil copy)
  gnus-summary-copy-article(nil)
  call-interactively(gnus-summary-copy-article nil nil)

It is because of the present structure of `while' loop:

  (let ((copy-buf (save-excursion
                    (nnheader-set-temp-buffer " *copy article*"))))
    ...
    (while articles
      ....
      (gnus-kill-buffer copy-buf)))

It was:

  (let ((copy-buf (save-excursion
                    (nnheader-set-temp-buffer " *copy article*"))))
    ...
    (while articles
      ....)
    (gnus-kill-buffer copy-buf))

I've fixed it in the git repo.  Could you check whether my change
didn't break what you intended?

Regards,



  reply	other threads:[~2010-11-15  2:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-31 14:07 Richard Riley
2010-10-31 17:18 ` Lars Magne Ingebrigtsen
2010-11-01  4:20   ` Richard Riley
2010-11-01 12:04   ` Andrew Cohen
2010-11-01 12:08     ` Lars Magne Ingebrigtsen
2010-11-01 12:13       ` Andrew Cohen
2010-11-01 14:28         ` Andrew Cohen
2010-11-01 14:51           ` Andrew Cohen
2010-11-09 22:05             ` Ted Zlatanov
2010-11-10 16:40               ` Andrew Cohen
2010-11-10 16:55                 ` Ted Zlatanov
2010-11-10 18:42                   ` Andrew Cohen
2010-11-10 18:54                     ` Ted Zlatanov
2010-11-10 19:09                       ` Andrew Cohen
2010-11-15  2:40                         ` Katsumi Yamaoka [this message]
2010-11-15  2:53                           ` Andrew Cohen
2010-12-01 14:13               ` Andrew Cohen
2010-12-01 17:01                 ` Lars Magne Ingebrigtsen
2010-12-01 17:47                   ` Andrew Cohen
2010-12-01 17:50                     ` Lars Magne Ingebrigtsen
2010-12-01 22:01                       ` Andrew Cohen
2010-12-14 23:36                         ` Ted Zlatanov
2010-11-03  1:05 Andrew Cohen
2010-11-03 12:17 ` Richard Riley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4mzktbpavi.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=cohen@andy.bu.edu \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).