Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: ding@gnus.org
Subject: `B r' doesn't work
Date: Tue, 21 Sep 2010 13:56:56 +0900	[thread overview]
Message-ID: <b4mzkvbwv6v.fsf_-_@jpl.org> (raw)
In-Reply-To: <E1OwdeG-0002R5-00@quimby.gnus.org>

Lars Magne Ingebrigtsen wrote:
> commit df6ac45b952171e7e709c1b0bf23cc7346429f81
> Author: Lars Magne Ingebrigtsen <larsi@quimbies.gnus.org>
> Date:   Fri Sep 17 18:18:39 2010 +0200
[...]
>     * gnus-sum.el (gnus-summary-move-article): Pass the move-to group name
>     if the move is internal, so that nnimap can do fast internal moves.
[...]
> diff --git a/lisp/gnus-sum.el b/lisp/gnus-sum.el
> index df20456..c8c4a1c 100644
> --- a/lisp/gnus-sum.el
> +++ b/lisp/gnus-sum.el
> @@ -9690,7 +9690,8 @@ ACTION can be either `move' (the default), `crosspost' or `copy'."
>                   to-newsgroup (list 'quote select-method)
>                   (not articles) t)     ; Accept form
>             (not articles)              ; Only save nov last time
> -           move-is-internal)))         ; is this move internal?
> +           (and move-is-internal
> +                (gnus-group-real-name to-newsgroup))))) ; is this move internal?

It seems to have to be:

 (and move-is-internal
      to-newsgroup
      (gnus-group-real-name to-newsgroup))))) ; is this move internal?

Because `to-newsgroup' is nil if this function runs by way of
`gnus-summary-respool-article' (i.e. `B r').  I got this error
when respooling articles in nnml groups:

Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  string-match("^[^:]+:" nil)
  gnus-summary-move-article(nil nil (nnml ""))
  gnus-summary-respool-article(nil (nnml ""))
  call-interactively(gnus-summary-respool-article nil nil)



       reply	other threads:[~2010-09-21  4:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1OwdeG-0002R5-00@quimby.gnus.org>
2010-09-21  4:56 ` Katsumi Yamaoka [this message]
2010-09-21 16:00   ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4mzkvbwv6v.fsf_-_@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).