Re: Recentering during article scrolling with scroll-margin

[Katsumi Yamaoka <yamaoka@jpl.org>]

[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

>>>>> Ralf Angeli wrote:
> the handling of `scroll-margin' has recently changed a bit in Emacs CVS
> and recentering seems to happen more agressively now.  This becomes a
> problem if `scroll-margin' is greater than 0 and one is scrolling an
> article with <RET>.  When the bottom of the article is reached the last
> line will not stay at the bottom of the window but jump to the middle of
> it.

> The recentering is triggered by the statement
> (move-to-window-line -1)
> in `gnus-article-next-page'.  It is usually countered by
> `gnus-article-next-page-1', but not at the end of an article where the
> latter function will not be called.

> The problem can be circumvented by changing the above statement to
> (move-to-window-line (- -1 scroll-margin))

I tried (setq scroll-margin 3) on the latest Emacs 22.0.50 and
23.0.60 and confirmed this fix is necessary for the case where
`gnus-article-over-scroll' is nil (the default).

> If necessary I can provide a change log entry for such a change.

Please provide it and I'll commit the slightly modified one like:


[-- Attachment #2: Type: application/emacs-lisp, Size: 70 bytes --]

[-- Attachment #3: Type: text/plain, Size: 607 bytes --]


(Note that there is no `scroll-margin' control in XEmacs.)

BTW, another problem related to `scroll-margin' seems to have
been solved in the latest Emacs 22.0.50 and 23.0.60:

>>>>> In <b4m4pbs7c2e.fsf@jpl.org> Katsumi Yamaoka wrote:
> The problem is, in short, that the cursor in the Gnus summary
> buffer jumps to a subject line that is not for the article being
> displayed just after selecting the article by the `g' command, if
> `scroll-margin' is a non-zero value (actually it is 3).  You may
> need to have many articles in threads and to expand the summary
> window to a certain height.

Regards,