Re: Scoring out of bounds

[Katsumi Yamaoka <yamaoka@jpl.org>]

>>>>> In <vz3cd7c6bu.fsf@redqueen.bytechase.cx>
>>>>>	Norbert Koch <viteno@xemacs.org> wrote:

>> Something's pushing scores up too high (my bad), but maybe it should
>> be bound in gnus-decay-score to prevent such errors?

> Here's a possible fix

> --- gnus-score.el	13 Aug 2003 16:34:46 -0000	6.35
> +++ gnus-score.el	2 Nov 2003 12:14:46 -0000
> @@ -2918,13 +2918,15 @@

>  (defun gnus-decay-score (score)
>    "Decay SCORE according to `gnus-score-decay-constant' and `gnus-score-decay-scale'."
> -  (floor
> -   (- score
> -      (* (if (< score 0) -1 1)
> -	 (min (abs score)
> -	      (max gnus-score-decay-constant
> -		   (* (abs score)
> -		      gnus-score-decay-scale)))))))
> +  (condition-case nil
> +      (floor
> +       (- score
> +	  (* (if (< score 0) -1 1)
> +	     (min (abs score)
> +		  (max gnus-score-decay-constant
> +		       (* (abs score)
> +			  gnus-score-decay-scale))))))
> +    (arith-error most-positive-fixnum)))

I've committed it with a slight modification[1].  Thanks.
BTW, isn't it an XEmacs bug?  Emacs's floor can handle the value
of an argument that it returns the maximum integer:

(floor (+ (lsh -1 -1) 0.999))
 => 134217727

[1] The most-positive-fixnum variable is not always available in
21.3 or older versions of Emacs since it is defined in cl.el.
-- 
Katsumi Yamaoka <yamaoka@jpl.org>