Gnus development mailing list
 help / color / mirror / Atom feed
* compile warning with spam-report.el
@ 2004-02-24 23:54 Katsumi Yamaoka
  2004-02-26 16:18 ` Ted Zlatanov
  0 siblings, 1 reply; 2+ messages in thread
From: Katsumi Yamaoka @ 2004-02-24 23:54 UTC (permalink / raw)


Hi,

Shouldn't the following symbols be quoted?

While compiling spam-report-plug-agent in file gnus/lisp/spam-report.el:
  ** reference to free variable spam-report-url-to-file
  ** reference to free variable spam-report-url-ping-plain

--- spam-report.el~	2004-02-24 21:53:48 +0000
+++ spam-report.el	2004-02-24 23:53:25 +0000
@@ -221,13 +221,13 @@
   ;; Process the queue, unless the user only wanted to report to a file
   ;; anyway.
   (unless (equal spam-report-url-ping-temp-agent-function
-		 spam-report-url-to-file)
+		 'spam-report-url-to-file)
     (spam-report-process-queue))
   ;; Set the reporting function, if we have memorized something otherwise,
   ;; stick with plain URL reporting.
   (setq spam-report-url-ping-function
 	(or spam-report-url-ping-temp-agent-function
-	    spam-report-url-ping-plain)))
+	    'spam-report-url-ping-plain)))
 
 (defun spam-report-unplug-agent ()
   "Restore spam report settings for unplugged state."
-- 
Katsumi Yamaoka <yamaoka@jpl.org>



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: compile warning with spam-report.el
  2004-02-24 23:54 compile warning with spam-report.el Katsumi Yamaoka
@ 2004-02-26 16:18 ` Ted Zlatanov
  0 siblings, 0 replies; 2+ messages in thread
From: Ted Zlatanov @ 2004-02-26 16:18 UTC (permalink / raw)
  Cc: ding

On Wed, 25 Feb 2004, yamaoka@jpl.org wrote:

> Hi,
> 
> Shouldn't the following symbols be quoted?
> 
> While compiling spam-report-plug-agent in file
> gnus/lisp/spam-report.el: ** reference to free variable
> spam-report-url-to-file ** reference to free variable
> spam-report-url-ping-plain

Absolutely, thanks for catching that.  Go ahead and commit or I can do
it.

Thanks
Ted



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-02-26 16:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-24 23:54 compile warning with spam-report.el Katsumi Yamaoka
2004-02-26 16:18 ` Ted Zlatanov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).