From: Katsumi Yamaoka <yamaoka@jpl.org>
Subject: Re: In gnus-sum.el: Incorrect handling of sparse articles
Date: Mon, 15 Mar 2004 21:34:27 +0900 [thread overview]
Message-ID: <b9yish6qofg.fsf@jpl.org> (raw)
In-Reply-To: <87hdwqe657.fsf@xenon.eswe.dyndns.org>
>>>>> In <87hdwqe657.fsf@xenon.eswe.dyndns.org>
>>>>> Stefan Wiens <s.wi@gmx.net> wrote:
>> in gnus-sum.el, function gnus-read-header:
>>
>> ;; If this is a sparse article, we have to nix out its
>> ;; previous entry in the thread hashtb.
>> (when (and header
>> (gnus-summary-article-sparse-p (mail-header-number header)))
>> (let* ((parent (gnus-parent-id (mail-header-references header)))
>> (thread (and parent (gnus-id-to-thread parent))))
>> (when thread
>> (delq (assq header thread) thread))))
> That code was introduced on Nov 24, 1997 (no CVS comment).
It appeared in qgnus-0.16 and the ChangeLog entry is in qgnus-0.18.
Wed Nov 26 18:19:29 1997 Lars Magne Ingebrigtsen <larsi@ifi.uio.no>
[...]
* gnus-sum.el (gnus-read-header): Would bug out on sparse
articles.
I saw it just breaks a thread.
> The damage gnus-read-header does to gnus-newsgroup-dependencies was
> probably exposed by:
> ,----[ ChangeLog ]
>|
>| 2002-02-21 ShengHuo ZHU <zsh@cs.rochester.edu>
>| [...]
>| * gnus-sum.el (gnus-dependencies-add-header): If replaced, don't
>| rebuild.
>| (gnus-summary-edit-article-done): Gnus-get-newsgroup-headers takes
>| nil as dependencies as well.
> `----
> Next day, on Feb 22, 2002, first reporting of
> `This is a pseudo-article' errors after upgrading.
> (gnus.ding <m3n0y118jv.fsf@neo.loria>)
>> I am currently testing with the offending code (cited above) commented
>> out, and everything seems to work fine.
> Still works. IMHO the code section should simply be removed.
> Stefan
I've simply removed it. Although we may get a new bug report
next day...
--
Katsumi Yamaoka <yamaoka@jpl.org>
prev parent reply other threads:[~2004-03-15 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-14 13:05 Stefan Wiens
2004-03-15 10:50 ` Stefan Wiens
2004-03-15 12:34 ` Katsumi Yamaoka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9yish6qofg.fsf@jpl.org \
--to=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).