From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/56738 Path: main.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: Re: In gnus-sum.el: Incorrect handling of sparse articles Date: Mon, 15 Mar 2004 21:34:27 +0900 Organization: Emacsen advocacy group Sender: ding-owner@lists.math.uh.edu Message-ID: References: <871xnvh94z.fsf@xenon.eswe.dyndns.org> <87hdwqe657.fsf@xenon.eswe.dyndns.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1079354119 1095 80.91.224.253 (15 Mar 2004 12:35:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 15 Mar 2004 12:35:19 +0000 (UTC) Original-X-From: ding-owner+M5277@lists.math.uh.edu Mon Mar 15 13:35:12 2004 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1B2rJI-0003DJ-00 for ; Mon, 15 Mar 2004 13:35:12 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1B2rIk-0007qI-00; Mon, 15 Mar 2004 06:34:39 -0600 Original-Received: from justine.libertine.org ([66.139.78.221] ident=postfix) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1B2rIg-0007qD-00 for ding@lists.math.uh.edu; Mon, 15 Mar 2004 06:34:34 -0600 Original-Received: from washington.hostforweb.net (washington.hostforweb.net [69.61.11.2]) by justine.libertine.org (Postfix) with ESMTP id 2ED683A003B for ; Mon, 15 Mar 2004 06:34:34 -0600 (CST) Original-Received: from yamaoka by washington.hostforweb.net with local (Exim 4.24) id 1B2rIf-0000LC-2n for ding@gnus.org; Mon, 15 Mar 2004 07:34:33 -0500 Original-To: ding@gnus.org X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) Cancel-Lock: sha1:z0Xsd+IhCwulnvZ9hBt9Ku2GxCc= X-Hashcash: 0:040315:ding@gnus.org:39dfb864d7d97636 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - washington.hostforweb.net X-AntiAbuse: Original Domain - gnus.org X-AntiAbuse: Originator/Caller UID/GID - [32041 32041] / [47 12] X-AntiAbuse: Sender Address Domain - washington.hostforweb.net Precedence: bulk Xref: main.gmane.org gmane.emacs.gnus.general:56738 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:56738 >>>>> In <87hdwqe657.fsf@xenon.eswe.dyndns.org> >>>>> Stefan Wiens wrote: >> in gnus-sum.el, function gnus-read-header: >> >> ;; If this is a sparse article, we have to nix out its >> ;; previous entry in the thread hashtb. >> (when (and header >> (gnus-summary-article-sparse-p (mail-header-number header))) >> (let* ((parent (gnus-parent-id (mail-header-references header))) >> (thread (and parent (gnus-id-to-thread parent)))) >> (when thread >> (delq (assq header thread) thread)))) > That code was introduced on Nov 24, 1997 (no CVS comment). It appeared in qgnus-0.16 and the ChangeLog entry is in qgnus-0.18. Wed Nov 26 18:19:29 1997 Lars Magne Ingebrigtsen [...] * gnus-sum.el (gnus-read-header): Would bug out on sparse articles. I saw it just breaks a thread. > The damage gnus-read-header does to gnus-newsgroup-dependencies was > probably exposed by: > ,----[ ChangeLog ] >| >| 2002-02-21 ShengHuo ZHU >| [...] >| * gnus-sum.el (gnus-dependencies-add-header): If replaced, don't >| rebuild. >| (gnus-summary-edit-article-done): Gnus-get-newsgroup-headers takes >| nil as dependencies as well. > `---- > Next day, on Feb 22, 2002, first reporting of > `This is a pseudo-article' errors after upgrading. > (gnus.ding ) >> I am currently testing with the offending code (cited above) commented >> out, and everything seems to work fine. > Still works. IMHO the code section should simply be removed. > Stefan I've simply removed it. Although we may get a new bug report next day... -- Katsumi Yamaoka