From: Katsumi Yamaoka <yamaoka@jpl.org>
Subject: Re: rfc2231.el changes
Date: Thu, 13 Apr 2006 09:37:57 +0900 [thread overview]
Message-ID: <b9ylkua1fa2.fsf@jpl.org> (raw)
In-Reply-To: <v9u08z6jrm.fsf_-_@marauder.physik.uni-ulm.de>
>>>>> In <v9u08z6jrm.fsf_-_@marauder.physik.uni-ulm.de>
>>>>> Reiner Steib <reinersteib+gmane@imap.cc> wrote:
> On Wed, Apr 12 2006, Katsumi Yamaoka wrote:
>> In addition, I've merged the changes to rfc2231.el that Kenichi
>> Handa made in the Emacs CVS.
> [...]
>> * trunk and v5-10 branch *
> I've adjusted the corresponding ChangeLog entries (date, ...) which
> were a bit messed up.
Thanks.
> The versions of `rfc2231.el' in v5-10 and Emacs are in sync now.
> However there are two differences to the trunk version. vc-annotate
> shows that you worked on this code (on 16-Feb-06). Could you sync the
> code if appropriate, please? Hm, maybe it's because older Emacsen
> don't support shy groups correctly?
> --- rfc2231.el 12 Apr 2006 02:00:40 -0000 6.11.2.14
> +++ rfc2231.el 12 Apr 2006 02:00:49 -0000 7.15
[...]
> - (string-match "\\`\\(\\([^']+\\)?'\\([^']+\\)?'\\)?\\(.+\\)" string)
> - (let ((coding-system (mm-charset-to-coding-system (match-string 2 string)))
> - ;;(language (match-string 3 string))
> - (value (match-string 4 string)))
> + (string-match "\\`\\(?:\\([^']+\\)?'\\([^']+\\)?'\\)?\\(.+\\)" string)
> + (let ((coding-system (mm-charset-to-coding-system (match-string 1 string)))
> + ;;(language (match-string 2 string))
> + (value (match-string 3 string)))
[...]
Yes, Emacs 20 doesn't support shy groups. Well, should we not
use shy groups in all Gnus modules (even in the trunk)? Such
differences I made are not only in rfc2231.el but also in the
other modules, e.g., rfc2047.el. I'm not very much positive to
remove them even if a lowering of performance by not using shy
groups is a little. If anything, isn't it better to drop Emacs
20?
next prev parent reply other threads:[~2006-04-13 0:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-17 10:43 Improve handling of message/external-body Katsumi Yamaoka
2006-04-12 2:01 ` Katsumi Yamaoka
2006-04-12 12:49 ` rfc2231.el changes (was: Improve handling of message/external-body) Reiner Steib
2006-04-13 0:37 ` Katsumi Yamaoka [this message]
2006-04-13 5:45 ` rfc2231.el changes Lars Magne Ingebrigtsen
2006-04-13 16:25 ` Emacs 20.7 compatibility in v5-10 (was: rfc2231.el changes) Reiner Steib
2006-04-13 16:39 ` Emacs 20.7 compatibility in v5-10 Lars Magne Ingebrigtsen
2006-04-13 17:45 ` Reiner Steib
2006-04-13 18:31 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9ylkua1fa2.fsf@jpl.org \
--to=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).