From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/62695 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: Re: rfc2231.el changes Date: Thu, 13 Apr 2006 09:37:57 +0900 Organization: Emacsen advocacy group Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1144888887 4827 80.91.229.2 (13 Apr 2006 00:41:27 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 13 Apr 2006 00:41:27 +0000 (UTC) Original-X-From: ding-owner+m11222@lists.math.uh.edu Thu Apr 13 02:41:25 2006 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FTptl-0007qn-7g for ding-account@gmane.org; Thu, 13 Apr 2006 02:41:25 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1FTptc-0004yZ-00; Wed, 12 Apr 2006 19:41:16 -0500 Original-Received: from nas01.math.uh.edu ([129.7.128.39]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1FTpqp-0004yU-00 for ding@lists.math.uh.edu; Wed, 12 Apr 2006 19:38:23 -0500 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas01.math.uh.edu with esmtp (Exim 4.52) id 1FTpqk-0006N3-Qu for ding@lists.math.uh.edu; Wed, 12 Apr 2006 19:38:23 -0500 Original-Received: from washington.hostforweb.net ([66.225.201.13]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1FTpqj-0000PQ-00 for ; Thu, 13 Apr 2006 02:38:17 +0200 Original-Received: from [205.234.185.198] (port=49958 helo=mail.jpl.org) by washington.hostforweb.net with esmtpa (Exim 4.52) id 1FTpsw-0005dn-M1 for ding@gnus.org; Wed, 12 Apr 2006 19:40:34 -0500 Original-To: ding@gnus.org X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110005 (No Gnus v0.5) Emacs/22.0.50 (usg-unix-v) Cancel-Lock: sha1:3DxC02mUgPIrvj/YK6JrsjtvBr4= X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - washington.hostforweb.net X-AntiAbuse: Original Domain - gnus.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -2.6 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:62695 Archived-At: >>>>> In >>>>> Reiner Steib wrote: > On Wed, Apr 12 2006, Katsumi Yamaoka wrote: >> In addition, I've merged the changes to rfc2231.el that Kenichi >> Handa made in the Emacs CVS. > [...] >> * trunk and v5-10 branch * > I've adjusted the corresponding ChangeLog entries (date, ...) which > were a bit messed up. Thanks. > The versions of `rfc2231.el' in v5-10 and Emacs are in sync now. > However there are two differences to the trunk version. vc-annotate > shows that you worked on this code (on 16-Feb-06). Could you sync the > code if appropriate, please? Hm, maybe it's because older Emacsen > don't support shy groups correctly? > --- rfc2231.el 12 Apr 2006 02:00:40 -0000 6.11.2.14 > +++ rfc2231.el 12 Apr 2006 02:00:49 -0000 7.15 [...] > - (string-match "\\`\\(\\([^']+\\)?'\\([^']+\\)?'\\)?\\(.+\\)" string) > - (let ((coding-system (mm-charset-to-coding-system (match-string 2 string))) > - ;;(language (match-string 3 string)) > - (value (match-string 4 string))) > + (string-match "\\`\\(?:\\([^']+\\)?'\\([^']+\\)?'\\)?\\(.+\\)" string) > + (let ((coding-system (mm-charset-to-coding-system (match-string 1 string))) > + ;;(language (match-string 2 string)) > + (value (match-string 3 string))) [...] Yes, Emacs 20 doesn't support shy groups. Well, should we not use shy groups in all Gnus modules (even in the trunk)? Such differences I made are not only in rfc2231.el but also in the other modules, e.g., rfc2047.el. I'm not very much positive to remove them even if a lowering of performance by not using shy groups is a little. If anything, isn't it better to drop Emacs 20?