Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
Subject: Re: *nntp-log* differences between M-g and g
Date: Mon, 31 Jan 2005 21:49:15 +0900	[thread overview]
Message-ID: <b9ymzup69x0.fsf@jpl.org> (raw)
In-Reply-To: <b9yd5vmmpki.fsf@jpl.org>

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

>>>>> In <b9yd5vmmpki.fsf@jpl.org> Katsumi Yamaoka wrote:

>>>>>> In <ilu1xc2xyr9.fsf@latte.josefsson.org> Simon Josefsson wrote:

>> Why exactly does g have to issue two GROUP commands for the same
>> group?

>> And should 'g' really need to mess with the marks, except for
>> extending the active range?  Doesn't GROUP give Gnus enough
>> information to do that?

> That's a good point.  It is just an item to which the nntp marks
> should be improved.

The reason two GROUP commands issued when typing `g' is that
nntp.el provides the `nntp-request-update-info' function which
returns non-nil.  Because of this,
gnus-get-unread-articles-in-group calls nntp-request-group which
issues the GROUP command by way of gnus-activate-group.  I think
to issue those commands is of no use to manage the nntp marks.
The patch below avoids those futilities.  Could anyone test it?
I hope the people who are using the nntp marks in daily life
test it.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 253 bytes --]

--- nntp.el~	2004-11-15 03:59:37 +0000
+++ nntp.el	2005-01-31 12:47:01 +0000
@@ -1074,7 +1074,7 @@
 				(list (cons (car seen) (car seen)))
 			      seen)))
       (nnheader-message 8 "Updating marks for %s...done" group))
-    info))
+    nil))
 
 
 

[-- Attachment #3: Type: text/plain, Size: 9 bytes --]

Regards,

  reply	other threads:[~2005-01-31 12:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-30 17:42 Mark Plaksin
2005-01-30 23:28 ` Katsumi Yamaoka
2005-01-30 23:50   ` Simon Josefsson
2005-01-31  0:04     ` Katsumi Yamaoka
2005-01-31 12:49       ` Katsumi Yamaoka [this message]
2005-01-31 22:09         ` Mark Plaksin
2005-02-01 11:30         ` Katsumi Yamaoka
2005-02-02  8:00         ` Ralf Angeli
2005-02-02  9:42           ` Simon Josefsson
2005-02-02 11:38             ` Katsumi Yamaoka
2005-02-03  0:39               ` Katsumi Yamaoka
2005-02-03  9:04                 ` Ralf Angeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9ymzup69x0.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).