gnus-util.el loads rmail

gnus-util.el loads rmail

[Katsumi Yamaoka]

Hi,

Steve Youngs applied your patch to gnus-util.el with the
following ChangeLog entry:

	* gnus-util.el: Get rmail definitions when compiling.
	From Jerry James <james@xemacs.org>.

I am opposed to it.  In XEmacs, since rmail is supplied by the
package, there may be those who have not installed it.
Furthermore, since rmail of the XEmacs version uses tm and also
apel, that packages are also required for it (rmail.el requires
tm-view, tm-view requires std11 which is in apel).  It became
impossible therefore, for such people to build Gnus.

Loading of rmail is only for the `rmail-select-summary' macro,
isn't it?  If so, it can be solved by not compiling that section:

--- gnus-util.el~	2003-12-03 23:28:53 +0000
+++ gnus-util.el	2003-12-05 00:44:47 +0000
@@ -864,8 +864,9 @@
 	      (narrow-to-region (point) (point-max))
 	      (rmail-count-new-messages t)
 	      (when (rmail-summary-exists)
-		(rmail-select-summary
-		 (rmail-update-summary)))
+		(dont-compile
+		  (rmail-select-summary
+		   (rmail-update-summary))))
 	      (rmail-count-new-messages t)
 	      (rmail-show-message msg))
 	    (save-buffer)))))

How about it?  I wish you give aid to the users of minorities
who don't need rmail.

Regards,
-- 
Katsumi Yamaoka <yamaoka@jpl.org>

Re: gnus-util.el loads rmail

[Steve Youngs]

[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]

|--==> "KY" == Katsumi Yamaoka <yamaoka@jpl.org> writes:

  KY> Loading of rmail is only for the `rmail-select-summary' macro,
  KY> isn't it?  If so, it can be solved by not compiling that section:

  KY> --- gnus-util.el~	2003-12-03 23:28:53 +0000
  KY> +++ gnus-util.el	2003-12-05 00:44:47 +0000
  KY> @@ -864,8 +864,9 @@
  KY>  	      (narrow-to-region (point) (point-max))
  KY>  	      (rmail-count-new-messages t)
  KY>  	      (when (rmail-summary-exists)
  KY> -		(rmail-select-summary
  KY> -		 (rmail-update-summary)))
  KY> +		(dont-compile
  KY> +		  (rmail-select-summary
  KY> +		   (rmail-update-summary))))
  KY>  	      (rmail-count-new-messages t)
  KY>  	      (rmail-show-message msg))
  KY>  	    (save-buffer)))))

  KY> How about it?

So this would be as a replacement to Jerry's patch or in addition to
it? 

And the doc string from `dont-compile' troubles me a little...

,----[ C-h f dont-compile RET ]
| `dont-compile' is a compiled Lisp macro
|   -- loaded from "/usr/local/lib/xemacs-21.4.14/lisp/bytecomp-runtime.elc"
| (dont-compile &rest BODY)
| 
| Documentation:
| Like `progn', but the body always runs interpreted (not compiled).
| If you think you need this, you're probably making a mistake somewhere.
`----

...that last line in particular.

-- 
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
|              Ashes to ashes, dust to dust.               |
|      The proof of the pudding, is under the crust.       |
|------------------------------<sryoungs@bigpond.net.au>---|

[-- Attachment #2: Type: application/pgp-signature, Size: 256 bytes --]

Re: gnus-util.el loads rmail

[Katsumi Yamaoka]

>>>>> In <microsoft-free.87wu9cawe9.fsf@eicq.dnsalias.org>
>>>>>	Steve Youngs <sryoungs@bigpond.net.au> wrote:

KY> Loading of rmail is only for the `rmail-select-summary' macro,
KY> isn't it?  If so, it can be solved by not compiling that section:

[...]

KY> How about it?

> So this would be as a replacement to Jerry's patch or in addition to
> it?

No, that's only for explaining my idea.  Maybe, it should be
performed to gnus-util.el before you change.  If you allow, I
need to do work.

> And the doc string from `dont-compile' troubles me a little...

[...]

>| If you think you need this, you're probably making a mistake somewhere.

> ...that last line in particular.

About the case where `eval' is used in the Lisp source, there
was a similar description in very old Info documents.
`dont-compile' is an another expression of `eval' and `quote':

(macroexpand '(dont-compile FORM))
 => (eval (quote FORM))

It is used in order to express the purpose more clearly.
Besides making the operation slow a bit, there is no problem.
-- 
Katsumi Yamaoka <yamaoka@jpl.org>

Re: gnus-util.el loads rmail

[Steve Youngs]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

Jerry!

Where are you?  I'm waiting to here from you on this.


-- 
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
|        XEmacs - The only _______ you'll ever need.       |
|          Fill in the blank, yes, it's THAT good!         |
|------------------------------<sryoungs@bigpond.net.au>---|

[-- Attachment #2: Type: application/pgp-signature, Size: 256 bytes --]

Re: gnus-util.el loads rmail

[Katsumi Yamaoka]

>>>>> In <microsoft-free.8765gswf1l.fsf@eicq.dnsalias.org>
>>>>>	Steve Youngs <sryoungs@bigpond.net.au> wrote:

> Jerry!

> Where are you?  I'm waiting to here from you on this.

I've modified gnus-util.el in the following way:

  Require rmail.  If it isn't available, provide the compiler
  macro which doesn't `funcall' the rmail-select-summary macro,
  but eval the quoted `(rmail-select-summary BODY)' form.

The results are:

  Those who have rmail installed get fully compiled Gnus.
  Others who don't have the rmail XEmacs package installed also
  get almost compiled Gnus and they can use rmail functions of
  Gnus if they install rmail (and also tm and APEL) later.

I've confirmed them.  Please test.
-- 
Katsumi Yamaoka <yamaoka@jpl.org>

Re: gnus-util.el loads rmail

[Steve Youngs]

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

|--==> "KY" == Katsumi Yamaoka <yamaoka@jpl.org> writes:

  KY> I've modified gnus-util.el in the following way:

  KY>   Require rmail.  If it isn't available, provide the compiler
  KY>   macro which doesn't `funcall' the rmail-select-summary macro,
  KY>   but eval the quoted `(rmail-select-summary BODY)' form.

I like it!

Thank you very much for helping out on this, Katsumi.  I really
appreciate it.

I'll apply these changes to the XEmacs Gnus package shortly.

-- 
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
|        XEmacs - The only _______ you'll ever need.       |
|          Fill in the blank, yes, it's THAT good!         |
|------------------------------<sryoungs@bigpond.net.au>---|

[-- Attachment #2: Type: application/pgp-signature, Size: 256 bytes --]

Re: gnus-util.el loads rmail

[Katsumi Yamaoka]

>>>>> In <microsoft-free.87u14ckkqx.fsf@eicq.dnsalias.org>
>>>>>	Steve Youngs <sryoungs@bigpond.net.au> wrote:

> I'll apply these changes to the XEmacs Gnus package shortly.

Thanks!

I found another problem, although it is not serious.  If there
is the rmail but there is no tm (or there is apel of the
mainstream, not the XEmacs version), loading of rmail fails
halfway, but the macro in question is provided.  In that case,
the byte-compiler warns about two rmail functions.  So, I've
changed Gnus cvs to bind those functions when compiling.

A patch for the XEmacs package is below.  However, please ignore
it if you consider it is not necessary.

--- gnus-util.el~	2003-12-08 07:40:41 +0000
+++ gnus-util.el	2003-12-08 08:55:35 +0000
@@ -808,7 +808,13 @@
        ;; requires tm and apel packages.  However, there may be those
        ;; who haven't installed those packages.  This macro helps such
        ;; people even if they install those packages later.
-       `(eval '(rmail-select-summary ,@body)))))
+       `(eval '(rmail-select-summary ,@body)))
+     ;; If there's rmail but there's no tm (or there's apel of the
+     ;; mainstream, not the XEmacs version), loading rmail of the XEmacs
+     ;; version fails halfway, however it provides the rmail-select-summary
+     ;; macro which uses the following functions:
+     (autoload 'rmail-summary-displayed "rmail")
+     (autoload 'rmail-maybe-display-summary "rmail")))
   (defvar rmail-default-rmail-file)
   (defvar mm-text-coding-system))
 
-- 
Katsumi Yamaoka <yamaoka@jpl.org>

Re: gnus-util.el loads rmail

[Steve Youngs]

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

|--==> "KY" == Katsumi Yamaoka <yamaoka@jpl.org> writes:

  KY> A patch for the XEmacs package is below.  However, please ignore
  KY> it if you consider it is not necessary.

Personally, I don't think it would be necessary, but I'll keep the
patch handy just in case I see any FAQs about it.

Thanks!

-- 
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
|        XEmacs - The only _______ you'll ever need.       |
|          Fill in the blank, yes, it's THAT good!         |
|------------------------------<sryoungs@bigpond.net.au>---|

[-- Attachment #2: Type: application/pgp-signature, Size: 256 bytes --]