rfc2231-parse-string: Decode encoded value after concatenating segments

rfc2231-parse-string: Decode encoded value after concatenating segments

[Reiner Steib]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

Hi,

this change...

,----
| 2004-12-21  Katsumi Yamaoka  <yamaoka@jpl.org>
| 
| 	* rfc2231.el (rfc2231-parse-string): Decode encoded value after
| 	concatenating segments rather than before concatenating them.
| 	Suggested by ARISAWA Akihiro <ari@mbf.ocn.ne.jp>.
`----

... breaks displaying of external body parts for me if the file name
spans more than one line, like this one:

,----
| Content-Type: message/external-body; 
|  name*0*=us-ascii''%2ftmp%2fste%2fgnus%2fattachment-external-body-test-directory;
|  name*1*=%2ftest-file-2.txt; access-type=local-file
`----

Here is an external body part:


[-- Attachment #2: /tmp/ste/gnus/attachment-external-body-test-directory/test-file-2.txt --]
[-- Type: message/external-body, Size: 117 bytes --]

[-- Attachment #3: Type: text/plain, Size: 534 bytes --]


When I eval revision 6.11.2.2 of rfc2231.el (evaluation the defun
`rfc2231-parse-string' is sufficient) everything is displayed fine:

,----
| [2. message/external-body; test-file-2.txt]...
`----

When I eval revision 6.11.2.4 (latest revision in v5-10 branch) of
rfc2231.el, I get:

,----
| [2. message/external-body; us-ascii''%2ftmp%2fste%2fgnus%2fattachment-external-body-test-directory%2ftest-file-2.txt]...
`----

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: rfc2231-parse-string: Decode encoded value after concatenating segments

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 741 bytes --]

>>>>> In <v9ll3tiia5.fsf@marauder.physik.uni-ulm.de> Reiner Steib wrote:

> this change...

> ,----
>| 2004-12-21  Katsumi Yamaoka  <yamaoka@jpl.org>
>| 
>| 	* rfc2231.el (rfc2231-parse-string): Decode encoded value after
>| 	concatenating segments rather than before concatenating them.
>| 	Suggested by ARISAWA Akihiro <ari@mbf.ocn.ne.jp>.
> `----

> ... breaks displaying of external body parts for me if the file name
> spans more than one line, like this one:

Thanks for pointing it out.  I've fixed it in the v5-10 branch
and the trunk.  The change I'd made at the end of last year was
insufficient; I should have taken care that not only a segmented
parameter but also other parameters might be there.  Here's a
report I sent then:


[-- Attachment #2: Type: message/rfc822, Size: 895 bytes --]

From: Katsumi Yamaoka <yamaoka@jpl.org>
To: bugs@gnus.org
Cc: semi-gnus-ja@meadowy.org
Subject: Fixed: rfc2231.el decoder bug
Date: Tue, 21 Dec 2004 18:38:15 +0900
Message-ID: <b9yu0qgt2ig.fsf_-_@jpl.org>

Hi,

ARISAWA Akihiro reported there is a bug in the rfc2231 decoder.
He wrote that the decoder doesn't decode encoded long values
correctly as follows:

(rfc2231-parse-string
 (concat "Content-Disposition: attachment;"
	 (rfc2231-encode-string
	  "filename"
	  "一二三四五六七八九零一二三四五六七八九零.pdf")))
("content-disposition:attachment"
 (filename . "一二三四五六七八九零一二三四五六七八6eNm^[(B.pdf"))

I've fixed it in both the trunk and the v5-10 branch.

Regards,