* (display . [not expire]) and (gnus-show-threads nil)
@ 2004-04-27 19:15 Dan Christensen
2004-05-16 12:02 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Dan Christensen @ 2004-04-27 19:15 UTC (permalink / raw)
In my spam group, I want to hide expirable articles, so I set
(display. [not expire]) in my group parameters. This works find with
a threaded display. But I want to sort the articles, not the threads,
by spamminess, so I set (gnus-show-threads nil). But when I do the
latter, I see the expirable articles now. Any idea what's going on?
Dan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (display . [not expire]) and (gnus-show-threads nil)
2004-04-27 19:15 (display . [not expire]) and (gnus-show-threads nil) Dan Christensen
@ 2004-05-16 12:02 ` Lars Magne Ingebrigtsen
2004-07-06 14:52 ` Dan Christensen
0 siblings, 1 reply; 6+ messages in thread
From: Lars Magne Ingebrigtsen @ 2004-05-16 12:02 UTC (permalink / raw)
Dan Christensen <jdc@uwo.ca> writes:
> In my spam group, I want to hide expirable articles, so I set
> (display. [not expire]) in my group parameters. This works find with
> a threaded display. But I want to sort the articles, not the threads,
> by spamminess, so I set (gnus-show-threads nil). But when I do the
> latter, I see the expirable articles now. Any idea what's going on?
It's a bug, I guess. The same thing happens with dormant articles --
they're only dormant if they're in a threaded display.
Let's see...
;; When unthreaded, all articles are always shown.
(setq gnus-newsgroup-limit
(mapcar
(lambda (header) (mail-header-number header))
gnus-newsgroup-headers)))
Ah. So it's meant to be that way. :-)
Anybody object to changing the code so that unthreaded display hides
dormants and respects `display'?
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (display . [not expire]) and (gnus-show-threads nil)
2004-05-16 12:02 ` Lars Magne Ingebrigtsen
@ 2004-07-06 14:52 ` Dan Christensen
2004-07-06 23:12 ` Katsumi Yamaoka
0 siblings, 1 reply; 6+ messages in thread
From: Dan Christensen @ 2004-07-06 14:52 UTC (permalink / raw)
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> Dan Christensen <jdc@uwo.ca> writes:
>
>> In my spam group, I want to hide expirable articles, so I set
>> (display. [not expire]) in my group parameters. This works find with
>> a threaded display. But I want to sort the articles, not the threads,
>> by spamminess, so I set (gnus-show-threads nil). But when I do the
>> latter, I see the expirable articles now. Any idea what's going on?
>
> It's a bug, I guess. The same thing happens with dormant articles --
> they're only dormant if they're in a threaded display.
...
> Anybody object to changing the code so that unthreaded display hides
> dormants and respects `display'?
It's been six weeks and there weren't any objections. Could someone
apply the following patch? (I have copyright assignment papers on file.)
Thanks,
Dan
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-sum.el.patch --]
[-- Type: text/x-patch, Size: 840 bytes --]
--- gnus-sum.el.orig 2004-07-06 10:32:35.000000000 -0400
+++ gnus-sum.el 2004-07-06 10:38:29.000000000 -0400
@@ -3602,16 +3602,10 @@
(when gnus-build-sparse-threads
(gnus-build-sparse-threads))
;; Find the initial limit.
- (if gnus-show-threads
- (if show-all
- (let ((gnus-newsgroup-dormant nil))
- (gnus-summary-initial-limit show-all))
- (gnus-summary-initial-limit show-all))
- ;; When unthreaded, all articles are always shown.
- (setq gnus-newsgroup-limit
- (mapcar
- (lambda (header) (mail-header-number header))
- gnus-newsgroup-headers)))
+ (if show-all
+ (let ((gnus-newsgroup-dormant nil))
+ (gnus-summary-initial-limit show-all))
+ (gnus-summary-initial-limit show-all))
;; Generate the summary buffer.
(unless no-display
(gnus-summary-prepare))
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (display . [not expire]) and (gnus-show-threads nil)
2004-07-06 14:52 ` Dan Christensen
@ 2004-07-06 23:12 ` Katsumi Yamaoka
2004-07-07 2:19 ` Dan Christensen
0 siblings, 1 reply; 6+ messages in thread
From: Katsumi Yamaoka @ 2004-07-06 23:12 UTC (permalink / raw)
>>>>> In <87hdsl89xr.fsf@uwo.ca>
>>>>> Dan Christensen <jdc@uwo.ca> wrote:
> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
[...]
>> Anybody object to changing the code so that unthreaded display hides
>> dormants and respects `display'?
> It's been six weeks and there weren't any objections. Could someone
> apply the following patch? (I have copyright assignment papers on file.)
I agree with that change. Could you please write the ChangeLog
entry? For the ``minor fix to gnus-articles-to-read'' article
too. It's harder to me than writing Lisp codes. :-p
--
Katsumi Yamaoka <yamaoka@jpl.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (display . [not expire]) and (gnus-show-threads nil)
2004-07-06 23:12 ` Katsumi Yamaoka
@ 2004-07-07 2:19 ` Dan Christensen
2004-07-07 2:36 ` Katsumi Yamaoka
0 siblings, 1 reply; 6+ messages in thread
From: Dan Christensen @ 2004-07-07 2:19 UTC (permalink / raw)
Cc: ding
Katsumi Yamaoka <yamaoka@jpl.org> writes:
>>>>>> In <87hdsl89xr.fsf@uwo.ca>
>>>>>> Dan Christensen <jdc@uwo.ca> wrote:
>
>> It's been six weeks and there weren't any objections. Could someone
>> apply the following patch? (I have copyright assignment papers on file.)
>
> I agree with that change. Could you please write the ChangeLog
> entry? For the ``minor fix to gnus-articles-to-read'' article
> too. It's harder to me than writing Lisp codes. :-p
Sure, sorry for not doing this in the first place.
2004-07-06 Dan Christensen <jdc@uwo.ca>
* gnus-sum.el (gnus-summary-read-group-1): When summary
is unthreaded, respect display group parameter.
(gnus-articles-to-read): Remove unused reference to
display group parameter.
Dan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (display . [not expire]) and (gnus-show-threads nil)
2004-07-07 2:19 ` Dan Christensen
@ 2004-07-07 2:36 ` Katsumi Yamaoka
0 siblings, 0 replies; 6+ messages in thread
From: Katsumi Yamaoka @ 2004-07-07 2:36 UTC (permalink / raw)
>>>>> In <87isd0tv8f.fsf@uwo.ca>
>>>>> Dan Christensen <jdc@uwo.ca> wrote:
> 2004-07-06 Dan Christensen <jdc@uwo.ca>
> * gnus-sum.el (gnus-summary-read-group-1): When summary
> is unthreaded, respect display group parameter.
> (gnus-articles-to-read): Remove unused reference to
> display group parameter.
Thanks. I've committed those changes.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-07-07 2:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-04-27 19:15 (display . [not expire]) and (gnus-show-threads nil) Dan Christensen
2004-05-16 12:02 ` Lars Magne Ingebrigtsen
2004-07-06 14:52 ` Dan Christensen
2004-07-06 23:12 ` Katsumi Yamaoka
2004-07-07 2:19 ` Dan Christensen
2004-07-07 2:36 ` Katsumi Yamaoka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).