Re: bug in message.el, message-forward-make-body-plain

[Katsumi Yamaoka <yamaoka@jpl.org>]

>>>>> In <87hdn5y970.fsf@orebokech.com> Romain Francoise wrote:

> Katsumi, what do you think?

I think your patch is the best solution.  I've installed it.

>>>>> In <87y8ghyf39.fsf@orebokech.com> Romain Francoise wrote:

> 2003-10-29  Simon Josefsson  <jas@extundo.com>

> 	* message.el (message-forward-make-body-plain): Remove ignored
> 	headers.  Tiny patch from Andre Srinivasan <andre@e2open.com>.
> 	(message-forward-make-body-plain): Fix ARG=1.

> The test is weird:

> (when (and (not current-prefix-arg)
>            message-forward-ignored-headers)

> how can current-prefix-arg be nil since you call this function from C-u
> C-c C-f?  Its value is '(4) here... unless I'm missing something.

It is likely if a user has set message-forward-as-mime as nil
and uses the `C-c C-f' command.  I guess that was the mere copy
of an old code.  In addition, I noticed there's also a problem
similar to this when the `3 C-c C-f' command is used, and fixed
it.  Anyway, I'm thankful to Ted and Romain who gave me a good
understanding.

BTW, even for raw forwarding, isn't there a demand to remove
some headers?  For instance, a lot of Received headers will
usually be unnecessary.  Furthermore, if a header such as the
following

Xref: localhost trash:99999

is forwarded, the person who wrote the message may be offended.
Of course, we can remove them manually, though.