Re: [PATCH] md4.el and ntlm.el

[Katsumi Yamaoka <yamaoka@jpl.org>]

Hi,

>>>>> In [emacs-mime-en : No.00115]
>>>>>	Simon Josefsson <jas@extundo.com> wrote:

> Hello, first thanks for assigning the copyright of these two files.
> While writing them, did anyone but you contribute to files?  Have you
> merged patches from anyone else?  According to the FLIM ChangeLog and
> CVS logs, you and Kenichi OKADA have touched them, and we have papers
> for that.

> Also, after installing these files into Gnus, we have made the
> following modifications.  Do you agree with them?  Any suggestions?
> Please consider including them in FLIM.  The patch is against the
> flim-1_14 branch in CVS.

> Thanks,
> Simon

[...]

I also add the following change to ntlm.el in Gnus.  Although
it is needless if APEL provides `string-as-unibyte' for XEmacs,
Gnus doesn't use it.

2004-01-05  Katsumi Yamaoka  <yamaoka@jpl.org>

	* ntlm.el (ntlm-string-as-unibyte): New macro.
	(ntlm-build-auth-response): Use it.

--- ntlm.el~	2004-01-05 02:12:22 +0000
+++ ntlm.el	2004-01-05 04:44:07 +0000
@@ -105,13 +105,19 @@
 	    domain		;bufer field
 	    )))
 
+(eval-when-compile
+  (defmacro ntlm-string-as-unibyte (string)
+    (if (fboundp 'string-as-unibyte)
+	`(string-as-unibyte ,string)
+      string)))
+
 (defun ntlm-build-auth-response (challenge user password-hashes)
   "Return the response string to a challenge string CHALLENGE given by
 the NTLM based server for the user USER and the password hash list
 PASSWORD-HASHES.  NTLM uses two hash values which are represented
 by PASSWORD-HASHES.  PASSWORD-HASHES should be a return value of
  (list (ntlm-smb-passwd-hash password) (ntlm-md4hash password))"
-  (let* ((rchallenge (string-as-unibyte challenge))
+  (let* ((rchallenge (ntlm-string-as-unibyte challenge))
 	 ;; get fields within challenge struct
 	 ;;(ident (substring rchallenge 0 8))	;ident, 8 bytes
 	 ;;(msgType (substring rchallenge 8 12))	;msgType, 4 bytes

Regards,
-- 
Katsumi Yamaoka <yamaoka@jpl.org>