Gnus development mailing list
 help / color / mirror / Atom feed
From: Daiki Ueno <ueno@unixuser.org>
To: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: 935@emacsbugs.donarmstrong.com,  Sven Joachim <svenjoac@gmx.de>,
	 ding@gnus.org
Subject: Re: bug#935: 23.0.60; gnus-mime-view-part-as-charset displays non-ASCII characters as octals
Date: Tue, 09 Sep 2008 20:46:03 +0900	[thread overview]
Message-ID: <bc593ff6-9144-440d-b3c0-c827bcbcf9ef@broken.deisui.org> (raw)
In-Reply-To: <b4mr67unnfk.fsf__39297.7221440107$1220923731$gmane$org@jpl.org> (Katsumi Yamaoka's message of "Tue, 09 Sep 2008 10:00:15 +0900")

>>>>> In <b4mr67unnfk.fsf__39297.7221440107$1220923731$gmane$org@jpl.org> 
>>>>>	Katsumi Yamaoka <yamaoka@jpl.org> wrote:
> -(defun gnus-mime-strip-charset-parameters (handle)
> -  "Strip charset parameters from HANDLE."
> +(defun gnus-mime-set-charset-parameters (handle)
> +  "Set charset to parameters in HANDLE.
> +The value of `gnus-newsgroup-charset' is used as a charset."
>    (if (stringp (car handle))
>        (mapc #'gnus-mime-strip-charset-parameters (cdr handle))

Should this line also be changed to call
gnus-mime-set-charset-parameters?

I would also like to suggest that gnus-mime-set-charset-parameters
accept CHARSET as its 2nd arg to avoid dependency to the global variable
gnus-newsgroup-charset.

Regards,
-- 
Daiki Ueno



  parent reply	other threads:[~2008-09-09 11:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-08 20:54 Sven Joachim
2008-09-09  1:00 ` Katsumi Yamaoka
2008-09-09  6:23   ` Katsumi Yamaoka
     [not found] ` <b4mr67unnfk.fsf__39297.7221440107$1220923731$gmane$org@jpl.org>
2008-09-09 11:46   ` Daiki Ueno [this message]
2008-09-09 22:48     ` Katsumi Yamaoka
2008-09-14 16:48       ` Sven Joachim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc593ff6-9144-440d-b3c0-c827bcbcf9ef@broken.deisui.org \
    --to=ueno@unixuser.org \
    --cc=935@emacsbugs.donarmstrong.com \
    --cc=ding@gnus.org \
    --cc=svenjoac@gmx.de \
    --cc=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).