From: Glenn Morris <rgm@gnu.org>
To: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: emacs-devel@gnu.org, ding@gnus.org
Subject: Re: Gnus and No Gnus
Date: Mon, 07 Sep 2009 17:31:33 -0400 [thread overview]
Message-ID: <bnocpmzbka.fsf__14698.7158841968$1252384186$gmane$org@fencepost.gnu.org> (raw)
In-Reply-To: <b4mvdjvez4y.fsf@jpl.org>
Katsumi Yamaoka wrote:
> Today I tried synch'ing the Gnus trunk with the Emacs trunk and
> found a problem concerning `float-time'.
Sorry, I did my best to think about these issues.
> In time-date.el, `define-obsolete-function-alias' is not available
> in Emacs 21 that Gnus still supports. It causes an error when
> loading gnus-load.el.
I'm not suggesting this as a solution to this issue, but does the very
latest Gnus really need to run on 3 major versions of Emacs? When are
you going to drop support for Emacs 21?
> In ecomplete.el, gnus-util.el and time-date.el, (featurep 'xemacs)
> is used for checking if `float-time' is available like this:
>
> (if (featurep 'xemacs)
> (time-to-seconds time)
> (float-time time))
>
> However, XEmacs may implement `float-time' in the future.
I used featurep in preference to fboundp to avoid compilation
warnings, and so that the compiler could optimise the test away.
> Therefore I made changes in those files as attached below. WDYT?
Fine. I would then stick a with-no-warnings around every use of
time-to-seconds, and an eval-and-compile around the revised definition
of gnus-float-time.
next prev parent reply other threads:[~2009-09-07 21:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-07 12:07 Katsumi Yamaoka
2009-09-07 21:31 ` Glenn Morris [this message]
[not found] ` <bnocpmzbka.fsf@fencepost.gnu.org>
2009-09-08 2:15 ` Stephen J. Turnbull
2009-09-08 4:46 ` Teemu Likonen
2009-09-15 8:10 ` Steinar Bang
2009-09-08 7:11 ` Glenn Morris
2009-09-15 8:13 ` Steinar Bang
2009-09-15 13:10 ` Ted Zlatanov
2009-09-08 5:15 ` Katsumi Yamaoka
2009-09-08 7:19 ` Glenn Morris
2009-09-08 11:13 ` Katsumi Yamaoka
2009-09-08 16:49 ` Glenn Morris
2009-09-08 19:08 ` Stephen J. Turnbull
2009-09-09 9:31 ` Katsumi Yamaoka
2009-09-15 8:14 ` Steinar Bang
2009-09-15 17:15 ` Reiner Steib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='bnocpmzbka.fsf__14698.7158841968$1252384186$gmane$org@fencepost.gnu.org' \
--to=rgm@gnu.org \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).