Re: [flow-fill.el] Filling of quoted blank lines

[Ralf Angeli <dev.null@iwi.uni-sb.de>]

* Simon Josefsson (2003-12-04) writes:

> I hope this is slightly more robust, please test it.

Hm, doesn't seem to work correctly.

I am testing it with an article in de.comp.text.tex (MID:
<news:3fcaafbd$0$22267$9b622d9e@news.freenet.de>) which encloses the
following lines:

,----
| >> unterscheidet einen "Heinrich Paul Mueller (H.P.Mueller)" vom
| >> "Hans-Peter Mueller (H.-P. Mueller").
| > 
| > Wenn das in der neuesten verfügbaren Version so ist, wäre wohl ein
| > Bug-Report an den Autor des custom-bib-Pakets angebracht.
`----

If I understand correctly, your code will first search forward until
it finds ` $'.  In the above example point will then be at the end of
the "empty" line.  Then (forward-char 1) is called and point will be
at the beginning of `> Wenn das ...'.  So the following test regarding
`skiponeline' will never see the the "empty" line.

There is another article on Gmane I am using for testing.  You can
find it at
<URL:http://article.gmane.org/gmane.linux.debian.ports.powerpc/14615>.

With the new code e.g. the line starting with "... Seriously, folks,
..." in the second paragraph will get filled with the first paragraph.
I haven't looked into it and cannot tell, where the problem is though.

> It also fixes a long-standing problem in that:
>
> foo
> -- 
> bar
>
> would be flowed together, when it shouldn't.

Yes, I saw this as well and it is good that you address it with the
new code because the solution I proposed was even more error prone as
a line ending with `some text> ' is more common than a dash at the
end.

> There really need to be a regression test harness for flow-fill, it is
> difficult to tell what consequences even a minor change would have.

If you want to, I could post some test articles to this thread,
e.g. like the two mentioned above.  I just have to figure out how I
can add `format=flowed' to the header and what test cases would be
needed exactly.

Regards,
Ralf

-- 
 Moo!
     `~~_.
______',,/______ No gnus is bad news.