Gnus development mailing list
 help / color / mirror / Atom feed
From: Miles Bader <miles.bader@necel.com>
To: ding@gnus.org
Subject: Re: The type of gnus-ignored-from-addresses
Date: Fri, 27 Apr 2007 13:00:11 +0900	[thread overview]
Message-ID: <buo3b2m5uwk.fsf@dhapc248.dev.necel.com> (raw)
In-Reply-To: <v9slamzx8i.fsf@marauder.physik.uni-ulm.de>

Reiner Steib <reinersteib+gmane@imap.cc> writes:
> I don't want to start another discussion about conventions, but...
>
> | 	* gnus-util.el (gnus-orify-regexp): New function.
> | 
> | 	* message.el (gnus-util): Require it.
> | 	(message-dont-reply-to-names): Use gnus-orify-regexp.
>
> ... is preferable to...
>
> | 	Improve the type of gnus-ignored-from-addresses.
> | 	* gnus-util.el (gnus-orify-regexp): New function.
> | 	* message.el (gnus-util): Require it.

Is it?  I think it's often more readable if blank lines are reserved for
separating independent logical changes, which the above clearly aren't.

While too few blank lines can make things hard to read, too _many_ blank
lines can also hurt -- and at a glance I think Didier's entry is
actually a fair-bit more readable than your "better" example, simply
because it's more concise.

[I think it would be even better to use something in between, where the
related stuff was grouped, and the unrelated stuff was blank-line separated.]

-Miles
-- 
Everywhere is walking distance if you have the time.  -- Steven Wright




      reply	other threads:[~2007-04-27  4:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-24 13:50 Didier Verna
2007-04-24 23:49 ` Katsumi Yamaoka
2007-04-25  7:21   ` Didier Verna
2007-04-25  8:03     ` Katsumi Yamaoka
2007-04-25 10:04       ` Didier Verna
2007-04-25 11:10         ` Katsumi Yamaoka
2007-04-26 20:39     ` Reiner Steib
2007-04-27  4:00       ` Miles Bader [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=buo3b2m5uwk.fsf@dhapc248.dev.necel.com \
    --to=miles.bader@necel.com \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).