Drafts and autosave

Drafts and autosave

[Jan Vroonhof]

Wouldn't it be a good idea to overide the autosave routines in the
messages such that they get autosaved as draft articles directly?

i.e. write to say ~/News/drafts/drafts/15 instead of ~/News/drafst/drafts/#15#

Jan

Re: Drafts and autosave

[Colin Rafferty]

Jan Vroonhof writes:

> Wouldn't it be a good idea to overide the autosave routines in the
> messages such that they get autosaved as draft articles directly?

I think that this is a great idea.  Unfortunately, I can't find the
code that sets up the message buffer to be associated with a file.

Otherwise, judicious setting of `auto-save-visited-file-name' would
give us exactly the effect we need.

-- 
Colin

Re: Drafts and autosave

[Jan Vroonhof]

Colin Rafferty <colin@xemacs.org> writes:

> I think that this is a great idea.  Unfortunately, I can't find the
> code that sets up the message buffer to be associated with a file.

(defun message-set-auto-save-file-name ()
  "Associate the message buffer with a file in the drafts directory."

which uses

nndraft-request-associate-buffer 

However this does an explicit
      (setq buffer-auto-save-file-name (make-auto-save-file-name)))

!!!

Why not (setq buffer-auto-save-file-name buffer-file-name))? If that
is to surprising may suggest that at the end of
nndraft-request-associate-buffer there is a (save-buffer) instead of
(clear-visited-file-modtime) such that nndraft picks them up and then
recommend M-x recover-file?


Jan

Re: Drafts and autosave

[Jan Vroonhof]

Jan Vroonhof <vroonhof@math.ethz.ch> writes:

> Why not (setq buffer-auto-save-file-name buffer-file-name))? If that
> is to surprising may suggest that at the end of
> nndraft-request-associate-buffer there is a (save-buffer) instead of
> (clear-visited-file-modtime) such that nndraft picks them up and then
> recommend M-x recover-file?

I just did this. Needed to add a (setq buffer-modified-p t) too.
However this is bad in the sense that now if you abort editing the
article it always ends up in nndrafs:

Either there should be away of automatically deleting the saved file
again or nndrafts needs to be more smart about auto-save-files

Jan

Re: Drafts and autosave

[Colin Rafferty]

Jan Vroonhof writes:
> Colin Rafferty <colin@xemacs.org> writes:

>> I think that this is a great idea.  Unfortunately, I can't find the
>> code that sets up the message buffer to be associated with a file.

> (defun message-set-auto-save-file-name ()
>   "Associate the message buffer with a file in the drafts directory."

> which uses

> nndraft-request-associate-buffer 

> However this does an explicit
>       (setq buffer-auto-save-file-name (make-auto-save-file-name)))

Isn't this a beta list?  Can't we suggest patches ourselves?

The only defect is that after a do-auto-save, the buffer is still
shown as modified (although it's really gone into the correct place).

Here is the patch.

1998-10-30  Jan Vroonhof  <vroonhof@math.ethz.ch>

	* nndraft.el (nndraft-request-associate-buffer): Set the autosave
	file name to be the actual file name.

--- lisp/nndraft.el~	Sat Oct 10 20:32:06 1998
+++ lisp/nndraft.el	Fri Oct 30 10:48:25 1998
@@ -156,7 +156,7 @@
 		     group (nnoo-current-server 'nndraft) t 'noinsert))
       (setq file (nndraft-article-filename article)))
     (setq buffer-file-name (expand-file-name file))
-    (setq buffer-auto-save-file-name (make-auto-save-file-name))
+    (setq buffer-auto-save-file-name buffer-file-name)
     (clear-visited-file-modtime)
     article))
 

;; Colin

Re: Drafts and autosave

[Dan Christensen]

Colin Rafferty <colin@xemacs.org> writes:
> 1998-10-30  Jan Vroonhof  <vroonhof@math.ethz.ch>
> 
> 	* nndraft.el (nndraft-request-associate-buffer): Set the autosave
> 	file name to be the actual file name.

I don't like this idea.  The whole point of autosaves is that they
are to a different file.  If I `C-x C-s' and then delete a portion 
of a message I'm writing, I want to be able to revert-buffer back
to the saved version.  I don't want random autosaves to take away
that ability.

If this gets changed, at least make it optional.

I think the main complaint people have about the current behaviour
is that unwanted autosaves can stick around, e.g. when one does
`C-c C-k'.  Maybe in those situations Gnus could ask the user
whether he/she wants the autosave file deleted?  Or there could
be a t/nil/ask variable to control this?

Dan

-- 
Dan Christensen
jdc@math.jhu.edu

Re: Drafts and autosave

[Lars Magne Ingebrigtsen]

Dan Christensen <jdc@chow.mat.jhu.edu> writes:

> > 	* nndraft.el (nndraft-request-associate-buffer): Set the autosave
> > 	file name to be the actual file name.
> 
> I don't like this idea.  The whole point of autosaves is that they
> are to a different file.

Yup.

> I think the main complaint people have about the current behaviour
> is that unwanted autosaves can stick around, e.g. when one does
> `C-c C-k'.

If you do `C-c C-k', the autosave file is deleted.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Drafts and autosave

[Jan Vroonhof]

Colin Rafferty <colin@xemacs.org> writes:

> Isn't this a beta list?  Can't we suggest patches ourselves?

Yes we can hovever for some reason XEmacs didn't make the backup file
when i patched it so I had nothing to diff with and I was too lazy to
fetch the origional again. 
I guess I am spoilt by XEmacs being under CVS.

> 
> 	* nndraft.el (nndraft-request-associate-buffer): Set the autosave
> 	file name to be the actual file name.

The problem is that this changes the behaviour of C-x C-s which people 
could object too (I see the nndraft file as the autosave file and then 
it is ok, but other don't).

Jan

Re: Drafts and autosave

[Jan Vroonhof]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> 
> > I think the main complaint people have about the current behaviour
> > is that unwanted autosaves can stick around, e.g. when one does
> > `C-c C-k'.

No that is not the Main complaint. The main problem is that there is
no initial file in the nndraft group. I.e. if you are editng a new
mail and Emacs crashes/you exit X/you hang up then ONLY the autosave
file exists not the normal file. Therefore it does not show up in the
nndraft group.

What I would like is that when starting to edit the empty message is
saved to the nndraft group so it exits. When you visit it the
normal Emacs mechanisms will inform you there is an autosave file and
suggest to M-x recover-file. 

Jan

diff -u /u/users/vroonhof/scratch/xemacs/orig/pgnus-0.40/lisp/nndraft.el /u/users/vroonhof/.xemacs/lisp/gnus/nndraft.el
--- /u/users/vroonhof/scratch/xemacs/orig/pgnus-0.40/lisp/nndraft.el	Sat Oct 31 16:58:18 1998
+++ /u/users/vroonhof/.xemacs/lisp/gnus/nndraft.el	Sat Oct 31 16:58:18 1998
@@ -157,7 +157,8 @@
       (setq file (nndraft-article-filename article)))
     (setq buffer-file-name (expand-file-name file))
     (setq buffer-auto-save-file-name (make-auto-save-file-name))
-    (clear-visited-file-modtime)
+    (set-buffer-modified-p t)
+    (save-buffer)
     article))
 
 (deffoo nndraft-request-expire-articles (articles group &optional server force)

Re: Drafts and autosave

[Dan Christensen]

Jan Vroonhof <vroonhof@math.ethz.ch> writes:
> What I would like is that when starting to edit the empty message is
> saved to the nndraft group so it exists. When you visit it the
> normal Emacs mechanisms will inform you there is an autosave file and
> suggest to M-x recover-file. 

I think this makes sense.

Dan

-- 
Dan Christensen
jdc@math.jhu.edu

Re: Drafts and autosave

[Lars Magne Ingebrigtsen]

Jan Vroonhof <vroonhof@math.ethz.ch> writes:

> What I would like is that when starting to edit the empty message is
> saved to the nndraft group so it exits. When you visit it the
> normal Emacs mechanisms will inform you there is an autosave file and
> suggest to M-x recover-file. 

Wouldn't it be an even better idea for nndraft to scan for autosave
files in the draft group?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Drafts and autosave

[Nelson Jose dos Santos Ferreira]

On 07 Nov 1998 14:40:08 +0100, Lars Magne Ingebrigtsen (aka "Lars"),
regarding 'Re: Drafts and autosave', said: 

    Lars> Jan Vroonhof <vroonhof@math.ethz.ch> writes:
    >> What I would like is that when starting to edit the empty message is
    >> saved to the nndraft group so it exits. When you visit it the
    >> normal Emacs mechanisms will inform you there is an autosave file and
    >> suggest to M-x recover-file. 

    Lars> Wouldn't it be an even better idea for nndraft to scan for autosave
    Lars> files in the draft group?


[...]

You mean message buffers autosaves recovered automagically
into nndraft. Great idea!

---
Nelson Jose dos Santos Ferreira |  .  .  .  | INESC/PT-Servicos 
Systems Integrator              | |. /  / . | Lisbon,PORTUGAL
mailto:Nelson.Ferreira@inesc.pt |.||\| | /  | Phone:+351 (1) 3100050
                                | .|<:/  \. | Fax  :+351 (1) 3100008

Re: Drafts and autosave

[Lars Magne Ingebrigtsen]

Nelson Jose dos Santos Ferreira <Nelson.Ferreira@inesc.pt> writes:

> You mean message buffers autosaves recovered automagically
> into nndraft.

Yes.  I'm not sure that's not naughty, though.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Drafts and autosave

[Joev Dubach]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> Nelson Jose dos Santos Ferreira <Nelson.Ferreira@inesc.pt> writes:
>> You mean message buffers autosaves recovered automagically
>> into nndraft.
> Yes.  I'm not sure that's not naughty, though.

Why not ask during Gnus startup, just like you do when deciding
whether or not to incorporate an autosaved .newsrc-dribble from a
crashed session into a new session?

Joev

  "The ten thousand things
   How long do any persist?
   Netscape, too, has gone."
          -- Jason Willoughby's haiku error message

Re: Drafts and autosave

[Robert Bihlmeyer]

Hi,

>>>>> On 08 Nov 1998 00:36:51 +0100
>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org> said:

 Lars> Nelson Jose dos Santos Ferreira <Nelson.Ferreira@inesc.pt>
 Lars> writes:
 >> You mean message buffers autosaves recovered automagically into
 >> nndraft.

 Lars> Yes. I'm not sure that's not naughty, though.

If you find "#N#", recover it if "N" does not exist. Ask the user if
he wishes to recover if "N" does exist. (Or is this already done via
the normal Emacs mechanisms?)

	Robbe

-- 
Robert Bihlmeyer	reads: Deutsch, English, MIME, Latin-1, NO SPAM!
<robbe@orcus.priv.at>	<http://stud2.tuwien.ac.at/~e9426626/sig.html>

Re: Drafts and autosave

[Jan Vroonhof]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> > What I would like is that when starting to edit the empty message is
> > saved to the nndraft group so it exits. When you visit it the
> > normal Emacs mechanisms will inform you there is an autosave file and
> > suggest to M-x recover-file. 
> 
> Wouldn't it be an even better idea for nndraft to scan for autosave
> files in the draft group?

Well I'll be happy for anything that makes nndraft take notice of the
autosaves. How to do it exactly is matter of taste.  If you do decide
to scan for autosave files don't you have some problems when people
have customized their autosaving (for instance in a seperate dir)?

Jan

Re: Drafts and autosave

[Lars Magne Ingebrigtsen]

dubach@dcepea.harvard.edu (Joev Dubach) writes:

> Why not ask during Gnus startup, just like you do when deciding
> whether or not to incorporate an autosaved .newsrc-dribble from a
> crashed session into a new session?

Well, Gnus would have to ask when then group was being scanned, but
that happens at startup...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Drafts and autosave

[Lars Magne Ingebrigtsen]

Jan Vroonhof <vroonhof@math.ethz.ch> writes:

> Well I'll be happy for anything that makes nndraft take notice of the
> autosaves. How to do it exactly is matter of taste.  If you do decide
> to scan for autosave files don't you have some problems when people
> have customized their autosaving (for instance in a seperate dir)?

That may be a problem.  Er...  Hm.  Perhaps saving the draft when
starting to edit a message is the way to go.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Drafts and autosave

[Nelson Jose dos Santos Ferreira]

On 10 Nov 1998 05:35:10 +0100, Lars Magne Ingebrigtsen (aka "Lars"),
regarding 'Re: Drafts and autosave', said: 

    Lars> Jan Vroonhof <vroonhof@math.ethz.ch> writes:
    >> Well I'll be happy for anything that makes nndraft take notice of the
    >> autosaves. How to do it exactly is matter of taste.  If you do decide
    >> to scan for autosave files don't you have some problems when people
    >> have customized their autosaving (for instance in a seperate dir)?

    Lars> That may be a problem.  Er...  Hm.  Perhaps saving the draft when
    Lars> starting to edit a message is the way to go.


[...]

Hmmm. Shouldn't a look at auto-save-directory do the trick ?
(i.e. if non-nil then the message buffers' autosaves are
there).

Best regards,

	Nelson
---
Nelson Jose dos Santos Ferreira |  .  .  .  | INESC/PT-Servicos 
Systems Integrator              | |. /  / . | Lisbon,PORTUGAL
mailto:Nelson.Ferreira@inesc.pt |.||\| | /  | Phone:+351 (1) 3100050
                                | .|<:/  \. | Fax  :+351 (1) 3100008

Re: Drafts and autosave

[Lars Magne Ingebrigtsen]

Nelson Jose dos Santos Ferreira <Nelson.Ferreira@inesc.pt> writes:

> Hmmm. Shouldn't a look at auto-save-directory do the trick ?
> (i.e. if non-nil then the message buffers' autosaves are
> there).

Hm...  There doesn't seem to be such a variable in Emacs 20.3.  

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Drafts and autosave

[Jan Vroonhof]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Nelson Jose dos Santos Ferreira <Nelson.Ferreira@inesc.pt> writes:
> 
> > Hmmm. Shouldn't a look at auto-save-directory do the trick ?
> > (i.e. if non-nil then the message buffers' autosaves are
> > there).
> 
> Hm...  There doesn't seem to be such a variable in Emacs 20.3.  

I am running with the following patch against 0.42. It does what I
proposed before (do an initial save) and it works here.

bolzano:scratch/xemacs/gnus/pgnus-0.40> diff -u ../../orig/pgnus-0.40/lisp/nndraft.el lisp/nndraft.el
--- ../../orig/pgnus-0.40/lisp/nndraft.el	Sun Oct 11 02:32:06 1998
+++ lisp/nndraft.el	Fri Oct 30 16:49:02 1998
@@ -157,7 +157,8 @@
       (setq file (nndraft-article-filename article)))
     (setq buffer-file-name (expand-file-name file))
     (setq buffer-auto-save-file-name (make-auto-save-file-name))
-    (clear-visited-file-modtime)
+    (set-buffer-modified-p t)
+    (save-buffer)
     article))
 
 (deffoo nndraft-request-expire-articles (articles group &optional server force)
bolzano:scratch/xemacs/gnus/pgnus-0.40> diff -u lisp/message.el~ lisp/message.el
--- lisp/message.el~	Sat Oct 24 07:45:06 1998
+++ lisp/message.el	Thu Nov 12 19:24:37 1998
@@ -3269,7 +3269,9 @@
   "Disassociate the message buffer from the drafts directory."
   (when message-draft-article
     (nndraft-request-expire-articles
-     (list message-draft-article) "drafts" nil t)))
+     (list message-draft-article) "drafts" nil t)
+    (if (and buffer-file-name (file-exists-p buffer-file-name))
+	(delete-file buffer-file-name))))
 
 \f