* Gnus v5.2.35 is released
@ 1996-07-14 18:01 Lars Magne Ingebrigtsen
1996-07-15 17:35 ` Smileys again Jan Vroonhof
1996-07-16 18:15 ` Gnus v5.2.35 is released Mark Eichin
0 siblings, 2 replies; 5+ messages in thread
From: Lars Magne Ingebrigtsen @ 1996-07-14 18:01 UTC (permalink / raw)
Bug fixes.
Get it from <URL:http://www.ifi.uio.no/~larsi/gnus.tar.gz> or
"ftp.ifi.uio.no:/pub/emacs/gnus/".
ChangeLog since last release:
Sun Jul 14 20:01:26 1996 Lars Magne Ingebrigtsen <larsi@ifi.uio.no>
* gnus.el: Gnus v5.2.35 is released.
Sun Jul 14 18:21:14 1996 Lars Magne Ingebrigtsen <larsi@ifi.uio.no>
* gnus-uu.el (gnus-uu-mark-over): Would bug out.
* smiley.el (smiley-regexp-alist): New definition didn't work.
Sun Jul 14 16:52:31 1996 Lars Magne Ingebrigtsen <larsi@hler.ifi.uio.no>
* gnus.el ((provide 'gnus)): Make sure `gnus-directory' is set
when compiling.
Sun Jul 14 15:38:21 1996 Lars Magne Ingebrigtsen <larsi@ifi.uio.no>
* gnus.el: autoload `gnus-copy-article-buffer'.
* message.el (message-do-send-housekeeping): Kill a superfluous
buffers.
* gnus-picon.el (gnus-article-display-picons): Don't bug out on
nil addresses.
* custom.el ((fboundp 'plist-get)): Removed.
((fboundp 'add-to-list)): Removed.
Sun Jul 14 15:30:27 1996 Martin Buchholz <mrb@eng.sun.com>
* gnus.el: Many typo fixes.
Thu Jul 11 18:06:24 1996 Lars Magne Ingebrigtsen <larsi@ifi.uio.no>
* nntp.el (nntp-retrieve-headers-with-xover):
`accept-process-output' from `nntp-server-process'.
Tue Jul 9 07:51:31 1996 Lars Magne Ingebrigtsen <larsi@ylfing.ifi.uio.no>
* gnus-vis.el (gnus-group-make-menu-bar): Un-randomize.
Mon Jul 8 09:53:39 1996 Lars Magne Ingebrigtsen <larsi@ylfing.ifi.uio.no>
* gnus.el (gnus-decode-rfc1522): Goto point-min before decoding.
Mon Jul 8 08:53:50 1996 Nat Makarevitch <nat@nataa.fr.eu.org>
* smiley.el (smiley-regexp-alist): New definition.
Sun Jul 7 13:33:44 1996 Sudish Joseph <sudish@mindspring.com>
* nnmail.el (nnmail-split-fancy-syntax-table): `%' should have
punctuation syntax to support the %-hack in addresses.
--
(domestic pets only, the antidote for overdose, milk.)
larsi@ifi.uio.no * Lars Ingebrigtsen
^ permalink raw reply [flat|nested] 5+ messages in thread
* Smileys again...
1996-07-14 18:01 Gnus v5.2.35 is released Lars Magne Ingebrigtsen
@ 1996-07-15 17:35 ` Jan Vroonhof
1996-07-16 22:08 ` Danny Siu
1996-07-16 18:15 ` Gnus v5.2.35 is released Mark Eichin
1 sibling, 1 reply; 5+ messages in thread
From: Jan Vroonhof @ 1996-07-15 17:35 UTC (permalink / raw)
Cc: ding
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 3892 bytes --]
The following fixes the two aggressive matching of "://" in 5.2.35 and
adds some more mild regexps such that you can read Tom Cristiansen's
messsages.
Patch follows
*** ChangeLog.orig Sun Jul 14 18:44:48 1996
--- ChangeLog Mon Jul 15 19:21:23 1996
***************
*** 1,3 ****
--- 1,8 ----
+ Mon Jul 15 18:11:13 1996 Jan Vroonhof <vroonhof@math.ethz.ch (Jan Vroonhof)>
+
+ * smiley.el (smiley-regexp-alist): Don't match important parts of URLs
+ (smiley-nosey-regexp-alist): New variable.
+
Sun Jul 14 18:21:14 1996 Lars Magne Ingebrigtsen <larsi@ifi.uio.no>
* gnus-uu.el (gnus-uu-mark-over): Would bug out.
*** smiley.el.orig Sun Jul 14 18:40:45 1996
--- smiley.el Mon Jul 15 19:20:08 1996
***************
*** 42,53 ****
(defvar smiley-data-directory (message-xmas-find-glyph-directory "smilies")
"Location of the smiley faces files.")
! (defvar smiley-regexp-alist
'(("\\(:-*[<«]+\\)\\W" 1 "FaceAngry.xpm")
("\\(:-+\\]+\\)\\W" 1 "FaceGoofy.xpm")
("\\(:-*D\\)\\W" 1 "FaceGrinning.xpm")
("\\(:-*[)>}»]+\\)\\W" 1 "FaceHappy.xpm")
! ("\\(:-*[/\\\"]+\\)\\W" 1 "FaceIronic.xpm")
("\\([8|]-*[|Oo%]\\)\\W" 1 "FaceKOed.xpm")
("\\([:|]-*#+\\)\\W" 1 "FaceNyah.xpm")
("\\(:-*[({]+\\)\\W" 1 "FaceSad.xpm")
--- 42,55 ----
(defvar smiley-data-directory (message-xmas-find-glyph-directory "smilies")
"Location of the smiley faces files.")
! ;; Notice the subtle differences in the regular expessions in the two alists below
!
! (defvar smiley-deformed-regexp-alist
'(("\\(:-*[<«]+\\)\\W" 1 "FaceAngry.xpm")
("\\(:-+\\]+\\)\\W" 1 "FaceGoofy.xpm")
("\\(:-*D\\)\\W" 1 "FaceGrinning.xpm")
("\\(:-*[)>}»]+\\)\\W" 1 "FaceHappy.xpm")
! ("\\(:-*[/\\\"]\\)[^\\]" 1 "FaceIronic.xpm")
("\\([8|]-*[|Oo%]\\)\\W" 1 "FaceKOed.xpm")
("\\([:|]-*#+\\)\\W" 1 "FaceNyah.xpm")
("\\(:-*[({]+\\)\\W" 1 "FaceSad.xpm")
***************
*** 58,65 ****
("\\(;-*[>)}»]+\\)\\W" 1 "FaceWinking.xpm")
("\\(:-*[Vvµ]\\)\\W" 1 "FaceWry.xpm")
("\\([:|]-*P\\)\\W" 1 "FaceYukky.xpm"))
! "A list of regexps to map smilies to real images.")
(defvar smiley-flesh-color "yellow"
"Flesh color.")
--- 60,92 ----
("\\(;-*[>)}»]+\\)\\W" 1 "FaceWinking.xpm")
("\\(:-*[Vvµ]\\)\\W" 1 "FaceWry.xpm")
("\\([:|]-*P\\)\\W" 1 "FaceYukky.xpm"))
! "Normal and deformed faces for smilies.")
+ (defvar smiley-nosey-regexp-alist
+ '(("\\(:-+[<«]+\\)\\W" 1 "FaceAngry.xpm")
+ ("\\(:-+\\]+\\)\\W" 1 "FaceGoofy.xpm")
+ ("\\(:-+D\\)\\W" 1 "FaceGrinning.xpm")
+ ("\\(:-+[}»]+\\)\\W" 1 "FaceHappy.xpm")
+ ("\\(:-*)+\\)\\W" 1 "FaceHappy.xpm") ;; The exception that confirms the rule
+ ("\\(:-+[/\\\"]+\\)\\W" 1 "FaceIronic.xpm")
+ ("\\([8|]-+[|Oo%]\\)\\W" 1 "FaceKOed.xpm")
+ ("\\([:|]-+#+\\)\\W" 1 "FaceNyah.xpm")
+ ("\\(:-+[({]+\\)\\W" 1 "FaceSad.xpm")
+ ("\\(:-+[Oo\*]\\)\\W" 1 "FaceStartled.xpm")
+ ("\\(:-+|\\)\\W" 1 "FaceStraight.xpm")
+ ("\\(:-+p\\)\\W" 1 "FaceTalking.xpm")
+ ("\\(:-+d\\)\\W" 1 "FaceTasty.xpm")
+ ("\\(;-+[>)}»]+\\)\\W" 1 "FaceWinking.xpm")
+ ("\\(:-+[Vvµ]\\)\\W" 1 "FaceWry.xpm")
+ ("\\([:|]-+P\\)\\W" 1 "FaceYukky.xpm"))
+ "Smileys with noses. These get less false matches.")
+
+ (defvar smiley-regexp-alist smiley-deformed-regexp-alist
+ "A list of regexps to map smilies to real images.
+ Defaults to the content of smiley-deformed-regexp-alist.
+ An alternative smiley-nose-regexp-alist that
+ matches less aggresively is available.")
+
(defvar smiley-flesh-color "yellow"
"Flesh color.")
--
Jan Vroonhof http://www.math.ethz.ch/~vroonhof/
Mathematik, vroonhof@math.ethz.ch
HG E16, ETH-Zentrum, Tel: +41-1-6325456/25154
Raemistrasse 101, CH-8092 Zuerich. Fax: +41-1-6321085
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Gnus v5.2.35 is released
1996-07-14 18:01 Gnus v5.2.35 is released Lars Magne Ingebrigtsen
1996-07-15 17:35 ` Smileys again Jan Vroonhof
@ 1996-07-16 18:15 ` Mark Eichin
1 sibling, 0 replies; 5+ messages in thread
From: Mark Eichin @ 1996-07-16 18:15 UTC (permalink / raw)
Cc: ding
just a quick note: the change from 5.2.34 to 5.2.35 seems to have broken
something. If I ^c^f to forward a message, it fails with a stack trace
(which I don't have handy - I had to revert and see if it fixed the
problem in order to get some work done :-) from calling buffer-string
with three arguments (nil nil buffername, I think) when the emacs
19.31 version takes *no* arguments... in particular:
message.el:1323: (insert (format "%s" (buffer-string nil nil mailbuf)))
message.el:1440: (insert (format "%s" (buffer-string nil nil messbuf)))
Not sure what you intended - buffer-substring only takes two...
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Smileys again...
1996-07-15 17:35 ` Smileys again Jan Vroonhof
@ 1996-07-16 22:08 ` Danny Siu
1996-07-17 13:55 ` Jan Vroonhof
0 siblings, 1 reply; 5+ messages in thread
From: Danny Siu @ 1996-07-16 22:08 UTC (permalink / raw)
Jan Vroonhof writes:
Jan> The following fixes the two aggressive matching of "://" in 5.2.35
Jan> and adds some more mild regexps such that you can read Tom
Jan> Cristiansen's messsages.
The patch looks good except the :// regexp matches also http://blahblah...
A smiley in a URL is incorrect at all....
--
^..^
'/..\" ( oo ) )~
m( oo )m ,, ,,
/=-=-=-=-=-=-=-=-=-=-=-==-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=\
| Danny Dick-Fung Siu http://www-leland.stanford.edu/~dsiu |
| Reference System Group http://www.csua.berkeley.edu/~dsiu |
| Adobe Systems Incorporated E-Mail:<dsiu@alumni.eecs.berkeley.edu> |
| "What do you expect from a <dsiu@leland.stanford.edu> |
| Cal. Berkeley grad.?" <dsiu@adobe.com> |
\=-=-=-=-=-=-=-=-=-=-=-==-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Smileys again...
1996-07-16 22:08 ` Danny Siu
@ 1996-07-17 13:55 ` Jan Vroonhof
0 siblings, 0 replies; 5+ messages in thread
From: Jan Vroonhof @ 1996-07-17 13:55 UTC (permalink / raw)
Cc: ding
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 4782 bytes --]
Danny Siu <dsiu@mv.us.adobe.com> writes:
> Jan> The following fixes the too aggressive matching of "://" in 5.2.35
> Jan> and adds some more mild regexps such that you can read Tom
> Jan> Cristiansen's messsages.
>
> The patch looks good except the :// regexp matches also http://blahblah...
> A smiley in a URL is incorrect at all....
d*mn, that was exactly the main problem I was trying to fix. Here is
the right version of the patch (against 5.2.36):
*** ChangeLog.orig Tue Jul 16 22:20:15 1996
--- ChangeLog Wed Jul 17 15:46:29 1996
***************
*** 1,3 ****
--- 1,8 ----
+ Wed Jul 17 15:44:51 1996 Jan Vroonhof <vroonhof@math.ethz.ch (Jan Vroonhof)>
+
+ * smiley.el (smiley-deformed-regexp-alist): Fix for matching
+ 'http://' had the wrong slashes.
+
Tue Jul 16 20:05:49 1996 Lars Magne Ingebrigtsen <larsi@hler.ifi.uio.no>
* message.el (message-send-mail): Bugged out under Emacs.
***************
*** 9,14 ****
--- 14,24 ----
Sun Jul 14 20:01:26 1996 Lars Magne Ingebrigtsen <larsi@ifi.uio.no>
* gnus.el: Gnus v5.2.35 is released.
+
+ Mon Jul 15 18:11:13 1996 Jan Vroonhof <vroonhof@math.ethz.ch (Jan Vroonhof)>
+
+ * smiley.el (smiley-regexp-alist): Don't match important parts of URLs
+ (smiley-nosey-regexp-alist): New variable.
Sun Jul 14 18:21:14 1996 Lars Magne Ingebrigtsen <larsi@ifi.uio.no>
*** smiley.el.orig Sun Jul 14 18:40:45 1996
--- smiley.el Wed Jul 17 15:45:09 1996
***************
*** 42,53 ****
(defvar smiley-data-directory (message-xmas-find-glyph-directory "smilies")
"Location of the smiley faces files.")
! (defvar smiley-regexp-alist
'(("\\(:-*[<«]+\\)\\W" 1 "FaceAngry.xpm")
("\\(:-+\\]+\\)\\W" 1 "FaceGoofy.xpm")
("\\(:-*D\\)\\W" 1 "FaceGrinning.xpm")
("\\(:-*[)>}»]+\\)\\W" 1 "FaceHappy.xpm")
! ("\\(:-*[/\\\"]+\\)\\W" 1 "FaceIronic.xpm")
("\\([8|]-*[|Oo%]\\)\\W" 1 "FaceKOed.xpm")
("\\([:|]-*#+\\)\\W" 1 "FaceNyah.xpm")
("\\(:-*[({]+\\)\\W" 1 "FaceSad.xpm")
--- 42,55 ----
(defvar smiley-data-directory (message-xmas-find-glyph-directory "smilies")
"Location of the smiley faces files.")
! ;; Notice the subtle differences in the regular expessions in the two alists below
!
! (defvar smiley-deformed-regexp-alist
'(("\\(:-*[<«]+\\)\\W" 1 "FaceAngry.xpm")
("\\(:-+\\]+\\)\\W" 1 "FaceGoofy.xpm")
("\\(:-*D\\)\\W" 1 "FaceGrinning.xpm")
("\\(:-*[)>}»]+\\)\\W" 1 "FaceHappy.xpm")
! ("\\(:-*[/\\\"]\\)[^//]" 1 "FaceIronic.xpm")
("\\([8|]-*[|Oo%]\\)\\W" 1 "FaceKOed.xpm")
("\\([:|]-*#+\\)\\W" 1 "FaceNyah.xpm")
("\\(:-*[({]+\\)\\W" 1 "FaceSad.xpm")
***************
*** 58,64 ****
("\\(;-*[>)}»]+\\)\\W" 1 "FaceWinking.xpm")
("\\(:-*[Vvµ]\\)\\W" 1 "FaceWry.xpm")
("\\([:|]-*P\\)\\W" 1 "FaceYukky.xpm"))
! "A list of regexps to map smilies to real images.")
(defvar smiley-flesh-color "yellow"
"Flesh color.")
--- 60,91 ----
("\\(;-*[>)}»]+\\)\\W" 1 "FaceWinking.xpm")
("\\(:-*[Vvµ]\\)\\W" 1 "FaceWry.xpm")
("\\([:|]-*P\\)\\W" 1 "FaceYukky.xpm"))
! "Normal and deformed faces for smilies.")
!
! (defvar smiley-nosey-regexp-alist
! '(("\\(:-+[<«]+\\)\\W" 1 "FaceAngry.xpm")
! ("\\(:-+\\]+\\)\\W" 1 "FaceGoofy.xpm")
! ("\\(:-+D\\)\\W" 1 "FaceGrinning.xpm")
! ("\\(:-+[}»]+\\)\\W" 1 "FaceHappy.xpm")
! ("\\(:-*)+\\)\\W" 1 "FaceHappy.xpm") ;; The exception that confirms the rule
! ("\\(:-+[/\\\"]+\\)\\W" 1 "FaceIronic.xpm")
! ("\\([8|]-+[|Oo%]\\)\\W" 1 "FaceKOed.xpm")
! ("\\([:|]-+#+\\)\\W" 1 "FaceNyah.xpm")
! ("\\(:-+[({]+\\)\\W" 1 "FaceSad.xpm")
! ("\\(:-+[Oo\*]\\)\\W" 1 "FaceStartled.xpm")
! ("\\(:-+|\\)\\W" 1 "FaceStraight.xpm")
! ("\\(:-+p\\)\\W" 1 "FaceTalking.xpm")
! ("\\(:-+d\\)\\W" 1 "FaceTasty.xpm")
! ("\\(;-+[>)}»]+\\)\\W" 1 "FaceWinking.xpm")
! ("\\(:-+[Vvµ]\\)\\W" 1 "FaceWry.xpm")
! ("\\([:|]-+P\\)\\W" 1 "FaceYukky.xpm"))
! "Smileys with noses. These get less false matches.")
!
! (defvar smiley-regexp-alist smiley-deformed-regexp-alist
! "A list of regexps to map smilies to real images.
! Defaults to the content of smiley-deformed-regexp-alist.
! An alternative smiley-nose-regexp-alist that
! matches less aggresively is available.")
(defvar smiley-flesh-color "yellow"
"Flesh color.")
Greetings,
Jan
P.S. Should the "nosey" verion match ":)" it still gives some false
matches, but a quick look in rec.humor showed that it is used a lot.
--
Jan Vroonhof http://www.math.ethz.ch/~vroonhof/
Mathematik, vroonhof@math.ethz.ch
HG E16, ETH-Zentrum, Tel: +41-1-6325456/25154
Raemistrasse 101, CH-8092 Zuerich. Fax: +41-1-6321085
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~1996-07-17 13:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1996-07-14 18:01 Gnus v5.2.35 is released Lars Magne Ingebrigtsen
1996-07-15 17:35 ` Smileys again Jan Vroonhof
1996-07-16 22:08 ` Danny Siu
1996-07-17 13:55 ` Jan Vroonhof
1996-07-16 18:15 ` Gnus v5.2.35 is released Mark Eichin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).